Re: Use enums in switch added in pirk pull request 16 ?

+1 will make the change tomorrow. Thanks for feedback. On Fri, Jul 22, 2016 at 1:37 AM, Walter Ray-Dulany wrote: > A minor suggestion: I think we should migrate the switch statement added in > pull request 16 to switch on an enum instead of a string. The switch is > over the list of the primitiv

Use enums in switch added in pirk pull request 16 ?

A minor suggestion: I think we should migrate the switch statement added in pull request 16 to switch on an enum instead of a string. The switch is over the list of the primitive java data types, so we'll know the list at compile time, making it a good enum, candidate, and we would get compile-time

Re: PIRK Components on JIRA

Component leads are useful if you want to make sure that someone (relevant) from the core team sees every issue as it gets reported (as long as it is assigned to something) and then triages it. If your core team is not necessarily divided by focus that way, component leads may not be necessary.

Re: PIRK Components on JIRA

Looks good. I'm a JIRA novice, so I did some quick reading on components. It seems like this structure works well for us at this younger state. For the same reason (our project's youth) I would think it wouldn't make sense to be assigning Component Leads just yet? Like I said, I'm new to JIRA, so

Re: RTC/CTR Discussion

One of the nice effects of RTC is that the community gets an opportunity to gently enforce code convention and prevent rapid build up of technical debt. Something else I've witnessed is that as the community grows, non-committers feel more comfortable submitting PRs because they've seen the same

Re: RTC/CTR Discussion

Late to the party, but I think starting with RTC, with a re-evaluation later (no more than a couple of months) makes the good sense. On Thu, Jul 21, 2016 at 2:00 PM, Ellison Anne Williams < eawilliamsp...@gmail.com> wrote: > The consensus seems to be that it wouldn't hurt to give RTC for Pirk a s

Jenkins build is back to normal : pirk #9

See

[GitHub] incubator-pirk pull request #17: [PIRK-16] Define XML schema definition file...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-pirk/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-pirk issue #17: [PIRK-16] Define XML schema definition files for P...

Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/17 +1 Looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-pirk pull request #14: [PIRK-12] Refactor EncryptQuery#encrypt(int...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-pirk/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-pirk issue #14: [PIRK-12] Refactor EncryptQuery#encrypt(int)

Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/14 +1 Very nice and clean. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

Re: RTC/CTR Discussion

The consensus seems to be that it wouldn't hurt to give RTC for Pirk a shot and modify as necessary. Thus, let's proceed with RTC with another committer reviewing the pull request before it's merged/accepted. On Wed, Jul 20, 2016 at 10:03 AM, Josh Elser wrote: > Tim Ellison wrote: > >> On 17/07/

PIRK Components on JIRA

Hi Guys, As a first step towards starting to organize our JIRA project, I took a stab at adding some components and adding component specifications to the open issues. This is just a first pass to get us started -- please feel free to add/delete/modify. Thanks! Ellison Anne

Re: Evolving the simple example

Hi Tim, More answers inline below. On Thu, Jul 21, 2016 at 10:47 AM, Tim Ellison wrote: > On 20/07/16 23:02, Ellison Anne Williams wrote: > > At the risk of making things too nested (and hence difficult to read), I > > will answer inline below. > > Inlining responses is the only sane way to go

Re: Build failed in Jenkins: pirk #8

I have seen this happen occasionally on other projects too, in large part its caused by multiple builds from different projects queued up on a server and forking multiple jvms to execute unit tests and integration tests and crashing. I bet it would work now if u trigger a manual build. For a proj

Re: Build failed in Jenkins: pirk #8

On 21/07/16 03:56, Apache Jenkins Server wrote: > See > > Changes: > > [eawilliams] [trivial] -- Enhancements to build XML and Paillier class - > closes > > [eawilliams] [none] -- Replace multi if-else with switch stmts - closes > > --

Re: Evolving the simple example

On 20/07/16 23:02, Ellison Anne Williams wrote: > At the risk of making things too nested (and hence difficult to read), I > will answer inline below. Inlining responses is the only sane way to go ;-) See below > On Tue, Jul 19, 2016 at 6:22 AM, Tim Ellison wrote: > >> I'm trying to write the

[GitHub] incubator-pirk issue #17: [PIRK-16] Define XML schema definition files for P...

Github user tellison commented on the issue: https://github.com/apache/incubator-pirk/pull/17 As well as supporting the original format, this PR allows for a more concise form, like this: ``` fakeDataSchema elementName1 string

[GitHub] incubator-pirk issue #17: [PIRK-16] Define XML schema definition files for P...

Github user tellison commented on the issue: https://github.com/apache/incubator-pirk/pull/17 Each element must occur once (i.e. minOccurs="1" maxOccurs="1") unless stated differently, so we just need to add a minOccurs="0" to isArray to make it optional, defaulting to true, so we can

Re: PIRK-7 -- JMH license issues

On 21/07/16 06:47, Suneel Marthi wrote: > JMH license is not compatible with Apache and hence this thread. > But if JMH is only being used for tests and if we don't package the tests > into project artifacts on Apache mirrors, I am thinking we shuld be fine to > leave JMH as is. It gets a bit tric

Re: incubator-pirk git commit: configuring google analytics

I agree. Thus far, I have set up the ApachePirk Twitter and ApachePirkWebsite Google Analytics accounts. I am happy to make those community creds for the PMC members. On Thu, Jul 21, 2016 at 6:46 AM, Tim Ellison wrote: > On 21/07/16 00:38, eawilli...@apache.org wrote: > > Repository: incubator

[GitHub] incubator-pirk issue #17: [PIRK-16] Define XML schema definition files for P...

Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/17 Designating the isArray default to 'false' makes sense. It seems that if we are going to have default values, we should be explicit and also specify 'required' on all attributes that are r

Re: incubator-pirk git commit: configuring google analytics

On 21/07/16 00:38, eawilli...@apache.org wrote: > Repository: incubator-pirk > Updated Branches: > refs/heads/gh-pages 22fa4e21f -> 838e508df > > > configuring google analytics > This raises the question about who should have access to the accounts held outside the ASF that are associated wit

[GitHub] incubator-pirk issue #15: Bring GoogleCaliperBenchmarks into master

Github user tellison commented on the issue: https://github.com/apache/incubator-pirk/pull/15 > I wouldn't accept this pull request just yet. Try it out Consider changing the title of the PR to start "[WIP]" to indicate it is a work in progress. Then you can change it to a J

[GitHub] incubator-pirk pull request #17: [PIRK-16] Define XML schema definition file...

GitHub user tellison opened a pull request: https://github.com/apache/incubator-pirk/pull/17 [PIRK-16] Define XML schema definition files for Pirk's data and query schemas Reading the loader code, the "isArray" element is not optional. Does it make sense and aid readability for me

[GitHub] incubator-pirk issue #9: [WIP] XML schema for Pirk's Data and Query Schemas

Github user tellison commented on the issue: https://github.com/apache/incubator-pirk/pull/9 Sorry Ellison Anne, I broke it. Let me close this and open a new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] incubator-pirk pull request #9: [WIP] XML schema for Pirk's Data and Query S...

Github user tellison closed the pull request at: https://github.com/apache/incubator-pirk/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature