Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/72
try triggering the build again by updating the PR with a random space, i am
seeing this happen today at random locally too.
---
If your project is set up for it, you can reply to this email a
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/71
+1 - working as expected
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/71
```
Levels used for identifying the severity of an event. Levels are organized
from most specific to least:
OFF (most specific, no logging)
FATAL (most specific, little dat
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/71
I guess then we are good with this PR, will let you merge after running
thru a few tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/71
I'll look - the way that I've always used log4j is that the log messages
from the selected level and up in the stack come through - so, for debug, info
would emit as well.
---
If your pr
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/72
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user ellisonanne opened a pull request:
https://github.com/apache/incubator-pirk/pull/72
[PIRK-39] - Removing MinimizeJar Config for Shade Plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ellisonanne/incubator-pirk p
GitHub user smarthi opened a pull request:
https://github.com/apache/incubator-pirk/pull/71
PIRK-54: Log Levels not Functioning
Not tested this PR thoroughly, in the Log file I do see both Info and Debug
showing up, seems like we may need to add a filter at appender level to filter
Thanks for the honor, glad to be part of this project.
On Thu, Aug 18, 2016 at 4:58 PM, Ellison Anne Williams <
eawilliamsp...@gmail.com> wrote:
> Hi,
>
> As per the vote on private, I would like to extend a welcome to our newest
> Pirk committers - Tim Ellison and Suneel Marthi.
>
> Thanks!
>
>
Hi,
As per the vote on private, I would like to extend a welcome to our newest
Pirk committers - Tim Ellison and Suneel Marthi.
Thanks!
Ellison Anne
The commit has been reverted, please get the latest from master.
On Thu, Aug 18, 2016 at 3:57 PM, Jacob Wilder <
jacobwilder.opensou...@gmail.com> wrote:
> Moving the benchmarks into the test tree broke all of the JMH benchmarks.
> We need to move them back into the main source tree. I don't see
Moving the benchmarks into the test tree broke all of the JMH benchmarks.
We need to move them back into the main source tree. I don't see a way to
make JMH happy with keeping the benchmarks in the test tree.
If the JMH benchmarks are in the test tree then (after the error-free and
successful comp
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/65
+1 to merge, given that most of the feedback has been addressed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/69
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/69
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/70
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
I guess we could resolve this JIRA as 'Will not Fix' .
On Thu, Aug 18, 2016 at 12:28 PM, Suneel Marthi
wrote:
> That's how we have it now. Let's keep that way then.
>
> On Thu, Aug 18, 2016 at 12:24 PM, Jacob Wilder <
> jacobwilder.opensou...@gmail.com> wrote:
>
>> Is there a concrete reason why
That's how we have it now. Let's keep that way then.
On Thu, Aug 18, 2016 at 12:24 PM, Jacob Wilder <
jacobwilder.opensou...@gmail.com> wrote:
> Is there a concrete reason why we can't use Jackson or Gson for
> serialization and JSON.simple for everything else? While it isn't the
> simplest appro
Is there a concrete reason why we can't use Jackson or Gson for
serialization and JSON.simple for everything else? While it isn't the
simplest approach philosophically or with regards to dependencies (mostly
licenses) it would be using the appropriate tool for each job.
—
Jacob WIlder
On Thu, Aug
GitHub user smarthi opened a pull request:
https://github.com/apache/incubator-pirk/pull/70
Revert "Move all tests under src/test directory, this closes
apache/incubator-pirk#66"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/s
No worries! :)
On Thu, Aug 18, 2016 at 12:16 PM, Suneel Marthi
wrote:
> Apologies for this.
> Reverting now.
>
> On Thu, Aug 18, 2016 at 12:12 PM, Ellison Anne Williams <
> eawilliamsp...@gmail.com> wrote:
>
> > Hi Guys,
> >
> > As a friendly public service announcement - please make sure that y
Apologies for this.
Reverting now.
On Thu, Aug 18, 2016 at 12:12 PM, Ellison Anne Williams <
eawilliamsp...@gmail.com> wrote:
> Hi Guys,
>
> As a friendly public service announcement - please make sure that you run
> the distributed test suite before you accept a PR (or at least, before
> accepti
Hi Guys,
As a friendly public service announcement - please make sure that you run
the distributed test suite before you accept a PR (or at least, before
accepting a PR that touches anything affecting the tests).
Thanks!
Ellison Anne
Hi Guys,
We need to roll back the commit for PR 66. The distributed tests must be
under src/main/java in order to be packaged into the executable jar and run
on a cluster.
Thanks -
Ellison Anne
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/69
@tellison could u review again? Updated the PR addressing ur previous
comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/66#discussion_r75328978
--- Diff: pom.xml ---
@@ -451,7 +451,7 @@
3.0.1
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/66#discussion_r75328858
--- Diff: pom.xml ---
@@ -464,7 +464,7 @@
3.0.1
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/66
Merging this now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/69#discussion_r75327898
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/spark/ComputeResponse.java ---
@@ -316,23 +311,15 @@ public void performQuery() throws Exce
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/69#discussion_r75324999
--- Diff: src/main/java/org/apache/pirk/schema/query/QuerySchemaLoader.java
---
@@ -296,7 +296,7 @@ private Document parseXMLDocument(InputStream stre
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/69#discussion_r75324702
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/spark/ComputeResponse.java ---
@@ -316,23 +311,15 @@ public void performQuery() throws Exc
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/66
+1 lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/68
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/68
merging this now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
GitHub user smarthi opened a pull request:
https://github.com/apache/incubator-pirk/pull/69
Removed unused variables, general code clean up
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/incubator-pirk sundry
Alternativ
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/68
+1 lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/68
Convert DecryptResponseRunnable to a Callable.
- Allows task to return a value and throw checked exceptions.
- Further tidy-up in decrypt response.
Passing results between th
Github user ellisonanne commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/65#discussion_r75311878
--- Diff: src/main/resources/META-INF/bin-license-notice/NOTICE-bin ---
@@ -0,0 +1,278 @@
+Apache Pirk (incubating)
+Copyright 2016 The Apac
Github user ellisonanne commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/65#discussion_r75311950
--- Diff: pom.xml ---
@@ -350,6 +350,9 @@
docs/*
So, here is what I ended up doing:
1.) Changing the root LICENSE and NOTICE files to be the source-only Pirk
L&N files
2.) Creating a src/main/resource/META-INF/bin-license-notice directory
containing the L&N files corresponding to the binary distribution of Pirk
-- LICENSE-bin and NOTICE-bin
3.
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/65#discussion_r75311521
--- Diff: src/main/resources/META-INF/bin-license-notice/NOTICE-bin ---
@@ -0,0 +1,278 @@
+Apache Pirk (incubating)
+Copyright 2016 The Apache S
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/65#discussion_r75311256
--- Diff: pom.xml ---
@@ -350,6 +350,9 @@
docs/*
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/67
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/67
+1 will merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/67
[trivial] Remove unusued var and tidy-up.
- Remove unused qSchema from DecryptResponseRunnable.
- Tidy-up local declarations, marking fields as final.
- Introduce try-with-resource
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/66
[PIRK-55] Move all tests under src/test directory
- Moves test files under src/test.
- Rename packages to ensure consistency with org.apache.pirk.test.
- Update pom exclusion filte
On 17/08/16 19:59, Ellison Anne Williams wrote:
> Thanks guys.
>
> I will make another set of L&N files (other than what's in the root of PR
> 53) for the source-only release artifacts and figure out where to place
> them based on the previous comments. I will add them to PR 53, so let's not
> mer
On 17/08/16 19:04, Ellison Anne Williams wrote:
> From the discussion, although this seems to be somewhat murky ASF ground,
> it seems that we need two sets of L&N files:
>
> 1.) L&N files to accompany executable jars, which include the transitive
> L&N requirements dictated by the build (this is
50 matches
Mail list logo
