Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/100
The reason that this constructor was marked as "Only used, at this point,
for testing purposes" was as an intermediate safeguard to user error. However,
it is desirable, under certain
Github user DarinJ commented on the issue:
https://github.com/apache/incubator-pirk/pull/100
Hadoop uses guava's VisibleForTesting annotations I've used a little and it
pretty simple. Could put a unit test together sometime this weekend if
interested.
---
If your project is set up
Github user DarinJ commented on the issue:
https://github.com/apache/incubator-pirk/pull/99
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/100
[WIP] Create Paillier bridge to hide test constructor
For discussion:
Paillier currently exposes a public constructor that is only for testing.
This is one way to make it default
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/99
+1 Lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/93
I've merged the PR Darin. That's not to say that the debate is over, but
this does move us forward and we can use new PRs to address ongoing
improvements.
---
If your project is set up
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/93
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
