Re: [Discuss] Submodules (Phase 2) observations

Hi Darin, A complete refactor of the tests would probably be ideal - however, it doesn't seem to make sense to tackle that as a part of the initial submodule refactor. Perhaps leaving the Responder refactor (and test refactor) to a subsequent PR makes more sense. Absent a complete test refactor,

[GitHub] incubator-pirk pull request #111: [PIRK-74] Close Hash Key information leak

Github user asfgit closed the pull request at: https://github.com/apache/incubator-pirk/pull/111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [Discuss] Submodules (Phase 2) observations

Ellison Anne, I'm not sure that's the ideal long term solution but could provide a way forward. Though I'm not sure I'd want to use maven-jar plugin vs just reuse the files. I view both as bad practice, but the later would allow us to refactor the tests and the the DistributedTestSuite independe

[GitHub] incubator-pirk issue #112: [PIRK-78] Create a QuerySchema builder for assemb...

Github user tellison commented on the issue: https://github.com/apache/incubator-pirk/pull/112 The local tests, and my travis-ci instance passes the tests ok. I see the failure is caused by a Maven PluginExecutionException. I will push new changes to force a re-test. --- If

[GitHub] incubator-pirk pull request #113: [PIRK-80] Upgrade to Spark 2.0.0

Github user asfgit closed the pull request at: https://github.com/apache/incubator-pirk/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-pirk pull request #111: [WIP] [PIRK-74] Close Hash Key information...

Github user jacobwil commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/111#discussion_r85347377 --- Diff: src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java --- @@ -156,10 +149,23 @@ public Querier encrypt(int numThreads)

[GitHub] incubator-pirk pull request #111: [WIP] [PIRK-74] Close Hash Key information...

Github user jacobwil commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/111#discussion_r85344830 --- Diff: src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java --- @@ -156,10 +149,23 @@ public Querier encrypt(int numThreads)

[GitHub] incubator-pirk issue #113: [PIRK-80] Upgrade to Spark 2.0.0

Github user tellison commented on the issue: https://github.com/apache/incubator-pirk/pull/113 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-pirk pull request #113: [PIRK-80] Upgrade to Spark 2.0.0

GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/113 [PIRK-80] Upgrade to Spark 2.0.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ellisonanne/incubator-pirk update_spark Alternativ

[GitHub] incubator-pirk pull request #111: [WIP] [PIRK-74] Close Hash Key information...

Github user tellison commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/111#discussion_r85321593 --- Diff: src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java --- @@ -156,10 +149,23 @@ public Querier encrypt(int numThreads)

[GitHub] incubator-pirk pull request #111: [WIP] [PIRK-74] Close Hash Key information...

Github user tellison commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/111#discussion_r85321545 --- Diff: src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java --- @@ -156,10 +149,23 @@ public Querier encrypt(int numThreads)