[GitHub] incubator-pirk pull request #64: Enhancements to partitioners, keyedHash, an...

2016-08-16 Thread smarthi
Github user smarthi commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/64#discussion_r74921656 --- Diff: src/main/java/org/apache/pirk/schema/data/partitioner/PrimitiveTypePartitioner.java --- @@ -48,8 +48,7 @@ public static final String

[GitHub] incubator-pirk pull request #64: Enhancements to partitioners, keyedHash, an...

2016-08-16 Thread tellison
Github user tellison commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/64#discussion_r74917728 --- Diff: src/main/java/org/apache/pirk/schema/data/partitioner/PrimitiveTypePartitioner.java --- @@ -48,8 +48,7 @@ public static final

[GitHub] incubator-pirk pull request #64: Enhancements to partitioners, keyedHash, an...

2016-08-16 Thread tellison
Github user tellison commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/64#discussion_r74917596 --- Diff: src/main/java/org/apache/pirk/schema/data/partitioner/PrimitiveTypePartitioner.java --- @@ -90,12 +89,20 @@ } /**

[GitHub] incubator-pirk pull request #64: Enhancements to partitioners, keyedHash, an...

2016-08-16 Thread tellison
GitHub user tellison opened a pull request: https://github.com/apache/incubator-pirk/pull/64 Enhancements to partitioners, keyedHash, and prime generator. - Convert last few remaining ArrayList return types on partitioners to List interface, and deal with the flow through to