[GitHub] incubator-pirk pull request #26: [PIRK-19] Make DataSchema/QuerySchema Agnos...

2016-07-26 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/26#discussion_r72371135 --- Diff: src/main/java/org/apache/pirk/schema/query/QuerySchemaLoader.java --- @@ -246,8 +231,11 @@ private static QuerySchema

[GitHub] incubator-pirk issue #17: [PIRK-16] Define XML schema definition files for P...

2016-07-21 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/17 +1 Looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-pirk issue #27: [WIP] Pirk 27 - Improve Pirk's Use of Property Fil...

2016-07-28 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/27 I also still need to make this branch up-to-date with master (and all of the query and data schema refactoring) before pulling the WIP off. I will remove the scripts in the bin folder too

[GitHub] incubator-pirk pull request #27: [WIP] Pirk 27 - Improve Pirk's Use of Prope...

2016-07-28 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/27#discussion_r72594517 --- Diff: pom.xml --- @@ -117,6 +117,7 @@ 3.3 +

[GitHub] incubator-pirk pull request #27: [WIP] Pirk 27 - Improve Pirk's Use of Prope...

2016-07-28 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/27#discussion_r72594248 --- Diff: src/main/java/org/apache/pirk/utils/SystemConfiguration.java --- @@ -152,6 +105,31 @@ public static void setProperty(String propertyName

[GitHub] incubator-pirk pull request #27: [WIP] Pirk 27 - Improve Pirk's Use of Prope...

2016-07-28 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/27#discussion_r72594185 --- Diff: src/main/java/org/apache/pirk/utils/SystemConfiguration.java --- @@ -24,8 +24,6 @@ import java.io.InputStream; import

[GitHub] incubator-pirk pull request #27: [WIP] Pirk 27 - Improve Pirk's Use of Prope...

2016-07-28 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/27#discussion_r72594279 --- Diff: src/main/java/org/apache/pirk/utils/SystemConfiguration.java --- @@ -160,4 +138,74 @@ public static void resetProperties

[GitHub] incubator-pirk issue #23: Pirk 17 - Add Ability to Embed QuerySchema in Quer...

2016-07-23 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/23 Much better now - only 35 files changed :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-pirk issue #18: [WIP] Serialization and storage changes to Querier...

2016-07-23 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/18 `fs` is defined in setup of `ExpTableMapper`: ``` public void setup(Context ctx) throws IOException, InterruptedException { super.setup(ctx

[GitHub] incubator-pirk issue #23: Pirk 17 - Add Ability to Embed QuerySchema in Quer...

2016-07-23 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/23 It looks like there is some git weirdness here in that all diffs from the past few commits are showing up in the 'Files Changed' -- probably has something to do with the fact that I

[GitHub] incubator-pirk issue #23: Pirk 17 - Add Ability to Embed QuerySchema in Quer...

2016-07-23 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/23 What does igtm stand for? A quick google search yielded: IGTMImage Guided Treatment Management IGTMInternational Golf Travel Market Assuming that's

[GitHub] incubator-pirk issue #18: [PIRK-25] Serialization and storage changes to Que...

2016-07-23 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/18 Correct - I was looking at the old code +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-pirk issue #23: [PIRK-17] - Add Ability to Embed QuerySchema in Qu...

2016-07-24 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/23 It was my understanding the members of the PMC (you, Suneel, etc) are also committers and able to perform a review in a RTC scenario. Suneel commented " LGTM +1. Ship it!&qu

[GitHub] incubator-pirk issue #25: [PIRK-25] Additional comments and tidy-up.

2016-07-24 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/25 +1 I will also update the javadocs and push to the website as these commits include javadoc mods --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-pirk issue #19: PIRK-10: Upgrade and Enforce Java 8

2016-07-22 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/19 +1 Thanks adding back in the rat check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-pirk issue #24: PIRK-26: Make Enum MRStats a top level class

2016-07-24 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/24 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-pirk issue #27: [Pirk 27] - Improve Pirk's Use of Property Files

2016-07-28 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/27 Did some cleaning as per Tim's comments... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-pirk pull request #27: [Pirk 27] - Improve Pirk's Use of Property ...

2016-07-28 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/27#discussion_r72716104 --- Diff: src/main/resources/querier.properties --- @@ -0,0 +1,123

[GitHub] incubator-pirk issue #29: Add a no-arguments version of EncryptQuery#encrypt...

2016-07-28 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/29 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-pirk pull request #27: [Pirk 27] - Improve Pirk's Use of Property ...

2016-07-28 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/27#discussion_r72732010 --- Diff: src/main/java/org/apache/pirk/responder/wideskies/spark/ComputeResponse.java --- @@ -202,7 +203,7 @@ private void setup() throws

[GitHub] incubator-pirk issue #30: Ensure stop list property is set for tests.

2016-07-29 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/30 +1 Yes, this property was changed in the last commit. It was building and running just fine for me locally and on the cluster (distributed tests), passed Travis, but Jenkins had

[GitHub] incubator-pirk pull request #32: Adding Trust Model FAQ for Website

2016-07-29 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/32 Adding Trust Model FAQ for Website You can merge this pull request into a Git repository by running: $ git pull https://github.com/ellisonanne/incubator-pirk gh-pages

[GitHub] incubator-pirk issue #32: Adding Trust Model FAQ for Website

2016-07-29 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/32 The material files that were changed are: faq.md website_updates.md (fixed typo) for_developers.md (fixed type) --- If your project is set up for it, you can reply

[GitHub] incubator-pirk issue #33: [PIRK-28] [WIP]: Logger Statements Not Working in/...

2016-07-29 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/33 Does not appear to be working --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-pirk issue #31: [PIRK-32]: Create KEYS file with public keys of Re...

2016-07-29 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/31 +1 Thanks Suneel! I will merge and update with my key in the process. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-pirk issue #34: [PIRK-33] : Create release profiles to facilitate ...

2016-07-30 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/34 OK - will merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-pirk pull request #41: Pirk 39 - Add Maven Shade Plugin Configurat...

2016-08-01 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/41 Pirk 39 - Add Maven Shade Plugin Configurations to Minimize the JAR You can merge this pull request into a Git repository by running: $ git pull https://github.com/ellisonanne

[GitHub] incubator-pirk issue #26: [PIRK-19] Make DataSchema/QuerySchema Agnostic of ...

2016-07-26 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/26 I think that the javadocs should accurately reflect what's in master, even of other changes are coming. And, they are easy to generate and push... --- If your project is set up

[GitHub] incubator-pirk issue #26: [PIRK-19] Make DataSchema/QuerySchema Agnostic of ...

2016-07-26 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/26 Merging now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-pirk issue #34: [PIRK-33] : Create release profiles to facilitate ...

2016-07-30 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/34 +1 There is one typo in the scm section that we need to change to remove 'nifi' and change to the correct pirk repo: ` scm:git:git://git.apache.org

[GitHub] incubator-pirk issue #36: Trivial fix to remove github footer from pom.xml

2016-07-31 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/36 Sounds good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-pirk issue #38: [PIRK-36]: Ensure Schema Properties and Registries...

2016-07-31 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/38 Done - pls review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-pirk pull request #38: [PIRK-36]: Ensure Schema Properties and Reg...

2016-07-31 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/38#discussion_r72909520 --- Diff: src/test/java/test/wideskies/standalone/StandaloneTest.java --- @@ -45,10 +49,17 @@ private static final String

[GitHub] incubator-pirk pull request #38: [PIRK-36]: Ensure Schema Properties and Reg...

2016-07-31 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/38#discussion_r72909521 --- Diff: src/test/java/test/general/PartitionUtilsTest.java --- @@ -39,7 +40,8 @@ { private static final Logger logger

[GitHub] incubator-pirk issue #38: [PIRK-36]: Ensure Schema Properties and Registries...

2016-07-31 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/38 Good catch Suneel! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-pirk issue #37: [PIRK-35]: Execute tests in Parallel

2016-07-31 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/37 +1 For cleanliness, we should also make sure that the schema properties are reset and the schema registries are reset at the beginning of all tests that access/utilize schemas

[GitHub] incubator-pirk issue #37: [PIRK-35]: Execute tests in Parallel

2016-07-31 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/37 Will do --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-pirk issue #28: [PIRK-19] Further restructuring in schema loading.

2016-07-27 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/28 Are you ready for this to be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-pirk issue #28: [PIRK-19] Further restructuring in schema loading.

2016-07-27 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/28 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-pirk issue #51: Introduced typed property getters to SytemConfigur...

2016-08-10 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/51 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-pirk pull request #44: [PIRK-42]: Fix DataSchema getTextName NullP...

2016-08-02 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/44 [PIRK-42]: Fix DataSchema getTextName NullPointerException You can merge this pull request into a Git repository by running: $ git pull https://github.com/ellisonanne/incubator

[GitHub] incubator-pirk issue #43: PIRK-29

2016-08-11 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/43 ...Should also add that we can add in the line to perform the query ID check in the Querier (as in the corresponding JIRA issue) to a new PR. --- If your project is set up for it, you

[GitHub] incubator-pirk pull request #60: [PIRK-50] -- Update POM for Release

2016-08-12 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/60 [PIRK-50] -- Update POM for Release Added the profile information for apache-release so that mvn release would function. It appears that we need to include an additional repo

[GitHub] incubator-pirk issue #57: [PIRK-49] PrimitivePartioner does not account for ...

2016-08-12 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/57 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-pirk issue #16: Replace multi if-else with switch stmts

2016-07-20 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/16 +1 Looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-pirk pull request #50: [PIRK-44]: Tachyon FS Error

2016-08-08 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/50 [PIRK-44]: Tachyon FS Error Added a filter for org.tachyonproject to the shade plugin configuration to fix the issue. You can merge this pull request into a Git repository by running

[GitHub] incubator-pirk pull request #43: PIRK-29

2016-08-02 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/43#discussion_r73229816 --- Diff: src/main/java/org/apache/pirk/querier/wideskies/QuerierDriver.java --- @@ -91,7 +91,7 @@ public static void main(String... args) throws

[GitHub] incubator-pirk issue #27: [Pirk 27] - Improve Pirk's Use of Property Files

2016-07-28 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/27 This is ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-pirk issue #65: [PIRK-53] - Fix LICENSE and NOTICE Files for Relea...

2016-08-16 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/65 If you run `mvn license:add-third-party` you will see the dependencies above - if it appeared in the output, I accounted for it in the files... --- If your project is set up for it, you

[GitHub] incubator-pirk pull request #65: [PIRK-53] - Fix LICENSE and NOTICE Files fo...

2016-08-17 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/65#discussion_r75099716 --- Diff: LICENSE --- @@ -199,4 +199,64 @@ distributed under the License is distributed on an "AS IS" BASIS, WITHOUT

[GitHub] incubator-pirk pull request #65: [PIRK-53] - Fix LICENSE and NOTICE Files fo...

2016-08-17 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/65#discussion_r75099656 --- Diff: LICENSE --- @@ -199,4 +199,64 @@ distributed under the License is distributed on an "AS IS" BASIS, WITHOUT

[GitHub] incubator-pirk pull request #65: [PIRK-53] - Fix LICENSE and NOTICE Files fo...

2016-08-17 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/65#discussion_r75099886 --- Diff: LICENSE --- @@ -199,4 +199,64 @@ distributed under the License is distributed on an "AS IS" BASIS, WITHOUT

[GitHub] incubator-pirk issue #71: PIRK-54: Log Levels not Functioning

2016-08-18 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/71 +1 - working as expected --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-pirk issue #71: PIRK-54: Log Levels not Functioning

2016-08-18 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/71 I'll look - the way that I've always used log4j is that the log messages from the selected level and up in the stack come through - so, for debug, info would emit as well. --- If your

[GitHub] incubator-pirk pull request #72: [PIRK-39] - Removing MinimizeJar Config for...

2016-08-18 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/72 [PIRK-39] - Removing MinimizeJar Config for Shade Plugin You can merge this pull request into a Git repository by running: $ git pull https://github.com/ellisonanne/incubator-pirk

[GitHub] incubator-pirk pull request #73: various minor cleanup items

2016-08-19 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/73 various minor cleanup items You can merge this pull request into a Git repository by running: $ git pull https://github.com/ellisonanne/incubator-pirk cleanup Alternatively you

[GitHub] incubator-pirk issue #73: various minor cleanup items

2016-08-19 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/73 Yes, I ran 'organize imports' in Eclipse --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-pirk pull request #65: [PIRK-53] - Fix LICENSE and NOTICE Files fo...

2016-08-16 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/65 [PIRK-53] - Fix LICENSE and NOTICE Files for Release Compliance You can merge this pull request into a Git repository by running: $ git pull https://github.com/ellisonanne

[GitHub] incubator-pirk issue #69: Removed unused variables, general code clean up

2016-08-18 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/69 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-pirk issue #84: Fix deprecated Api calls and other minor fixes.

2016-09-02 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/84 Looks good on initial review - I will run it through the distributed test suite and report back --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-pirk issue #84: Fix deprecated Api calls and other minor fixes.

2016-09-02 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/84 Discovered a bug that was recently introduced in the code (PIRK-61) while testing this PR - am fixing and will push a PR in a few - with the changes that will be in the PIRK-61 PR

[GitHub] incubator-pirk pull request #85: [PIRK-61] - Es-Nodes Option Not Parsed by R...

2016-09-02 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/85 [PIRK-61] - Es-Nodes Option Not Parsed by ResponderCLI You can merge this pull request into a Git repository by running: $ git pull https://github.com/ellisonanne/incubator-pirk

[GitHub] incubator-pirk pull request #:

2016-09-08 Thread ellisonanne
Github user ellisonanne commented on the pull request: https://github.com/apache/incubator-pirk/commit/c7fc6ec8719e7b1df5ff3f3baa8bab17643a8454#commitcomment-18944104 Sure - seems like that would be fine --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-pirk issue #83: Pass query elements into Query constructor.

2016-08-30 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/83 +1 - will merge now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-pirk pull request #88: [wip] Jnagmp for modular multiply, gcd, and...

2016-09-11 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/88#discussion_r78297559 --- Diff: pom.xml --- @@ -95,6 +95,18 @@ 1C true --- End diff -- I'm fine with this for now

[GitHub] incubator-pirk issue #100: [WIP] Create Paillier bridge to hide test constru...

2016-09-23 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/100 The reason that this constructor was marked as "Only used, at this point, for testing purposes" was as an intermediate safeguard to user error. However, it is desirable, und

[GitHub] incubator-pirk pull request #106: [PIRK-73] - Change All Properties in Respo...

2016-10-06 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/106 [PIRK-73] - Change All Properties in ResponderProps to be public You can merge this pull request into a Git repository by running: $ git pull https://github.com/ellisonanne

[GitHub] incubator-pirk pull request #107: [WIP] PIRK-45 Remove dependency on Java se...

2016-10-08 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/107#discussion_r82505758 --- Diff: src/main/java/org/apache/pirk/query/wideskies/Query.java --- @@ -26,100 +26,103 @@ import java.util.concurrent.ConcurrentHashMap

[GitHub] incubator-pirk issue #107: [WIP] PIRK-45 Remove dependency on Java serializa...

2016-10-08 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/107 A couple of general comments - (1) need to remove the Jackson imports and dependency as it GSON is being used (2) need to format with the Pirk codestyle file. I'll take a look

[GitHub] incubator-pirk issue #107: PIRK-45 Remove dependency on Java serialization

2016-10-10 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/107 +1 - looks good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-pirk issue #93: WIP-Pirk 63-DO NOT MERGE

2016-09-19 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/93 A few other comments for discussion: First, I am not opposed to having separate ResponderDrivers for each responder, but let's think it through and see if we really need to go

[GitHub] incubator-pirk issue #94: Update a number of Pirk's pom dependencies.

2016-09-19 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/94 +1 will merge now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-pirk issue #98: [minor] Fix license and term in math_deck

2016-09-21 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/98 +1 - I just need to make sure that the tex builds correctly with the license added - will do this when I merge (fixing any issues) --- If your project is set up for it, you can reply

[GitHub] incubator-pirk issue #93: WIP-Pirk 63-DO NOT MERGE

2016-09-19 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/93 +1 - looks good so far. One item for consideration: I am in favor of *not* providing backwards compatibility with the 'platform' option at this point, i.e. removing

[GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

2016-09-22 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/93#discussion_r80005357 --- Diff: src/main/resources/META-INF/services/org.apache.pirk.responder.wideskies.spi.ResponderPlugin --- @@ -0,0 +1,5

[GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

2016-09-22 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/93#discussion_r80003616 --- Diff: src/main/java/org/apache/pirk/responder/wideskies/spi/ResponderPlugin.java --- @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache

[GitHub] incubator-pirk issue #91: [Pirk-66] - Fix Website To Indicate Pirk's Use of ...

2016-09-17 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/91 +1 merging now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-pirk issue #92: [Pirk 67] - Add Slide Deck to the Website Document...

2016-09-17 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/92 +1 merging now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-pirk pull request #65: [PIRK-53] [WIP] - Fix LICENSE and NOTICE Fi...

2016-08-18 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/65#discussion_r75311878 --- Diff: src/main/resources/META-INF/bin-license-notice/NOTICE-bin --- @@ -0,0 +1,278 @@ +Apache Pirk (incubating) +Copyright 2016

[GitHub] incubator-pirk issue #81: Enhancements to Wideskies encrypt/decrypt.

2016-08-27 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/81 +1 very nice - I made a few nitty comments about javadocs... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-pirk pull request #81: Enhancements to Wideskies encrypt/decrypt.

2016-08-27 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/81#discussion_r76517343 --- Diff: src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java --- @@ -163,8 +144,8 @@ public void encrypt(int numThreads

[GitHub] incubator-pirk pull request #81: Enhancements to Wideskies encrypt/decrypt.

2016-08-27 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/81#discussion_r76517300 --- Diff: src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java --- @@ -56,103 +56,84 @@ { private static final

[GitHub] incubator-pirk issue #76: [PIRK-21] - Initial Spark Streaming Responder Impl...

2016-08-27 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/76 Merging now - will keep working on it via JIRA issues and PRs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-pirk pull request #81: Enhancements to Wideskies encrypt/decrypt.

2016-08-27 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/81#discussion_r76517354 --- Diff: src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java --- @@ -200,31 +181,29 @@ public void encrypt(int numThreads

[GitHub] incubator-pirk issue #82: [PIRK-58] - Improve Paillier Test Speed

2016-08-27 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/82 This is a non-material change that yields increased test speed for Paillier - in practice, we would never use a modulus up to 7000 bits --- If your project is set up for it, you can

[GitHub] incubator-pirk issue #82: [PIRK-58] - Improve Paillier Test Speed

2016-08-27 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/82 lol - will merge now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-pirk pull request #82: [PIRK-58] - Improve Paillier Test Speed

2016-08-27 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/82 [PIRK-58] - Improve Paillier Test Speed (note that I accidentally named the branch pirk-59 instead of pirk-58) You can merge this pull request into a Git repository by running

[GitHub] incubator-pirk issue #76: [PIRK-21] - Initial Spark Streaming Responder Impl...

2016-08-26 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/76 Scale testing is in progress - I would like to go ahead and merge this into master before it gets too far behind... I will update as necessary with any changes that result from scale

[GitHub] incubator-pirk pull request #78: [PIRK-56] -- Change DistributedTestSuite to...

2016-08-23 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/78 [PIRK-56] -- Change DistributedTestSuite to Run ES Tests Using Local Properties File You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-pirk pull request #75: Enhancements to parallelism of query encryp...

2016-08-23 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/75#discussion_r75882219 --- Diff: src/main/java/org/apache/pirk/query/wideskies/Query.java --- @@ -136,89 +124,30 @@ public boolean containsElement(BigInteger element

[GitHub] incubator-pirk issue #75: Enhancements to parallelism of query encryption.

2016-08-23 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/75 +1 - nice streamlining I will run the distributed tests before merging - if merged and the PR closed, please assume that the tests passed. If not, I will report back accordingly

[GitHub] incubator-pirk issue #77: [Bug fix] Reset loop index correctly on hash colli...

2016-08-23 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/77 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-pirk pull request #76: [PIRK-21] [WIP] - Initial Spark Streaming R...

2016-08-23 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/76#discussion_r75877912 --- Diff: src/main/resources/pirk.properties --- @@ -28,7 +28,8 @@ local.pirk.properties.dir=/root/ ## ##Spark path for SparkLauncher

[GitHub] incubator-pirk pull request #76: [PIRK-21] [WIP] - Initial Spark Streaming R...

2016-08-23 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/76#discussion_r75878104 --- Diff: src/main/java/org/apache/pirk/responder/wideskies/spark/streaming/ComputeStreamingResponse.java --- @@ -0,0 +1,467

[GitHub] incubator-pirk pull request #76: [PIRK-21] [WIP] - Initial Spark Streaming R...

2016-08-22 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/76 [PIRK-21] [WIP] - Initial Spark Streaming Responder Implementation The initial Spark Streaming Responder implementation, including corresponding distributed tests. Initial input adaptors

[GitHub] incubator-pirk issue #79: Removed the and

2016-08-25 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/79 Why are we making this change? It seems to be reasonable to keep the deploy location as our Nexus staging repo and then to move the artifacts over to the dist repo once everything passes

[GitHub] incubator-pirk pull request #102: [Minor] Enhancements to Paillier class.

2016-09-27 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/102#discussion_r80806938 --- Diff: src/main/java/org/apache/pirk/encryption/Paillier.java --- @@ -95,140 +95,185 @@ } } - private BigInteger p

[GitHub] incubator-pirk pull request #102: [Minor] Enhancements to Paillier class.

2016-09-27 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/102#discussion_r80808304 --- Diff: src/main/java/org/apache/pirk/encryption/Paillier.java --- @@ -95,140 +95,185 @@ } } - private BigInteger p

[GitHub] incubator-pirk pull request #102: [Minor] Enhancements to Paillier class.

2016-09-27 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/102#discussion_r80806778 --- Diff: src/main/java/org/apache/pirk/encryption/Paillier.java --- @@ -95,140 +95,185 @@ } } - private BigInteger p

[GitHub] incubator-pirk issue #104: [Pirk-65] Debug Logging Not Working within Distri...

2016-09-27 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/104 Can't seem to get the debug to work even in the local tests (?) Didn't try to troubleshoot more than a couple of minutes. What log settings are you using to test the debug

  1   2   >