Re: API Changes proposal

2018-09-05 Thread Christofer Dutz
Hi all, just wanted to give you an update on my progress. I started with updating the examples and integrations and quickly came to a point, where I had to continue finishing the API refactoring and the base-driver refactoring. So I just committed my last changes that should make it possible

[GitHub] chrisdutz commented on a change in pull request #14: WIP: Api Refactoring

2018-09-05 Thread GitBox
chrisdutz commented on a change in pull request #14: WIP: Api Refactoring URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r215170934 ## File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcFieldRequest.java ## @@ -20,11 +20,13 @@

[GitHub] sruehl commented on a change in pull request #14: WIP: Api Refactoring

2018-09-05 Thread GitBox
sruehl commented on a change in pull request #14: WIP: Api Refactoring URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r214037249 ## File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcWriteRequest.java ## @@ -24,6 +24,8 @@ Licensed