Re: OPM / Connection Pool

Guess a "ping" would really be a good thing. And I think the should be options for all PLCs ... We just have to implement them. More details response, web I'm at work. But thanks for your hard work on this (you, meant in a plural sense) Chris Outlook for Android

OPM / Connection Pool

Hey all, just wanted to keep you up to date with some things Sebastian and I discussed off-list. Thanks to Sebastians support the Object Plc Mapping (opm) is now mergend into master and I would love to get some feedback. I hope that I can soon add some documentation on the side about that and I

[GitHub] JulianFeinauer commented on issue #29: Opm plcentitymanager

JulianFeinauer commented on issue #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#issuecomment-433170393 Thank you @sruehl for the comments. I answered your comments although it is already merged. I would love to test this feature (together with your

[GitHub] JulianFeinauer commented on a change in pull request #29: Opm plcentitymanager

JulianFeinauer commented on a change in pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228299120 ## File path: plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java ## @@ -0,0 +1,380 @@ +/*

[GitHub] JulianFeinauer commented on a change in pull request #29: Opm plcentitymanager

JulianFeinauer commented on a change in pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228298703 ## File path: plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java ## @@ -0,0 +1,380 @@ +/*

[GitHub] JulianFeinauer commented on a change in pull request #29: Opm plcentitymanager

JulianFeinauer commented on a change in pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228297629 ## File path: plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java ## @@ -0,0 +1,380 @@ +/*

[GitHub] JulianFeinauer commented on a change in pull request #29: Opm plcentitymanager

JulianFeinauer commented on a change in pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228297058 ## File path: plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java ## @@ -0,0 +1,380 @@ +/*

[GitHub] JulianFeinauer commented on a change in pull request #29: Opm plcentitymanager

JulianFeinauer commented on a change in pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228296550 ## File path: plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java ## @@ -0,0 +1,380 @@ +/*

[GitHub] sruehl commented on issue #26: connection manager for connection pool initial version

sruehl commented on issue #26: connection manager for connection pool initial version URL: https://github.com/apache/incubator-plc4x/pull/26#issuecomment-433109321 super seeded by commons-pool This is an automated message

[GitHub] sruehl closed pull request #26: connection manager for connection pool initial version

sruehl closed pull request #26: connection manager for connection pool initial version URL: https://github.com/apache/incubator-plc4x/pull/26 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] asfgit closed pull request #29: Opm plcentitymanager

asfgit closed pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] sruehl commented on issue #29: Opm plcentitymanager

sruehl commented on issue #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#issuecomment-433106003 looks good to me :) This is an automated message from the Apache Git Service. To respond to the

[GitHub] sruehl commented on a change in pull request #29: Opm plcentitymanager

sruehl commented on a change in pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228232133 ## File path: plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java ## @@ -0,0 +1,380 @@ +/* +

[GitHub] sruehl commented on a change in pull request #29: Opm plcentitymanager

sruehl commented on a change in pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228230429 ## File path: plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java ## @@ -0,0 +1,380 @@ +/* +

[GitHub] sruehl commented on a change in pull request #29: Opm plcentitymanager

sruehl commented on a change in pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228231315 ## File path: plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java ## @@ -0,0 +1,380 @@ +/* +

[GitHub] sruehl commented on a change in pull request #29: Opm plcentitymanager

sruehl commented on a change in pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228230930 ## File path: plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java ## @@ -0,0 +1,380 @@ +/* +

[GitHub] sruehl commented on a change in pull request #29: Opm plcentitymanager

sruehl commented on a change in pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228230727 ## File path: plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java ## @@ -0,0 +1,380 @@ +/* +

[GitHub] sruehl commented on a change in pull request #29: Opm plcentitymanager

sruehl commented on a change in pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228230145 ## File path: plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntity.java ## @@ -0,0 +1,34 @@ +/* + Licensed to

[GitHub] sruehl commented on a change in pull request #29: Opm plcentitymanager

sruehl commented on a change in pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228231695 ## File path: plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java ## @@ -0,0 +1,380 @@ +/* +

[GitHub] sruehl commented on a change in pull request #29: Opm plcentitymanager

sruehl commented on a change in pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228230640 ## File path: plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java ## @@ -0,0 +1,380 @@ +/* +

[GitHub] sruehl commented on a change in pull request #29: Opm plcentitymanager

sruehl commented on a change in pull request #29: Opm plcentitymanager URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228231802 ## File path: plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java ## @@ -0,0 +1,380 @@ +/* +

AW: Worrying JUnit5 results

Hey Chris, I'm no Jenkins and no groovy expert, but shouldn't this be doable in the Jenkinsfile... there should be some way to get the number of executed tests from the context and simply fail the build (or set it to yellow) if number of tests is lower than last run (should be doable via

Re: Worrying JUnit5 results

Ok, so I went through the builds, searching for the one, where the number of tests dropped. Turned out to be the one I added the groovy support. Did a while of searching for a solution and it seems that following the tutorials and importing "groovy-all" imported an insane number of