[GitHub] sruehl commented on issue #37: Extend test driver with mock

sruehl commented on issue #37: Extend test driver with mock URL: https://github.com/apache/incubator-plc4x/pull/37#issuecomment-435118195 @JulianFeinauer im confused as well. Is the test-protocol meant to be used from users of plc4x or within unit-tests in implementations using plc4x

Re: [GitHub] JulianFeinauer opened a new pull request #36: Add simple mock driver

Hi Chris, sorry, I saw this too late. I agree with your idea. And I think these Both would be good additions. I already openend a PR for a "in-between" solution which allows to inject a Mock Object where requests for Type "MOCK/..." are forwarded to. This allows the Full power of frameworks like

[GitHub] JulianFeinauer opened a new pull request #37: Extend test driver with mock

JulianFeinauer opened a new pull request #37: Extend test driver with mock URL: https://github.com/apache/incubator-plc4x/pull/37 @chrisdutz here is my approach as extension to the Test Driver. @sruehl It is still not in the Test-utils package but I'm unsure if it should as I'm unsure

Re: [GitHub] JulianFeinauer opened a new pull request #36: Add simple mock driver

Hi Julian, Well maybe the ideal solution might be somewhere in between. How about us adding a confluence page with features the test driver should have and then we work on doing this. I was thinking of adding more useable addresses to The test driver, sort of like the simulated sensors in the

[GitHub] JulianFeinauer closed pull request #36: Add simple mock driver

JulianFeinauer closed pull request #36: Add simple mock driver URL: https://github.com/apache/incubator-plc4x/pull/36 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] JulianFeinauer commented on issue #36: Add simple mock driver

JulianFeinauer commented on issue #36: Add simple mock driver URL: https://github.com/apache/incubator-plc4x/pull/36#issuecomment-435101505 @chrisdutz I'll check if I can add this Mock functionality in there. As I recall the test driver is currently working against internal values or

Re: Moving OPM Example

Hey Chris, I like Kittens also! And yes, I'm definitely okay and will prepare a documentation site soon to make it easier to adopt (well, I hope its pretty easy). Best Julian PS.: Kittens and Mallorca Am 01.11.18, 12:40 schrieb "Christofer Dutz" : Hi Julian, I am currently

Moving OPM Example

Hi Julian, I am currently taking the liberty to move your HelloOpm example into a dedicated Maven module. … Great stuff by the way ☺ The reasoning behind this is, that the hello-plc4x should be as simple as possible. By splitting it up you can also lay emphasis on the OPM and even

Re: Throw Exception when retrieving non-existing Field in Response

Hi, thanks for your response. I changed it. Julian Am 01.11.18, 12:30 schrieb "Christofer Dutz" : Hi Julian, I agree that we should throw an exception. Chris Am 31.10.18, 21:25 schrieb "Julian Feinauer" : Hi all, I found

[GitHub] chrisdutz commented on issue #36: Add simple mock driver

chrisdutz commented on issue #36: Add simple mock driver URL: https://github.com/apache/incubator-plc4x/pull/36#issuecomment-435013325 I thought it would make more sense to start removing all of these mock drivers and instead extend the "Test-Driver" as this should provide everything

Re: Throw Exception when retrieving non-existing Field in Response

Hi Julian, I agree that we should throw an exception. Chris Am 31.10.18, 21:25 schrieb "Julian Feinauer" : Hi all, I found some time today to test and toy around a bit with PLC4X and I discovered a behavior which I found weird. I had the response from a request which