Re: Time for a new release 0.3.0?

2019-01-15 Thread Julian Feinauer
Hi all, after merging Tims PR yesterday I think we are ready to start the preparation for a new release. As the only response I got to my last mail was positive I will start to update the Release Notes and prepare a branch and come back to you as soon as everything is setup. If there are any

[GitHub] JulianFeinauer merged pull request #43: S7 fix of array and String acquirement

2019-01-15 Thread GitBox
JulianFeinauer merged pull request #43: S7 fix of array and String acquirement URL: https://github.com/apache/incubator-plc4x/pull/43 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@plc4x.apache.org

[GitHub] JulianFeinauer commented on issue #43: S7 fix of array and String acquirement

2019-01-15 Thread GitBox
JulianFeinauer commented on issue #43: S7 fix of array and String acquirement URL: https://github.com/apache/incubator-plc4x/pull/43#issuecomment-454541093 > Are there no tests? Hey Otto, the only way to test this PLC Communication is through manual tests (this is why there is this

[GitHub] chrisdutz commented on issue #43: S7 fix of array and String acquirement

2019-01-15 Thread GitBox
chrisdutz commented on issue #43: S7 fix of array and String acquirement URL: https://github.com/apache/incubator-plc4x/pull/43#issuecomment-454526483 Feel free to merge ... This is an automated message from the Apache Git

[GitHub] ottobackwards commented on issue #43: S7 fix of array and String acquirement

2019-01-15 Thread GitBox
ottobackwards commented on issue #43: S7 fix of array and String acquirement URL: https://github.com/apache/incubator-plc4x/pull/43#issuecomment-454525224 Are there no tests? This is an automated message from the Apache Git

[GitHub] JulianFeinauer commented on issue #43: S7 fix of array and String acquirement

2019-01-15 Thread GitBox
JulianFeinauer commented on issue #43: S7 fix of array and String acquirement URL: https://github.com/apache/incubator-plc4x/pull/43#issuecomment-454491507 Looks good to me (also checked it against our S7). @chrisdutz do you want to look over it, otherwise I'll merge it.

Re: Antwort: Re: Antwort: Re: Antwort: Re: Antwort: Re: Anyone got experience with "protocol buffers" or DFDL (for generation of the message (de)serialization code)?

2019-01-15 Thread Otto Fowler
When you have a handle on what you need to do, open the jiras and post them here On January 15, 2019 at 10:43:30, Christofer Dutz (christofer.d...@c-ware.de) wrote: Hi Otto, I haven't opened any ... at the moment I'm trying to learn how to write schemas and have Daffodil parse them. Right now

Re: Antwort: Re: Antwort: Re: Antwort: Re: Antwort: Re: Anyone got experience with "protocol buffers" or DFDL (for generation of the message (de)serialization code)?

2019-01-15 Thread Christofer Dutz
Hi Otto, I haven't opened any ... at the moment I'm trying to learn how to write schemas and have Daffodil parse them. Right now I'm still in the phase of learning things. Even if when helping me, they did notice a regression that they opened an issue themselves ;-) Chris Am 15.01.19, 13:13

[GitHub] timbo2k opened a new pull request #43: S7 fix of array and String acquirement

2019-01-15 Thread GitBox
timbo2k opened a new pull request #43: S7 fix of array and String acquirement URL: https://github.com/apache/incubator-plc4x/pull/43 S7: fix of array acquirement, fix of String aquirement, added additional scraper yml This

Re: Antwort: Re: Antwort: Re: Antwort: Re: Antwort: Re: Anyone got experience with "protocol buffers" or DFDL (for generation of the message (de)serialization code)?

2019-01-15 Thread Otto Fowler
Maybe Chris can post the Jira Issues he has opened in Daffodil? On January 15, 2019 at 04:33:20, Julian Feinauer ( j.feina...@pragmaticminds.de) wrote: Hi Chris, thank you so much for your effort. I think this ist he right way to go forward and get more languages on-board. Hopefully, we can

Re: [S7] (manual) testing vs physical device

2019-01-15 Thread Christofer Dutz
Hi All, A big +1 for the genereal idea. However I think I would prefer having a separate repo for things like this. There are several reasons for this: 1) We will have a lot more different project types as for every PLC type and Vendor the demo program will be developed with a different IDE 2)

Re: [S7] (manual) testing vs physical device

2019-01-15 Thread Julian Feinauer
Hi Tim, I like the idea very much. I suggest to add this TIA program AND also a Test Class (which has to be started manually) which does a lot of reading against this known structure. This should then be done at least once before releases to ensure that things still work against a real S7. So

[S7] (manual) testing vs physical device

2019-01-15 Thread Tim Mitsch
Hi everybody We had a discussion about how to ensure correct functionality vs a physical S7 device as we just noticed some minor bugs during testing along arrays. I setuped a TIA programm with different datablocks containing different datatypes, arrays and so on; i will extend this with

Re: Antwort: Re: Antwort: Re: Antwort: Re: Antwort: Re: Anyone got experience with "protocol buffers" or DFDL (for generation of the message (de)serialization code)?

2019-01-15 Thread Christofer Dutz
Hi all, just some feedback on my efforts towards formal definition of protocol message types: It seems that DFDL is a perfect match for defining the data formats. Right now I'm working hard on writing a DFDL schema for the S7 Protocol as this has quite a number of "specialities" that provide a