Re: [DISCUSS] Check in generated Java code?

2022-11-25 Thread Łukasz Dywicki
Maven have "sources.jar" files which serve purpose of retaining all sources, not only generated ones. I would rather look for tool such https://abi-laboratory.pro/ which can interact with these than opening a pandora box or stick with cafecompare [1]. Having generated sources checked in will

Re: [DISCUSS] Check in generated Java code?

2022-11-25 Thread Christofer Dutz
It actually IS very helpful to see what changes in the code generation produce in differences in the output. It has saved me multiple times in other languages before. Chris From: Ben Hutcheson Date: Friday, 25. November 2022 at 21:45 To: dev@plc4x.apache.org Subject: Re: [DISCUSS] Check in

Re: [DISCUSS] Check in generated Java code?

2022-11-25 Thread Ben Hutcheson
+1 I like the idea of keeping a history of what has changed. This may help? https://medium.com/@clarkbw/managing-generated-files-in-github-1f1989c09dfd On Fri, Nov 25, 2022 at 9:03 AM Łukasz Dywicki wrote: > -1 from my side > > I don't think its a good idea, generated code currently changes

Re: [DISCUSS] Check in generated Java code?

2022-11-25 Thread Łukasz Dywicki
-1 from my side I don't think its a good idea, generated code currently changes far too often to make sense of it and its history. We rather track code for generators and templates which produce it. As long as language is fine with automatically generated sources, I opt for not polluting our

Call for help ... testing ...

2022-11-25 Thread Christofer Dutz
Hi all, as you might have read over the last few weeks. I have invested a huge amount of time into cleaning up some of the “dirty corners” and streamlined the APIs as well as the handling of Encoding and Decoding the different data types. Especially with the Temporal types and the String types,

Re: [DISCUSS] Check in generated Java code?

2022-11-25 Thread Lukas Ott
+1 as this simplifies for users Am Fr., 25. Nov. 2022 um 11:27 Uhr schrieb Christofer Dutz < christofer.d...@c-ware.de>: > Hi all, > > I know it’s sort of considered bad practice to check in generated code, > when you’re working with maven. > > However, we’ve already started to check-in

[DISCUSS] Check in generated Java code?

2022-11-25 Thread Christofer Dutz
Hi all, I know it’s sort of considered bad practice to check in generated code, when you’re working with maven. However, we’ve already started to check-in generated code for all other languages. Especially today when working on the Time and Date stuff I really have learned to appreciate to

[BUILD-STABLE]: Job 'PLC4X/PLC4X/develop [develop] [1168]'

2022-11-25 Thread Apache Jenkins Server
BUILD-STABLE: Job 'PLC4X/PLC4X/develop [develop] [1168]': Is back to normal.