Re: [PR] Various Changes (plc4x)

2023-02-04 Thread via GitHub
hutcheb commented on PR #784: URL: https://github.com/apache/plc4x/pull/784#issuecomment-1416920196 With the OPCUA protocol package, it seems to include MIT licensed files we use to generate the mspec. While it is a good idea to include them so we don't pull new updates automatically from

Re: [DISCUSS] Generally move to using "Context" objects inside our generated code?

2023-02-04 Thread Christofer Dutz
I'm more talking about a serialization and parse-context. Driver context would be something separate and I think we already have that, don't we? Gesendet von Outlook für Android From: Cesar Garcia Sent: Saturday, February 4, 2023 6:47:54

Re: [DISCUSS] Generally move to using "Context" objects inside our generated code?

2023-02-04 Thread Cesar Garcia
+1, If there's a way to get the driver's context, something like "PlcDriver.getContext()", and pass pipe information, interesting. El sáb, 4 feb 2023 a las 6:18, Christofer Dutz () escribió: > Hi all, > > recently I have been working on supporting dynamic tags like “_itemCount”, > “_curItem” and

Re: [DISCUSS] Generally move to using "Context" objects inside our generated code?

2023-02-04 Thread Lukas Ott
+1 yes Otto s comment is correct so it seems to be the next logical step. Otto Fowler schrieb am Sa., 4. Feb. 2023, 15:42: > Any DSL at some point will consider stack / call / variable contexts. > This seems reasonable. > > From: Christofer Dutz > > Reply: dev@plc4x.apache.org > Date:

Re: [PR] Various Changes (plc4x)

2023-02-04 Thread via GitHub
chrisdutz commented on PR #784: URL: https://github.com/apache/plc4x/pull/784#issuecomment-1416781289 Admittedly I would not like to merge this PR ... but I think we should have a look at it and possibly pick individual fixes, if we think they are good. -- This is an automated message

[PR] Various Changes (plc4x)

2023-02-04 Thread via GitHub
chrisdutz opened a new pull request, #784: URL: https://github.com/apache/plc4x/pull/784 This is a Pull Request containing various changes from the repo https://github.com/spnettec/plc4x It seems they deal with: - String handling in S7 - Support for S7 200 - Changes in the

Re: [PR] Feature/nifi integration address text (plc4x)

2023-02-04 Thread via GitHub
ottobackwards commented on PR #755: URL: https://github.com/apache/plc4x/pull/755#issuecomment-1416773300 This looks good. If you are ready, I will let you move it from Draft to ready for review, then I'll finish up -- This is an automated message from the Apache Git Service. To respond

Re: [DISCUSS] Generally move to using "Context" objects inside our generated code?

2023-02-04 Thread Otto Fowler
Any DSL at some point will consider stack / call / variable contexts. This seems reasonable. From: Christofer Dutz Reply: dev@plc4x.apache.org Date: February 4, 2023 at 05:18:59 To: dev@plc4x.apache.org Subject: [DISCUSS] Generally move to using "Context" objects inside our generated

[DISCUSS] Generally move to using "Context" objects inside our generated code?

2023-02-04 Thread Christofer Dutz
Hi all, recently I have been working on supporting dynamic tags like “_itemCount”, “_curItem” and “_lastItem” in array elements. In java I used ThreadLocals for this as it felt like a Java-Native way and it wouldn’t blow up the signatures of our Parser, Serializer and GetLengthInXYZ methods.