[GitHub] JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.

2018-08-03 Thread GitBox
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close. URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-410172284 @chrisdutz I guess due to my partial scala background I totally ignore Javas Completable futures as superior and thus didnt think about

[GitHub] JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.

2018-08-02 Thread GitBox
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close. URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-409963436 @sruehl my understanding is that netty avoids a scenario where one uses the event loop executors threads for blocking and thus, risks a

[GitHub] JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.

2018-08-02 Thread GitBox
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close. URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-409958048 @chrisdutz your fixes in the master made it work for me also. As I found a solution to avoid the blocking exception in the meanwhile I