[GitHub] sruehl commented on a change in pull request #14: WIP: Api Refactoring

2018-09-05 Thread GitBox
sruehl commented on a change in pull request #14: WIP: Api Refactoring URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r214037249 ## File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcWriteRequest.java ## @@ -24,6 +24,8 @@ Licensed

[GitHub] sruehl commented on a change in pull request #14: WIP: Api Refactoring

2018-08-30 Thread GitBox
sruehl commented on a change in pull request #14: WIP: Api Refactoring URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213981954 ## File path: plc4j/api/src/test/java/org/apache/plc4x/java/api/connection/PlcReaderTest.java ## @@ -38,24 +36,24 @@

[GitHub] sruehl commented on a change in pull request #14: WIP: Api Refactoring

2018-08-30 Thread GitBox
sruehl commented on a change in pull request #14: WIP: Api Refactoring URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213965327 ## File path: integrations/apache-camel/src/main/java/org/apache/plc4x/camel/Plc4XConsumer.java ## @@ -112,25 +114,25 @@

[GitHub] sruehl commented on a change in pull request #14: WIP: Api Refactoring

2018-08-30 Thread GitBox
sruehl commented on a change in pull request #14: WIP: Api Refactoring URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213965185 ## File path: integrations/apache-camel/src/main/java/org/apache/plc4x/camel/Plc4XConsumer.java ## @@ -84,22 +79,29 @@

[GitHub] sruehl commented on a change in pull request #14: WIP: Api Refactoring

2018-08-30 Thread GitBox
sruehl commented on a change in pull request #14: WIP: Api Refactoring URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213966073 ## File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcProprietarySender.java ## @@ -1,41 +0,0 @@ -/*

[GitHub] sruehl commented on a change in pull request #14: WIP: Api Refactoring

2018-08-30 Thread GitBox
sruehl commented on a change in pull request #14: WIP: Api Refactoring URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213967016 ## File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcFieldResponse.java ## @@ -0,0 +1,42 @@ +/*