Re: [PR] Implementation of session renewal functionality.

2024-07-04 Thread via GitHub
splatch commented on PR #1684: URL: https://github.com/apache/plc4x/pull/1684#issuecomment-2209628466 Changes been manually confirmed with prosys simulator and with s7-1200 opc server as well. There were no issues with both, hence I'm merging this PR without additional review. -- This is

Re: [PR] Implementation of session renewal functionality.

2024-07-04 Thread via GitHub
splatch merged PR #1684: URL: https://github.com/apache/plc4x/pull/1684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[PR] Implementation of session renewal functionality.

2024-07-02 Thread via GitHub
splatch opened a new pull request, #1684: URL: https://github.com/apache/plc4x/pull/1684 Updates to security session renewing logic to follow protocol defined in specification. First and foremost - keep secure channel id as well as request id. Second and most important - update security key