Christofer Dutz created PLC4X-211: ------------------------------------- Summary: PlcValues seem to always return "true" on the "isXYZ" checks. Key: PLC4X-211 URL: https://issues.apache.org/jira/browse/PLC4X-211 Project: Apache PLC4X Issue Type: Bug Components: Core Affects Versions: 0.7.0, 0.8.0 Reporter: Christofer Dutz Fix For: 0.8.0
It seems that all implementations of PlcValue seem to have an implementation of all "is" methods to simply return "true", actually they should check if the value is in the bounds of the given type. For PlcByte, this might be correct, cause the value of a PlcByte can be stored in any of the larger types, but for a PlcInteger the "isByte" check should check the value of the integer values against the bounds of a Short type. -- This message was sent by Atlassian Jira (v8.3.4#803005)