>
>
> Hi,
>
>> They will be needed, I just haven't implemented that.
>
> All good. A suggestion perhaps a few TODO’s in the code where things are
> missing would help?
+1 from my side on the TODOs. Stumbled over this a couple of times now too.
>
> Thanks,
> Justin
Sebastian
Hi,
> They will be needed, I just haven't implemented that.
All good. A suggestion perhaps a few TODO’s in the code where things are
missing would help?
Thanks,
Justin
s/ghei36> herunterladen
Von: Justin Mclean
Gesendet: Freitag, 5. Januar, 05:29
Betreff: IsoTPProtocol un-accessed private properties
An: dev@plc4x.apache.org
Hi, IsoTPProtocol has these properties: private CalledTsapParameter
calledTsapParameter; private TpduSizeParameter tpduSizeParameter; They ar
Hi,
IsoTPProtocol has these properties:
private CalledTsapParameter calledTsapParameter;
private TpduSizeParameter tpduSizeParameter;
They are assigned but not accessed and could be local vars rather than fields.
Is there any reason for that? I assume the code just not been completed yet?
Than
