Re: [DRAFT] Oktober Podling Report Apache PLC4X (incubating)
So I think we'll go with that version ... So let's see where I have to put it __ Chris Am 02.10.18, 14:41 schrieb "Julian Feinauer" : Fine for me. Am 02.10.18, 10:30 schrieb "Christofer Dutz" : So how about this: --- Apache PLC4X (incubating) PLC4X is a set of libraries for communicating with industrial programmable logic controllers (PLCs) using a variety of protocols but with a shared API. Most important issues to address while moving towards graduation: Building the community: The PPMC and committer group has a large percentage of codecentric employees, we have been recruiting people from other companies, but will have to continue these efforts for establishing a healthy Apache community. Onboarding of new committers: With PLC4X several people on the team are not very familiar with the Apache Way. We have started and will continue our efforts on this onboarding. Any Issues the Incubator PMC or ASF Board might wish/need to be aware of: Not at the moment. How has the community developed since the last report? While the community activity had been quite low since the beginning of the project, things changed in August. Then we noticed not only new names appearing on the list, but the number of emails on the list grew by 400%-500%. Also did we get several pull requests from about 5 new names, contributing to multiple areas. Two of them got added to the Committers and PPMC groups. The others were one-shot contributions without any further communications. In September Christofer Dutz had two talks on PLC4X at two conferences: * Solutions Hamburg 2018 * ApacheCon NA 2018 An article on PLC4X by Christofer Dutz was published in the German Tech Magazine: iX (Link to the article: https://www.heise.de/select/ix/2018/8/1533352444905693) Also, just before ApacheCon we also had our first PLC4X Meetup where several current contributors as well as very interested new people were present. Also did we successfully vote in our first two new committers and PPMC members. * Julian Feinauer (pragmatic industries) * Andrey Skorikov (codecentric) Finally just before finishing this report we also finished our first release: Version 0.1.0 Our mailing list subscriptions went up another 9 to currently 38 subscribers. Our Twitter followers increased by 18 to 59 followers. On GitHub we now have 24 “Stars” and 14 “Forks” Business interest has increased dramatically as more and more companies are signaling their willingness to try out PLC4X and some are currently even in the transition phase of porting their products to PLC4X. How does the podling rate their own maturity? We have a mix of new participants and experienced Apache people involved. So far, the new participants have shown great willingness and success in adopting the Apache Way. However, we still need to continue: the on-boarding increasing the diversity of the team. After our first official release, we will now fine-tune this release process and try to educate other people on the team to also be able to do releases. --- Am 02.10.18, 09:18 schrieb "Julian Feinauer" : Hi Chris, Just a small (but important) note on the company I'm working for, its "pragmatic industries" (all lower case). We also have the pragmatic minds company, but the CCLA is for the industries, as I do this in the time I'm working for the pragmatic industries. Julian Am 02.10.18, 08:36 schrieb "Christofer Dutz" : Hi Justin, thanks for that input .. you are absolutely right ... so here goes an updated version ... --- Apache PLC4X (incubating) PLC4X is a set of libraries for communicating with industrial programmable logic controllers (PLCs) using a variety of protocols but with a shared API. Most important issues to address while moving towards graduation: Building the community: The PPMC and committer group has a large percentage of codecentric
Re: [DRAFT] Oktober Podling Report Apache PLC4X (incubating)
Fine for me. Am 02.10.18, 10:30 schrieb "Christofer Dutz" : So how about this: --- Apache PLC4X (incubating) PLC4X is a set of libraries for communicating with industrial programmable logic controllers (PLCs) using a variety of protocols but with a shared API. Most important issues to address while moving towards graduation: Building the community: The PPMC and committer group has a large percentage of codecentric employees, we have been recruiting people from other companies, but will have to continue these efforts for establishing a healthy Apache community. Onboarding of new committers: With PLC4X several people on the team are not very familiar with the Apache Way. We have started and will continue our efforts on this onboarding. Any Issues the Incubator PMC or ASF Board might wish/need to be aware of: Not at the moment. How has the community developed since the last report? While the community activity had been quite low since the beginning of the project, things changed in August. Then we noticed not only new names appearing on the list, but the number of emails on the list grew by 400%-500%. Also did we get several pull requests from about 5 new names, contributing to multiple areas. Two of them got added to the Committers and PPMC groups. The others were one-shot contributions without any further communications. In September Christofer Dutz had two talks on PLC4X at two conferences: * Solutions Hamburg 2018 * ApacheCon NA 2018 An article on PLC4X by Christofer Dutz was published in the German Tech Magazine: iX (Link to the article: https://www.heise.de/select/ix/2018/8/1533352444905693) Also, just before ApacheCon we also had our first PLC4X Meetup where several current contributors as well as very interested new people were present. Also did we successfully vote in our first two new committers and PPMC members. * Julian Feinauer (pragmatic industries) * Andrey Skorikov (codecentric) Finally just before finishing this report we also finished our first release: Version 0.1.0 Our mailing list subscriptions went up another 9 to currently 38 subscribers. Our Twitter followers increased by 18 to 59 followers. On GitHub we now have 24 “Stars” and 14 “Forks” Business interest has increased dramatically as more and more companies are signaling their willingness to try out PLC4X and some are currently even in the transition phase of porting their products to PLC4X. How does the podling rate their own maturity? We have a mix of new participants and experienced Apache people involved. So far, the new participants have shown great willingness and success in adopting the Apache Way. However, we still need to continue: the on-boarding increasing the diversity of the team. After our first official release, we will now fine-tune this release process and try to educate other people on the team to also be able to do releases. --- Am 02.10.18, 09:18 schrieb "Julian Feinauer" : Hi Chris, Just a small (but important) note on the company I'm working for, its "pragmatic industries" (all lower case). We also have the pragmatic minds company, but the CCLA is for the industries, as I do this in the time I'm working for the pragmatic industries. Julian Am 02.10.18, 08:36 schrieb "Christofer Dutz" : Hi Justin, thanks for that input .. you are absolutely right ... so here goes an updated version ... --- Apache PLC4X (incubating) PLC4X is a set of libraries for communicating with industrial programmable logic controllers (PLCs) using a variety of protocols but with a shared API. Most important issues to address while moving towards graduation: Building the community: The PPMC and committer group has a large percentage of codecentric employees, we have been recruiting people from other companies, but will have to continue these efforts for establishing a healthy Apache community. Onboarding of new committers: With PLC4X several people on the team are not very familiar with the Apache Way. We have started and will continue our efforts on this onboarding. Any Issues the Incubator PMC or ASF Board might wish/need to be aware of: Not at the moment.
Re: [DRAFT] Oktober Podling Report Apache PLC4X (incubating)
So how about this: --- Apache PLC4X (incubating) PLC4X is a set of libraries for communicating with industrial programmable logic controllers (PLCs) using a variety of protocols but with a shared API. Most important issues to address while moving towards graduation: Building the community: The PPMC and committer group has a large percentage of codecentric employees, we have been recruiting people from other companies, but will have to continue these efforts for establishing a healthy Apache community. Onboarding of new committers: With PLC4X several people on the team are not very familiar with the Apache Way. We have started and will continue our efforts on this onboarding. Any Issues the Incubator PMC or ASF Board might wish/need to be aware of: Not at the moment. How has the community developed since the last report? While the community activity had been quite low since the beginning of the project, things changed in August. Then we noticed not only new names appearing on the list, but the number of emails on the list grew by 400%-500%. Also did we get several pull requests from about 5 new names, contributing to multiple areas. Two of them got added to the Committers and PPMC groups. The others were one-shot contributions without any further communications. In September Christofer Dutz had two talks on PLC4X at two conferences: * Solutions Hamburg 2018 * ApacheCon NA 2018 An article on PLC4X by Christofer Dutz was published in the German Tech Magazine: iX (Link to the article: https://www.heise.de/select/ix/2018/8/1533352444905693) Also, just before ApacheCon we also had our first PLC4X Meetup where several current contributors as well as very interested new people were present. Also did we successfully vote in our first two new committers and PPMC members. * Julian Feinauer (pragmatic industries) * Andrey Skorikov (codecentric) Finally just before finishing this report we also finished our first release: Version 0.1.0 Our mailing list subscriptions went up another 9 to currently 38 subscribers. Our Twitter followers increased by 18 to 59 followers. On GitHub we now have 24 “Stars” and 14 “Forks” Business interest has increased dramatically as more and more companies are signaling their willingness to try out PLC4X and some are currently even in the transition phase of porting their products to PLC4X. How does the podling rate their own maturity? We have a mix of new participants and experienced Apache people involved. So far, the new participants have shown great willingness and success in adopting the Apache Way. However, we still need to continue: the on-boarding increasing the diversity of the team. After our first official release, we will now fine-tune this release process and try to educate other people on the team to also be able to do releases. --- Am 02.10.18, 09:18 schrieb "Julian Feinauer" : Hi Chris, Just a small (but important) note on the company I'm working for, its "pragmatic industries" (all lower case). We also have the pragmatic minds company, but the CCLA is for the industries, as I do this in the time I'm working for the pragmatic industries. Julian Am 02.10.18, 08:36 schrieb "Christofer Dutz" : Hi Justin, thanks for that input .. you are absolutely right ... so here goes an updated version ... --- Apache PLC4X (incubating) PLC4X is a set of libraries for communicating with industrial programmable logic controllers (PLCs) using a variety of protocols but with a shared API. Most important issues to address while moving towards graduation: Building the community: The PPMC and committer group has a large percentage of codecentric employees, we have been recruiting people from other companies, but will have to continue these efforts for establishing a healthy Apache community. Onboarding of new committers: With PLC4X several people on the team are not very familiar with the Apache Way. We have started and will continue our efforts on this onboarding. Any Issues the Incubator PMC or ASF Board might wish/need to be aware of: Not at the moment. How has the community developed since the last report? While the community activity had been quite low since the beginning of the project, things changed in August. Then we noticed not only new names appearing on the list, but the number of emails on the list grew by 400%-500%. Also did we get several pull requests from about 5 new names, contributing to multiple areas. Two of them
[GitHub] JulianFeinauer closed pull request #21: Made PlcInvalidFieldException.java checked.
JulianFeinauer closed pull request #21: Made PlcInvalidFieldException.java
checked.
URL: https://github.com/apache/incubator-plc4x/pull/21
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/integrations/apache-kafka/src/main/java/org/apache/plc4x/kafka/Plc4xSinkTask.java
b/integrations/apache-kafka/src/main/java/org/apache/plc4x/kafka/Plc4xSinkTask.java
index 648a32e4a..83c75ac25 100644
---
a/integrations/apache-kafka/src/main/java/org/apache/plc4x/kafka/Plc4xSinkTask.java
+++
b/integrations/apache-kafka/src/main/java/org/apache/plc4x/kafka/Plc4xSinkTask.java
@@ -26,6 +26,8 @@ Licensed to the Apache Software Foundation (ASF) under one
import org.apache.plc4x.java.api.connection.PlcConnection;
import org.apache.plc4x.java.api.connection.PlcWriter;
import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
+import org.apache.plc4x.java.api.exceptions.PlcInvalidFieldException;
+import org.apache.plc4x.java.api.exceptions.UncheckedPlcInvalidFieldException;
import org.apache.plc4x.java.api.messages.PlcWriteRequest;
import org.apache.plc4x.kafka.util.VersionUtil;
@@ -66,7 +68,13 @@ public void put(Collection records) {
String query = record.key().toString();
Object value = record.value();
PlcWriteRequest.Builder builder = plcWriter.writeRequestBuilder();
-PlcWriteRequest plcRequest = addToBuilder(builder, query,
value).build();
+PlcWriteRequest plcRequest = null;
+try {
+plcRequest = addToBuilder(builder, query, value).build();
+} catch (PlcInvalidFieldException e) {
+// TODO How should this be handled?
+throw new UncheckedPlcInvalidFieldException(e);
+}
doWrite(plcRequest);
}
}
diff --git
a/integrations/apache-kafka/src/main/java/org/apache/plc4x/kafka/Plc4xSourceTask.java
b/integrations/apache-kafka/src/main/java/org/apache/plc4x/kafka/Plc4xSourceTask.java
index 7d0ed8621..fd29dbc3e 100644
---
a/integrations/apache-kafka/src/main/java/org/apache/plc4x/kafka/Plc4xSourceTask.java
+++
b/integrations/apache-kafka/src/main/java/org/apache/plc4x/kafka/Plc4xSourceTask.java
@@ -29,6 +29,8 @@ Licensed to the Apache Software Foundation (ASF) under one
import org.apache.plc4x.java.api.connection.PlcConnection;
import org.apache.plc4x.java.api.connection.PlcReader;
import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
+import org.apache.plc4x.java.api.exceptions.PlcInvalidFieldException;
+import org.apache.plc4x.java.api.exceptions.UncheckedPlcInvalidFieldException;
import org.apache.plc4x.java.api.messages.PlcReadRequest;
import org.apache.plc4x.java.api.messages.PlcReadResponse;
import org.apache.plc4x.java.api.types.PlcResponseCode;
@@ -93,7 +95,12 @@ public void start(Map props) {
for (String query : queries) {
builder.addItem(query, query);
}
-plcRequest = builder.build();
+try {
+plcRequest = builder.build();
+} catch (PlcInvalidFieldException e) {
+// TODO how should this be handled?
+throw new UncheckedPlcInvalidFieldException(e);
+}
int rate =
Integer.valueOf(props.get(Plc4xSourceConnector.RATE_CONFIG));
scheduler = Executors.newScheduledThreadPool(1);
diff --git
a/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcReader.java
b/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcReader.java
index d32640963..5aabbf031 100644
---
a/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcReader.java
+++
b/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcReader.java
@@ -18,6 +18,7 @@ Licensed to the Apache Software Foundation (ASF) under one
*/
package org.apache.plc4x.java.api.connection;
+import org.apache.plc4x.java.api.exceptions.PlcInvalidFieldException;
import org.apache.plc4x.java.api.messages.PlcReadRequest;
import org.apache.plc4x.java.api.messages.PlcReadResponse;
@@ -43,7 +44,7 @@ Licensed to the Apache Software Foundation (ASF) under one
* @param readRequestBuilderConsumer consumer which can be used to build
requests.
* @return a {@link CompletableFuture} giving async access to the returned
value.
*/
-default CompletableFuture>
read(Consumer readRequestBuilderConsumer) {
+default CompletableFuture>
read(Consumer readRequestBuilderConsumer) throws
PlcInvalidFieldException {
PlcReadRequest.Builder requestBuilder = readRequestBuilder();
readRequestBuilderConsumer.accept(requestBuilder);
return read(requestBuilder.build());
diff --git
a/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcSubscriber.java
[GitHub] JulianFeinauer commented on issue #21: Made PlcInvalidFieldException.java checked.
JulianFeinauer commented on issue #21: Made PlcInvalidFieldException.java checked. URL: https://github.com/apache/incubator-plc4x/pull/21#issuecomment-426191726 Closing as suggested by sebastian. But I definitly like to adress the topic nonetheless as we heavily depend on user input which can always be errorous. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sruehl commented on issue #21: Made PlcInvalidFieldException.java checked.
sruehl commented on issue #21: Made PlcInvalidFieldException.java checked. URL: https://github.com/apache/incubator-plc4x/pull/21#issuecomment-426188765 As I said: The annoyance to be forked to catch a exception would outweigh the benefit. In the usual api use this would a one-time-occur-exception so we would require the developer to pollute the code with catch(e) new RuntimeException(e) snippets. So I would suggest/vote to close this PR and maybe pickup the topic in later releases (if at all). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JulianFeinauer closed pull request #25: PLC4X-57 Bugfix
JulianFeinauer closed pull request #25: PLC4X-57 Bugfix
URL: https://github.com/apache/incubator-plc4x/pull/25
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/examples/hello-plc4x/src/main/java/org/apache/plc4x/java/examples/helloplc4x/HelloPlc4x.java
b/examples/hello-plc4x/src/main/java/org/apache/plc4x/java/examples/helloplc4x/HelloPlc4x.java
index bbf7c1be9..e0784349f 100644
---
a/examples/hello-plc4x/src/main/java/org/apache/plc4x/java/examples/helloplc4x/HelloPlc4x.java
+++
b/examples/hello-plc4x/src/main/java/org/apache/plc4x/java/examples/helloplc4x/HelloPlc4x.java
@@ -70,26 +70,7 @@ public static void main(String[] args) {
System.out.println("\nSynchronous request ...");
PlcReadResponse syncResponse =
plcReader.read(plcReadRequest).get();
// Simply iterating over the field names returned in the
response.
-for (String fieldName : syncResponse.getFieldNames()) {
-if(syncResponse.getResponseCode(fieldName) ==
PlcResponseCode.OK) {
-int numValues =
syncResponse.getNumberOfValues(fieldName);
-// If it's just one element, output just one single
line.
-if(numValues == 1) {
-System.out.println("Value[" + fieldName + "]: " +
syncResponse.getObject(fieldName));
-}
-// If it's more than one element, output each in a
single row.
-else {
-System.out.println("Value[" + fieldName + "]:");
-for(int i = 0; i < numValues; i++) {
-System.out.println(" - " +
syncResponse.getObject(fieldName, i));
-}
-}
-}
-// Something went wrong, to output an error message
instead.
-else {
-System.out.println("Error[" + fieldName + "]: " +
syncResponse.getResponseCode(fieldName).name());
-}
-}
+printResponse(syncResponse);
//
// Read asynchronously ...
@@ -98,13 +79,7 @@ public static void main(String[] args) {
CompletableFuture> asyncResponse =
plcReader.read(plcReadRequest);
asyncResponse.whenComplete((readResponse, throwable) -> {
if (readResponse != null) {
-for (String fieldName : syncResponse.getFieldNames()) {
-if (syncResponse.getResponseCode(fieldName) ==
PlcResponseCode.OK) {
-System.out.println("Value[" + fieldName + "]:
" + syncResponse.getObject(fieldName));
-} else {
-System.out.println("Error[" + fieldName + "]:
" + syncResponse.getResponseCode(fieldName).name());
-}
-}
+printResponse(syncResponse);
} else {
logger.error("An error occurred", throwable);
}
@@ -119,4 +94,27 @@ public static void main(String[] args) {
}
}
+private static void printResponse(PlcReadResponse syncResponse) {
+for (String fieldName : syncResponse.getFieldNames()) {
+if(syncResponse.getResponseCode(fieldName) == PlcResponseCode.OK) {
+int numValues = syncResponse.getNumberOfValues(fieldName);
+// If it's just one element, output just one single line.
+if(numValues == 1) {
+System.out.println("Value[" + fieldName + "]: " +
syncResponse.getObject(fieldName));
+}
+// If it's more than one element, output each in a single row.
+else {
+System.out.println("Value[" + fieldName + "]:");
+for(int i = 0; i < numValues; i++) {
+System.out.println(" - " +
syncResponse.getObject(fieldName, i));
+}
+}
+}
+// Something went wrong, to output an error message instead.
+else {
+System.out.println("Error[" + fieldName + "]: " +
syncResponse.getResponseCode(fieldName).name());
+}
+}
+}
+
}
diff --git
a/plc4j/protocols/s7/src/main/java/org/apache/plc4x/java/s7/netty/Plc4XS7Protocol.java
b/plc4j/protocols/s7/src/main/java/org/apache/plc4x/java/s7/netty/Plc4XS7Protocol.java
index 83b7f3b53..e2963d371 100644
---
Re: [DRAFT] Oktober Podling Report Apache PLC4X (incubating)
Hi Justin, thanks for that input .. you are absolutely right ... so here goes an updated version ... --- Apache PLC4X (incubating) PLC4X is a set of libraries for communicating with industrial programmable logic controllers (PLCs) using a variety of protocols but with a shared API. Most important issues to address while moving towards graduation: Building the community: The PPMC and committer group has a large percentage of codecentric employees, we have been recruiting people from other companies, but will have to continue these efforts for establishing a healthy Apache community. Onboarding of new committers: With PLC4X several people on the team are not very familiar with the Apache Way. We have started and will continue our efforts on this onboarding. Any Issues the Incubator PMC or ASF Board might wish/need to be aware of: Not at the moment. How has the community developed since the last report? While the community activity had been quite low since the beginning of the project, things changed in August. Then we noticed not only new names appearing on the list, but the number of emails on the list grew by 400%-500%. Also did we get several pull requests from about 5 new names, contributing to multiple areas. Two of them got added to the Committers and PPMC groups. The others were one-shot contributions without any further communications. In September Christofer Dutz had two talks on PLC4X at two conferences: * Solutions Hamburg 2018 * ApacheCon NA 2018 An article on PLC4X by Christofer Dutz was published in the German Tech Magazine: iX (Link to the article: https://www.heise.de/select/ix/2018/8/1533352444905693) Also, just before ApacheCon we also had our first PLC4X Meetup where several current contributors as well as very interested new people were present. Also did we successfully vote in our first two new committers and PPMC members. * Julian Feinauer (Pragmatic Minds) * Andrey Skorikov (codecentric) Finally just before finishing this report we also finished our first release: Version 0.1.0 Our mailing list subscriptions went up another 9 to currently 38 subscribers. Our Twitter followers increased by 18 to 59 followers. On GitHub we now have 24 “Stars” and 14 “Forks” Business interest has increased dramatically as more and more companies are signaling their willingness to try out PLC4X and some are currently even in the transition phase of porting their products to PLC4X. How does the podling rate their own maturity? We have a mix of new participants and experienced Apache people involved. So far, the new participants have shown great willingness and success in adopting the Apache Way. However, we still need to continue: the on-boarding increasing the diversity of the team. After our first official release, we will now fine-tune this release process and try to educate other people on the team to also be able to do releases. --- Am 02.10.18, 07:07 schrieb "Justin Mclean" : Hi, All good by me, a couple of (very) minor things below. > Make our first release You done this so no need to list it? > While the community activity had been quite low since the beginning of the project, things changed in August. > Then we noticed not only new names appearing on the list, but the number of emails on the list grew by 400%-500%. > Also did we get several pull requests from about 5 new names, contributing to multiple areas. It likely you be asked if any of these are committer worthy. > However, we still need to continue: the on-boarding increasing the diversity of the team. > After our first official release, we will now fine-tune this release process and try to educate other members > of the team to also be able to do releases. “members” is such an overloaded term at the ASF it might be better to use something else? "other people on the PPMC" perhaps? Thanks,. Justin
