Re: [DISCUSS] How about a new release some time soon?

2018-10-29 Thread Julian Feinauer
+1 from my side as well.

Am 29.10.18, 16:29 schrieb "Bahamada" 
:

+1 from my side

Von: Christofer Dutz
Gesendet: Montag, 29. Oktober 2018 15:17
An: dev@plc4x.apache.org
Betreff: [DISCUSS] How about a new release some time soon?

Hi all,

after I think we addressed all the open issues reported during the last 
release and us doing some more refactoring, cleaning up, fixing things.
I would propose us to do a new release some time soon.

I did encounter and fix quite a number of bugs that will under guarantee 
affect people trying out PLC4X.

And just yesterday I managed to fix the last reported bug in Sonar and 
address a lot of Code-Smells.

However I would feel better if we managed to increase the test-coverage a 
little more.
I guess as soon as we pass the quality gate of at least 80%, we should 
initiate the release process.

Also I guess we shouldn’t all blindly start working on the same parts, we 
should coordinate a little more here.
So I, for myself will be concentrating on the S7 module.

What do you think?

Chris






AW: [DISCUSS] How about a new release some time soon?

2018-10-29 Thread Bahamada
+1 from my side

Von: Christofer Dutz
Gesendet: Montag, 29. Oktober 2018 15:17
An: dev@plc4x.apache.org
Betreff: [DISCUSS] How about a new release some time soon?

Hi all,

after I think we addressed all the open issues reported during the last release 
and us doing some more refactoring, cleaning up, fixing things.
I would propose us to do a new release some time soon.

I did encounter and fix quite a number of bugs that will under guarantee affect 
people trying out PLC4X.

And just yesterday I managed to fix the last reported bug in Sonar and address 
a lot of Code-Smells.

However I would feel better if we managed to increase the test-coverage a 
little more.
I guess as soon as we pass the quality gate of at least 80%, we should initiate 
the release process.

Also I guess we shouldn’t all blindly start working on the same parts, we 
should coordinate a little more here.
So I, for myself will be concentrating on the S7 module.

What do you think?

Chris




[DISCUSS] How about a new release some time soon?

2018-10-29 Thread Christofer Dutz
Hi all,

after I think we addressed all the open issues reported during the last release 
and us doing some more refactoring, cleaning up, fixing things.
I would propose us to do a new release some time soon.

I did encounter and fix quite a number of bugs that will under guarantee affect 
people trying out PLC4X.

And just yesterday I managed to fix the last reported bug in Sonar and address 
a lot of Code-Smells.

However I would feel better if we managed to increase the test-coverage a 
little more.
I guess as soon as we pass the quality gate of at least 80%, we should initiate 
the release process.

Also I guess we shouldn’t all blindly start working on the same parts, we 
should coordinate a little more here.
So I, for myself will be concentrating on the S7 module.

What do you think?

Chris



Extract dependency on Netty from AbstractPlcConnection into NettyPlcConnection

2018-10-29 Thread Andrey Skorikov

Hello all,

I extracted the dependency on Netty from AbstractPlcConnection into a 
subclass (NettyPlcConnection). AbstractPlcConnection now contains only 
boilerplate for concrete protocol implementations, including test 
drivers, which do not use any network connections.


The pull request is open on GitHub: 
https://github.com/apache/incubator-plc4x/pull/33


Best regards,
Andrey