Re: [PR] Updated DataIo Template (And working on the Siemens S7 L-types as well as Temporal types)

2024-02-05 Thread via GitHub
sruehl commented on code in PR #1376: URL: https://github.com/apache/plc4x/pull/1376#discussion_r1477996759 ## plc4j/drivers/firmata/src/main/java/org/apache/plc4x/java/firmata/readwrite/protocol/FirmataProtocolLogic.java: ## @@ -71,12 +71,22 @@ public void onConnect(Conversatio

Re: [PR] Updated DataIo Template (And working on the Siemens S7 L-types as well as Temporal types)

2024-02-05 Thread via GitHub
sruehl commented on code in PR #1376: URL: https://github.com/apache/plc4x/pull/1376#discussion_r1477996368 ## plc4j/drivers/firmata/src/main/java/org/apache/plc4x/java/firmata/readwrite/protocol/FirmataProtocolLogic.java: ## @@ -71,12 +71,22 @@ public void onConnect(Conversatio

Re: [PR] build(deps): bump github.com/rs/zerolog from 1.31.0 to 1.32.0 in /plc4go

2024-02-05 Thread via GitHub
sruehl merged PR #1378: URL: https://github.com/apache/plc4x/pull/1378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] Updated DataIo Template (And working on the Siemens S7 L-types as well as Temporal types)

2024-02-05 Thread via GitHub
chrisdutz commented on code in PR #1376: URL: https://github.com/apache/plc4x/pull/1376#discussion_r1478022977 ## plc4j/drivers/firmata/src/main/java/org/apache/plc4x/java/firmata/readwrite/protocol/FirmataProtocolLogic.java: ## @@ -71,12 +71,22 @@ public void onConnect(Conversa

Re: [PR] Updated DataIo Template (And working on the Siemens S7 L-types as well as Temporal types)

2024-02-05 Thread via GitHub
chrisdutz commented on code in PR #1376: URL: https://github.com/apache/plc4x/pull/1376#discussion_r1478023988 ## plc4j/drivers/firmata/src/main/java/org/apache/plc4x/java/firmata/readwrite/protocol/FirmataProtocolLogic.java: ## @@ -71,12 +71,22 @@ public void onConnect(Conversa

Re: [PR] Updated DataIo Template (And working on the Siemens S7 L-types as well as Temporal types)

2024-02-05 Thread via GitHub
sruehl commented on code in PR #1376: URL: https://github.com/apache/plc4x/pull/1376#discussion_r1478027120 ## plc4j/drivers/firmata/src/main/java/org/apache/plc4x/java/firmata/readwrite/protocol/FirmataProtocolLogic.java: ## @@ -71,12 +71,22 @@ public void onConnect(Conversatio

Re: [PR] Updated DataIo Template (And working on the Siemens S7 L-types as well as Temporal types)

2024-02-05 Thread via GitHub
sruehl commented on code in PR #1376: URL: https://github.com/apache/plc4x/pull/1376#discussion_r1478028947 ## plc4j/drivers/firmata/src/main/java/org/apache/plc4x/java/firmata/readwrite/protocol/FirmataProtocolLogic.java: ## @@ -71,12 +71,22 @@ public void onConnect(Conversatio

Re: [PR] Updated DataIo Template (And working on the Siemens S7 L-types as well as Temporal types)

2024-02-05 Thread via GitHub
sruehl commented on code in PR #1376: URL: https://github.com/apache/plc4x/pull/1376#discussion_r1478027799 ## plc4j/drivers/firmata/src/main/java/org/apache/plc4x/java/firmata/readwrite/protocol/FirmataProtocolLogic.java: ## @@ -71,12 +71,22 @@ public void onConnect(Conversatio

Re: [PR] Updated DataIo Template (And working on the Siemens S7 L-types as well as Temporal types)

2024-02-05 Thread via GitHub
splatch commented on code in PR #1376: URL: https://github.com/apache/plc4x/pull/1376#discussion_r1478031568 ## plc4j/drivers/firmata/src/main/java/org/apache/plc4x/java/firmata/readwrite/protocol/FirmataProtocolLogic.java: ## @@ -71,12 +71,22 @@ public void onConnect(Conversati

[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [1836]'

2024-02-05 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [1836]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/1836/";>PLC4X/PLC4X/develop [develop] [1836]"

Re: [I] [Bug][plc4j][EIP]: Uneccessary Thread.sleep in EipProtocolLogic

2024-02-05 Thread via GitHub
schaebo commented on issue #1373: URL: https://github.com/apache/plc4x/issues/1373#issuecomment-1927057837 Thanks for the quick response and action. > Would you be able to share what device you are communicating with? Most tests I did were with a AB CompactLogix 1769 -- This is a

Re: [PR] build(deps): bump com.influxdb:influxdb-client-java from 6.12.0 to 7.0.0

2024-02-05 Thread via GitHub
sruehl merged PR #1372: URL: https://github.com/apache/plc4x/pull/1372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump nifi.version from 1.24.0 to 1.25.0

2024-02-05 Thread via GitHub
sruehl merged PR #1371: URL: https://github.com/apache/plc4x/pull/1371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [I] [Bug][plc4j][EIP]: Uneccessary Thread.sleep in EipProtocolLogic

2024-02-05 Thread via GitHub
chrisdutz commented on issue #1373: URL: https://github.com/apache/plc4x/issues/1373#issuecomment-1927092046 I personally have a CompactLogix 1769 (L24ER QBFC1B) as well ... and hopefully will be able to continue my work on enabling Browse functionality as soon as we have the next release o

[BUILD-STABLE]: Job 'PLC4X/PLC4X/develop [develop] [1837]'

2024-02-05 Thread Apache Jenkins Server
BUILD-STABLE: Job 'PLC4X/PLC4X/develop [develop] [1837]': Is back to normal.

Re: [I] [Bug][plc4j][EIP]: Uneccessary Thread.sleep in EipProtocolLogic

2024-02-05 Thread via GitHub
hutcheb commented on issue #1373: URL: https://github.com/apache/plc4x/issues/1373#issuecomment-1927277268 It should probably be using the message router and connection manager instead. Not sure why the driver didn’t detect they weren’t available though. Are you using the logix d

Re: [PR] [opcua] Implementation of client side security policy

2024-02-05 Thread via GitHub
chrisdutz commented on PR #1007: URL: https://github.com/apache/plc4x/pull/1007#issuecomment-1927311384 Had a look at the stuff outside of the OPC-UA driver directories and have no objections to merging this. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] [opcua] Implementation of client side security policy

2024-02-05 Thread via GitHub
splatch commented on PR #1007: URL: https://github.com/apache/plc4x/pull/1007#issuecomment-1927343775 @chrisdutz I saw the dataio updates and I strive to merge this before you do. ;-) I will rebase it on top of current develop and wait for Patryk to amend sign-off on his commit. Today we wi

Re: [PR] [opcua] Implementation of client side security policy

2024-02-05 Thread via GitHub
sruehl commented on PR #1007: URL: https://github.com/apache/plc4x/pull/1007#issuecomment-1927352332 Even if you would get a conflict with the generated code, it should be now problem as it always can be solved by regenerating :) -- This is an automated message from the Apache Git Service