Re: [PR] build(deps): bump junit.jupiter.version from 5.11.4 to 5.12.0

2025-05-02 Thread via GitHub
sruehl closed pull request #2020: build(deps): bump junit.jupiter.version from 5.11.4 to 5.12.0 URL: https://github.com/apache/plc4x/pull/2020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] feat(plc4j/modbus): ModbusOptimizer fixes for discrete-input and endianness

2025-05-02 Thread via GitHub
sruehl commented on PR #2055: URL: https://github.com/apache/plc4x/pull/2055#issuecomment-2846511151 LGTM, WDYT @chrisdutz? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] feat(plc4j/modbus): ModbusOptimizer fixes for discrete-input and endianness

2025-05-02 Thread via GitHub
chrisdutz commented on PR #2055: URL: https://github.com/apache/plc4x/pull/2055#issuecomment-2846528173 It does ... haven't had the chance to have a detailed look at it. But as I have never used the discrete-inputs anyway, I'll probably not get to doing it. -- This is an automated message

Re: [PR] feat(plc4j/opcua): Remove additional hostname resolution within OPC-UA

2025-05-02 Thread via GitHub
sruehl merged PR #2028: URL: https://github.com/apache/plc4x/pull/2028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump org.yaml:snakeyaml from 2.3 to 2.4

2025-05-02 Thread via GitHub
sruehl merged PR #2011: URL: https://github.com/apache/plc4x/pull/2011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] Fix get array on source processor to not overwrite values

2025-05-02 Thread via GitHub
ottobackwards commented on PR #335: URL: https://github.com/apache/plc4x-extras/pull/335#issuecomment-2846879887 So, the sink processor needs to be able to handle these values as well as it uses the attributes. This is all just yucky. The tag value is passed to PLC4X's api, so now you wo

Re: [PR] feat(plc4j/modbus): ModbusOptimizer fixes for discrete-input and endianness

2025-05-02 Thread via GitHub
sruehl merged PR #2055: URL: https://github.com/apache/plc4x/pull/2055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org