Immutability of plc4j-api

2018-08-16 Thread Sebastian Rühl
Hi, I integrated the MutabilityDetector into a test: https://github.com/apache/incubator-plc4x/commit/47ff4f0d1c29142c7cb306b159bc5fa24ae8e658 With this we have a working unit test to track the state of

PlcRequestContainer moved to driver-bases

2018-08-16 Thread Sebastian Rühl
Hi, I resolved an outstanding todo and moved PlcRequestContainer to driver-bases. https://github.com/apache/incubator-plc4x/commit/73a3f42b15b085b667041edd6fa2e01fe41efbd6 So if you have open branches et

Re: [S7] Finding out what type of S7 we are talking too (Was: Re: [DISCUSS] Change the format of the S7 Adresses)

2018-08-16 Thread Julian Feinauer
Hi Chris, I would really love to help you with this but my understanding of the S7 communication is too bad for this. And as a side note... Moka7 is the main reason we are now switching to PLC4J... : > Julian Am 16.08.18, 10:19 schrieb "Christofer Dutz" : Hi Julian, Jeah ... Mo

[S7] Finding out what type of S7 we are talking too (Was: Re: [DISCUSS] Change the format of the S7 Adresses)

2018-08-16 Thread Christofer Dutz
Hi Julian, Jeah ... Moka7 ... that was the code I usually mention when I talk about old driver NOT being able to run safely on multi-core machines ;-) Also I wouldn't like to "borrow" code from that project, as it's GPL. But I think I know how I could setup a testcase that might be able to pull

Re: [DISCUSS] Change the format of the S7 Adresses

2018-08-16 Thread Julian Feinauer
Hey Chris, thanks for your reply. Unfortunately I cannot help you with gathering the types based on the protocol messages (we also have only one type here so reverse engineering is kind of... difficould). But what I "know" is how to read it from the SPS via request (we could send this request d