Re: Kafka Connect Integration

2018-08-23 Thread Sagar
Hi Chirstofer, Thanks for the detailed responses. I would like to ask a couple of more questions(which may be borderline naive or stupid :D ). First thing that I would like to know- ignore my lack of knowledge on PLCs- but from what I understand are devices which are small devices used to execute

Re: Internal Type System

2018-08-23 Thread Julian Feinauer
Hey Chris, yes, this is definitive more complex then what I intended to do. What I can suggest is that I prepare a PR for the following changes 1) Renaming Address to Query 2) Refactoring of S7 Driver to add 1) The new Parser 2) A "rich" S7Query which contains the S7Type a

Re: Internal Type System

2018-08-23 Thread Christofer Dutz
Hi Julian, Well we have one request, but this can contain multiple items each item has a "query/address/statement" to define WHAT should be read. So we definitely need the items or we would have to fire 1000 requests in order to read 1000 values. And regarding the "Field" name ... the thing is

Re: Internal Type System

2018-08-23 Thread Julian Feinauer
Hi Sebastian, as we also need this feature for an use case I am willing to implement this ASAP but I want to make sure how to do it properly to avoid long conceptual discussions when a PR is available. Julian Am 23.08.18, 15:53 schrieb "Sebastian Rühl" : Hi Together,

Re: Internal Type System

2018-08-23 Thread Sebastian Rühl
Hi Together, JUST FYI: Having worked on ADS (payload was an open topic) today I ran into the same problems like you with the S7. So to make it work properly the driver here also would require the proposed changes on „Address“. So all in all we should start soon implementing the changes. Sebast

Re: Internal Type System

2018-08-23 Thread Julian Feinauer
Hi Chris, (and Sebastian implicitly) thank you for your response and your suggestions. I agree with all your points and I have the impression that our ideas converge more and more. First, I thank you for your review and this is not intended as productive code was a vehicle for me to test

Re: [EtherNet/IP] Anyone with experience in using EtherNet/IP available here on the list?

2018-08-23 Thread Greg Trasuk
Hi Chris: I will take a look at the code etc. I looked in the Ethernet/IP and CIP specs and didn’t see any obvious standard for a literal form of address expressions. Unfortunately I’m a little time-limited and won’t be able to look deeply until this evening (Toronto time). Cheers, Greg Tras

Re: Internal Type System

2018-08-23 Thread Christofer Dutz
Hi all, I was just discussing things here with Sebastian, as he was just sitting next to me. Now I'm writing down what we were talking about. There were multiple things we both not that happy with and here's our proposal: 1) Rename Address to Query (Naming could be discussed) 2) Adding Type and