Re: AutoCloseable for Reader / Writer

2018-09-11 Thread Christofer Dutz
No objections :-) Outlook for Android herunterladen From: Julian Feinauer Sent: Tuesday, September 11, 2018 8:57:26 PM To: dev@plc4x.apache.org Subject: AutoCloseable for Reader / Writer Hey Everybody, we just head the short notice about

AutoCloseable for Reader / Writer

2018-09-11 Thread Julian Feinauer
Hey Everybody, we just head the short notice about the „Connection Pool“ earlier today and one thing I wanted to ask with regards to Chris refactoring is, if there is a reason behind the fact that PlcConnection is AutoCloseable but Reader and Writer are not. Should they have a lifecycle which

Re: Kafka Connect Integration

2018-09-11 Thread Sagar
@Andrey, Had a quick question regarding the Source Connector for Kafka connect. I see that the awaitFetch() method have been created with a synchronized block within which we are just checking if a particular boolean flag has been set to true to or not. Considering it's just this and not any

AW: Feature prospect of project plc4x

2018-09-11 Thread Uschold Andreas
Hi Chris and Julian, I'm glad to hear that pooling and caching are not out of scope. This topic is pretty complex and one of our most disruptive obstacles. Regarding fragmentation of too big ReadRequests I didn't dig too deep through the source. Instead I did some simple test, just reading the

[GitHub] asfgit closed pull request #19: Add URL Field to Key Schema in Kafka Source Connector

2018-09-11 Thread GitBox
asfgit closed pull request #19: Add URL Field to Key Schema in Kafka Source Connector URL: https://github.com/apache/incubator-plc4x/pull/19 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

Re: Feature prospect of project plc4x

2018-09-11 Thread Julian Feinauer
Hey, this is also what I thought about, but I would suggest to use a syntax like Apache Calcite uses it fort he jdbc connecton [1]: s7://10.10.64.20/1/1;symbolicAddressFile=/some/path/to/a/file;.. Julian [1] https://calcite.apache.org/avatica/docs/client_reference.html Am 11.09.18,

Re: Feature prospect of project plc4x

2018-09-11 Thread Julian Feinauer
Hi Andreas, a warm welcome also from my side! Regarding your second aspect, I agree with chris and the interface where one could integrate arbitrary complex logic. Regarding your first aspect, I am not sure what you mean with the "hierarchical" interface. I mean, it is surely possible to

Re: Feature prospect of project plc4x

2018-09-11 Thread Christofer Dutz
Hi Andreas, first of all welcome here :-) It makes me very happy to hear that you are thinking about eventually joining forces. We can definitely use every helping hand and gladly welcome new contributors. Regarding the two aspects: I initially defined the PlcLister interface as I thought it

Feature prospect of project plc4x

2018-09-11 Thread Uschold Andreas
Hi all, In early 2017 we started the development of a Java based visualization / SCADA in the context of ware houses and logistic centers. One design goal was (and still is) to be able to use the system in a transparent way with any kind of data source, not only PLCs, but also network

[GitHub] asfgit closed pull request #18: Add support for multiple tasks in kafka sink connector

2018-09-11 Thread GitBox
asfgit closed pull request #18: Add support for multiple tasks in kafka sink connector URL: https://github.com/apache/incubator-plc4x/pull/18 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] skorikov opened a new pull request #18: Add support for multiple tasks in kafka sink connector

2018-09-11 Thread GitBox
skorikov opened a new pull request #18: Add support for multiple tasks in kafka sink connector URL: https://github.com/apache/incubator-plc4x/pull/18 This is an automated message from the Apache Git Service. To respond to

[GitHub] asfgit closed pull request #17: Add support for multiple queries in kafka source connector

2018-09-11 Thread GitBox
asfgit closed pull request #17: Add support for multiple queries in kafka source connector URL: https://github.com/apache/incubator-plc4x/pull/17 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: