Hi Chris,
I agree. As for now, the PR is already quite large and I would not like
to let it grow further.
A metadata object returned by some operation on PlcConnection (for
example getMetadata() or getCapabilities()) would bundle all the
operations for obtaining information about the connect
Hi all,
just wanted to take the opportunity to keep you updated on what I’m currently
working on as I do realize that the amount of commits from my side has dropped
… but it’s been some extremely busy time.
To be even clearer, I haven’t seen my office for more than 3 weeks now.
So besides two c
Those were only used by Sebastian's ADS driver.
Perhaps let him explain them as I never quite managed to wrap my head around
their necessity.
For me they were also sort of evil as they allow to explicitly send out
proprietary stuff, which I liked to prevent.
Chris
Am 07.10.18, 15:35 schrieb
Hi Julian,
I agree that we should merge things asap ... just because something is merged,
doesn't mean we can't fine-tune it after that.
I did have a look at the changes and I think it's safe to continue down that
path.
Also I like the idea of getting rid of the Optional ... it was annoying me
Hello all,
currently there are three interfaces in the
org.apache.plc4x.java.api.messages package of the API module, which are
disconnected from the rest of the API:
- PlcProprietaryRequest
- PlcProprietaryResponse
- PlcProtocolMessage
How are these types supposed to be used? As far as I und
Hey all,
one more question.
Do we do the suggested changes in Andreys PR Branch or do we do it separately.
Then, we should try to merge this branch ASAP to have it there and to avoid
merge hell (see https://media.giphy.com/media/cFkiFMDg3iFoI/giphy.gif).
Personally, I feel unable to do a Code Re