plc4j in osgi env

2020-08-24 Thread 刘存杰
Hello all together I developed a small application and run in OSGi Env. with plc4j modbus driver 0.7.0, I try to do sth list below 1、I package all dependencies into a fat jar, and exception "Unable to find driver for protocol modbus", driver not registed 2、 i try PlcConnection plcConnection =

Re: Leaking nioEventLoopGroup threads

2020-08-24 Thread Adam Rossi
Julian, thank you so much for your attention on this. Your code changes look good but unfortunately I am still experiencing the problem. Here is some log output from my program. You can see that the close is called on the DefaultNettyPlcConnection, but I do not see the output from your code

Re: Leaking nioEventLoopGroup threads

2020-08-24 Thread Stefano Bossi
Yes thanks ! This will be very important for my stability test too! Let's see if Adam confirm the patch ! Thanks, Stefano On 24/08/2020 11:35, Christofer Dutz wrote: > Thanks Julian for that quick fix. > > Chris > > > Am 24.08.20, 10:39 schrieb "Julian Feinauer" : > > Hi, > > short

Re: Leaking nioEventLoopGroup threads

2020-08-24 Thread Christofer Dutz
Thanks Julian for that quick fix. Chris Am 24.08.20, 10:39 schrieb "Julian Feinauer" : Hi, short feedback. I looked into the code and indeed it seems that we had a bug there which could lead tot he socket leak you described. I pushed a fix in the branch:

Re: Leaking nioEventLoopGroup threads

2020-08-24 Thread Julian Feinauer
Hi, short feedback. I looked into the code and indeed it seems that we had a bug there which could lead tot he socket leak you described. I pushed a fix in the branch: https://github.com/apache/plc4x/tree/bugfix/close-eventloop-after-channel Would you mind taking a look and testing this with

Re: Leaking nioEventLoopGroup threads

2020-08-24 Thread Julian Feinauer
Perhaps, some related questions: - You are using Linux for your Tests? - Do you close all Connections properly? Normally the `PlcConnection.close()` method should close the EventLoop. Julian Am 24.08.20, 08:23 schrieb "Julian Feinauer" : Hi Adam, I will have a look today! Do we

Re: Leaking nioEventLoopGroup threads

2020-08-24 Thread Julian Feinauer
Hi Adam, I will have a look today! Do we have a Jira Issue for it already? Julian Am 24.08.20, 07:38 schrieb "Christofer Dutz" : Hi Adam, of course that's unfortunate ... also I will not be able to address this issue soon as I have to work on the tasks of my research project. I