[GitHub] [plc4x] hutcheb closed pull request #300: Bug/plc4x-330
hutcheb closed pull request #300: Bug/plc4x-330 URL: https://github.com/apache/plc4x/pull/300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] hutcheb commented on pull request #300: Bug/plc4x-330
hutcheb commented on PR #300: URL: https://github.com/apache/plc4x/pull/300#issuecomment-1092057077 Looking at it, there's still a test disabled for OPCUA, which I believe is the cause for the issue in PLC4X-330 ` public void multipleThreads()` However this PR is a failed attempt to fix the jira issue, by changing the port number of the test opc ua server. I'll delete this PR, but are you still having issues on your mac with this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] hutcheb closed pull request #237: Fix/modbus string
hutcheb closed pull request #237: Fix/modbus string URL: https://github.com/apache/plc4x/pull/237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] hutcheb closed pull request #266: Feature/modbusrtu
hutcheb closed pull request #266: Feature/modbusrtu URL: https://github.com/apache/plc4x/pull/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [DISCUSS] Long running branches
+1 I think it is about time to clean up and bringing most of the things to develop branch . Therefore we have the sandbox . Of course if there is something breaking the existing stuff in Java, Go or C we may open a branch. but most of the branches seem to be not in use anymore and it es getting really hard to getting the old branches back to "develop" branch. Am Do., 7. Apr. 2022 um 13:34 Uhr schrieb Sebastian Rühl : > I agree. It's fine developing new features on develop as long as they are > not breaking the build or have a regression. So in case of plc4py this is > completely fine as this is a T-0 implementation. > > - Sebastian > > On 2022/04/07 11:08:36 Christofer Dutz wrote: > > Hi all, > > > > We have an always growing number of branches where things have been > begun, but never finished (Or at least never been taken back to develop) > > Now some of the branches are so old, that rebasing them is not really > possible anymore. > > > > Could you please have a look at the branches you created, if they are > still valid, please update/rebase them. If they are obsolete, delete them. > If they contain things develop needs, please port them to develop. > > > > Especially for the PLC4Py work, I would feel more comfortable with this > development being done on "develop" (Similar to PLC4Net) ... only this way > do we have it on our radar when working on things. I don't want to waste > your time and effort. I do think that people understand that the different > parts of PLC4X have different maturities and having a not yet fully > functional PLC4Py is nothing to be ashamed of. > > > > What do you folks think? > > > > Chris > > >
[GitHub] [plc4x] ottobackwards commented on pull request #341: Feature/plc4py bh1
ottobackwards commented on PR #341: URL: https://github.com/apache/plc4x/pull/341#issuecomment-1091634460 I don't think you have to register them manually, I think that they can register themselves using the setuptools / setup config. So, if we start out with 1 plc4py whl file, it's setup can register all the distributed drivers like. https://pluggy.readthedocs.io/en/stable/#loading-setuptools-entry-points -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [DISCUSS] Long running branches
I agree. It's fine developing new features on develop as long as they are not breaking the build or have a regression. So in case of plc4py this is completely fine as this is a T-0 implementation. - Sebastian On 2022/04/07 11:08:36 Christofer Dutz wrote: > Hi all, > > We have an always growing number of branches where things have been begun, > but never finished (Or at least never been taken back to develop) > Now some of the branches are so old, that rebasing them is not really > possible anymore. > > Could you please have a look at the branches you created, if they are still > valid, please update/rebase them. If they are obsolete, delete them. If they > contain things develop needs, please port them to develop. > > Especially for the PLC4Py work, I would feel more comfortable with this > development being done on "develop" (Similar to PLC4Net) ... only this way do > we have it on our radar when working on things. I don't want to waste your > time and effort. I do think that people understand that the different parts > of PLC4X have different maturities and having a not yet fully functional > PLC4Py is nothing to be ashamed of. > > What do you folks think? > > Chris >
[DISCUSS] Long running branches
Hi all, We have an always growing number of branches where things have been begun, but never finished (Or at least never been taken back to develop) Now some of the branches are so old, that rebasing them is not really possible anymore. Could you please have a look at the branches you created, if they are still valid, please update/rebase them. If they are obsolete, delete them. If they contain things develop needs, please port them to develop. Especially for the PLC4Py work, I would feel more comfortable with this development being done on "develop" (Similar to PLC4Net) ... only this way do we have it on our radar when working on things. I don't want to waste your time and effort. I do think that people understand that the different parts of PLC4X have different maturities and having a not yet fully functional PLC4Py is nothing to be ashamed of. What do you folks think? Chris
[GitHub] [plc4x] chrisdutz commented on pull request #237: Fix/modbus string
chrisdutz commented on PR #237: URL: https://github.com/apache/plc4x/pull/237#issuecomment-1091594296 @hutcheb Is this branch still valid? If yes, we would need to rebase it and port the changes back . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on pull request #266: Feature/modbusrtu
chrisdutz commented on PR #266: URL: https://github.com/apache/plc4x/pull/266#issuecomment-1091593343 @hutcheb ... can this PR be closed and the corresponding branch be deleted? I think develop now has a working RTU driver ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #339: Fix casting to byte for integer greater than 127 (byte is signed numb…
sruehl merged PR #339: URL: https://github.com/apache/plc4x/pull/339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on pull request #340: build(deps): bump dependency-check-maven from 6.5.1 to 7.0.4
sruehl commented on PR #340: URL: https://github.com/apache/plc4x/pull/340#issuecomment-1091575673 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0
sruehl commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1091575142 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #337: build(deps): bump spring-boot.version from 2.6.2 to 2.6.4
sruehl merged PR #337: URL: https://github.com/apache/plc4x/pull/337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #342: build(deps): bump slf4j.version from 1.7.32 to 1.7.36
sruehl merged PR #342: URL: https://github.com/apache/plc4x/pull/342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Scraper and Connection Pool info
Hi, for a plant here in Italy I'm porting a gateway written in .NET to PLC4x to start using it. After some tests in the office I have some questions about it. In the previous project I used QUARTZ scheduler to have the read requests from the different machines in the field on the same TIMESTAMP and at a fixed time on the machine clock. (e.g. 08:00:00, 08:01:00, 08:02:00 ... ) Is it possible to use the Scraper tool to reach the same goal? Also, can you suggest me some reference projects (repository/articles/documentation) to use as templates for connection management in case of loss and reconnection (e.g. using connection pool)? Thanks Nicolò
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #342: build(deps): bump slf4j.version from 1.7.32 to 1.7.36
dependabot[bot] opened a new pull request, #342: URL: https://github.com/apache/plc4x/pull/342 Bumps `slf4j.version` from 1.7.32 to 1.7.36. Updates `slf4j-api` from 1.7.32 to 1.7.36 Commits https://github.com/qos-ch/slf4j/commit/e9ee55cca93c2bf26f14482a9bdf961c750d2a56;>e9ee55c update timestamp before release https://github.com/qos-ch/slf4j/commit/3b6a92f66815605ce851671dd1d6e0758c29ed4c;>3b6a92f reproducible builds https://github.com/qos-ch/slf4j/commit/882502706063b460997a3c6018223018f36cecd3;>8825027 prepare release 1.7.36, fix SLF4J-541 https://github.com/qos-ch/slf4j/commit/561738747da5813b8a9d2e2ebd10f0128a78a960;>5617387 add relase.sh https://github.com/qos-ch/slf4j/commit/02860b67ef7ff39fa9c7d98fd00da2ee913faeda;>02860b6 prepare relase 1.7.35 https://github.com/qos-ch/slf4j/commit/a622f5186a57188dab7f71651245eb91c6ac263b;>a622f51 fix maven deploy issues https://github.com/qos-ch/slf4j/commit/26068bd4bf93fcbd00185ad986dc43b79aceeb4a;>26068bd slf4j no longer references log4j https://github.com/qos-ch/slf4j/commit/0a21ee1ac1daa2d8e077bec68815421dd7a7a54a;>0a21ee1 replace references to slf4j-log4j12 https://github.com/qos-ch/slf4j/commit/51b6d20b71de75f69ee68167afbf4073c1be7c31;>51b6d20 prepare release 1.7.34 https://github.com/qos-ch/slf4j/commit/d22943faedd5da8d0321cf60437796fb53618481;>d22943f relocate slf4j-log4j12 as slf4j-reload4j Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.36;>compare view Updates `slf4j-simple` from 1.7.32 to 1.7.36 Commits https://github.com/qos-ch/slf4j/commit/e9ee55cca93c2bf26f14482a9bdf961c750d2a56;>e9ee55c update timestamp before release https://github.com/qos-ch/slf4j/commit/3b6a92f66815605ce851671dd1d6e0758c29ed4c;>3b6a92f reproducible builds https://github.com/qos-ch/slf4j/commit/882502706063b460997a3c6018223018f36cecd3;>8825027 prepare release 1.7.36, fix SLF4J-541 https://github.com/qos-ch/slf4j/commit/561738747da5813b8a9d2e2ebd10f0128a78a960;>5617387 add relase.sh https://github.com/qos-ch/slf4j/commit/02860b67ef7ff39fa9c7d98fd00da2ee913faeda;>02860b6 prepare relase 1.7.35 https://github.com/qos-ch/slf4j/commit/a622f5186a57188dab7f71651245eb91c6ac263b;>a622f51 fix maven deploy issues https://github.com/qos-ch/slf4j/commit/26068bd4bf93fcbd00185ad986dc43b79aceeb4a;>26068bd slf4j no longer references log4j https://github.com/qos-ch/slf4j/commit/0a21ee1ac1daa2d8e077bec68815421dd7a7a54a;>0a21ee1 replace references to slf4j-log4j12 https://github.com/qos-ch/slf4j/commit/51b6d20b71de75f69ee68167afbf4073c1be7c31;>51b6d20 prepare release 1.7.34 https://github.com/qos-ch/slf4j/commit/d22943faedd5da8d0321cf60437796fb53618481;>d22943f relocate slf4j-log4j12 as slf4j-reload4j Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.36;>compare view Updates `log4j-over-slf4j` from 1.7.32 to 1.7.36 Commits https://github.com/qos-ch/slf4j/commit/e9ee55cca93c2bf26f14482a9bdf961c750d2a56;>e9ee55c update timestamp before release https://github.com/qos-ch/slf4j/commit/3b6a92f66815605ce851671dd1d6e0758c29ed4c;>3b6a92f reproducible builds https://github.com/qos-ch/slf4j/commit/882502706063b460997a3c6018223018f36cecd3;>8825027 prepare release 1.7.36, fix SLF4J-541 https://github.com/qos-ch/slf4j/commit/561738747da5813b8a9d2e2ebd10f0128a78a960;>5617387 add relase.sh https://github.com/qos-ch/slf4j/commit/02860b67ef7ff39fa9c7d98fd00da2ee913faeda;>02860b6 prepare relase 1.7.35 https://github.com/qos-ch/slf4j/commit/a622f5186a57188dab7f71651245eb91c6ac263b;>a622f51 fix maven deploy issues https://github.com/qos-ch/slf4j/commit/26068bd4bf93fcbd00185ad986dc43b79aceeb4a;>26068bd slf4j no longer references log4j https://github.com/qos-ch/slf4j/commit/0a21ee1ac1daa2d8e077bec68815421dd7a7a54a;>0a21ee1 replace references to slf4j-log4j12 https://github.com/qos-ch/slf4j/commit/51b6d20b71de75f69ee68167afbf4073c1be7c31;>51b6d20 prepare release 1.7.34 https://github.com/qos-ch/slf4j/commit/d22943faedd5da8d0321cf60437796fb53618481;>d22943f relocate slf4j-log4j12 as slf4j-reload4j Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.36;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge`
