foxpluto opened a new pull request #183:
URL: https://github.com/apache/plc4x/pull/183
HI,
I have added a little description of how to use the compiled library with
Gradle.
Regards,
S.
This is an
ottlukas merged pull request #183:
URL: https://github.com/apache/plc4x/pull/183
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
niclash commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-690872320
I have also seen 32-bit integers. Maybe it should be available too.
This is an automated message from the Apache
hutcheb commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-691032464
Hi Niclas,
The plan is to add support for as many IEC 61131 data types as possible.
I've added DINT as an example for what it would take to add additional data
types but
hutcheb opened a new pull request #186:
URL: https://github.com/apache/plc4x/pull/186
Add support for BOOL, INT, UINT and REAL data types for the Modbus protocol.
address string can now include any of these types such as:-
holding-register:10:REAL[10], extended-register:10:UINT[10].
splatch merged pull request #185:
URL: https://github.com/apache/plc4x/pull/185
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hutcheb commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-691032464
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
hutcheb commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-691032464
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
niclash commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-690872320
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
niclash commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-690872320
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chrisdutz commented on a change in pull request #186:
URL: https://github.com/apache/plc4x/pull/186#discussion_r487711822
##
File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcDINT.java
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation
chrisdutz commented on pull request #187:
URL: https://github.com/apache/plc4x/pull/187#issuecomment-691908870
As I have almost no Python skills, I'm not sure my review would be worth
much ...
This is an automated message
ottlukas merged pull request #187:
URL: https://github.com/apache/plc4x/pull/187
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hutcheb opened a new pull request #184:
URL: https://github.com/apache/plc4x/pull/184
Updated the Modbus documentation including references to the starting
addresses and extended registers.
I have also included the headers used in the S7 protocol documentation to
help keep it a bit
splatch commented on pull request #182:
URL: https://github.com/apache/plc4x/pull/182#issuecomment-684965544
Good spot on naming, I did a blind change trying to keep it close to initial
names. Anyhow, thanks for taking care of this!
chrisdutz commented on a change in pull request #170:
URL: https://github.com/apache/plc4x/pull/170#discussion_r481211814
##
File path:
plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
##
@@ -299,6 +319,14 @@ public void
chrisdutz commented on pull request #182:
URL: https://github.com/apache/plc4x/pull/182#issuecomment-684905262
Just saw that due to the nature of C ... you found all the places that
needed adjusting ... thank you very much :-)
chrisdutz edited a comment on pull request #67:
URL: https://github.com/apache/plc4x/pull/67#issuecomment-684925891
Guess it doesn't harm adding this example ... perhaps it helps someone ...
however I am not sure if we would need an ICLA on file for this contribution.
chrisdutz commented on pull request #178:
URL: https://github.com/apache/plc4x/pull/178#issuecomment-684920366
Hi Johanna,
sorry for me picking this up so late ... I just had a look ... your code
changes generally look good, and I'm not going to insist on tests as in that
case I
chrisdutz commented on pull request #67:
URL: https://github.com/apache/plc4x/pull/67#issuecomment-684925891
Guess it doesn't harm adding this example ... perhaps it helps someone ...
This is an automated message from the
chrisdutz commented on pull request #182:
URL: https://github.com/apache/plc4x/pull/182#issuecomment-684899684
I will probably need to add something to the size-calculation in C too, but
I'll take care of this. Perhaps also change the name of the varialbe from
"needsPadding" to
chrisdutz merged pull request #182:
URL: https://github.com/apache/plc4x/pull/182
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chrisdutz commented on pull request #170:
URL: https://github.com/apache/plc4x/pull/170#issuecomment-684924829
So right now I think we could probably add a test ... I do not want to force
Julian to dig into my IT framework ... if you could explain the situation in
which this code would
ottobackwards opened a new pull request #187:
URL: https://github.com/apache/plc4x/pull/187
Created simple shell implementation for PlcManager, PlcConnection, and a
test that shows some mocking and tests context manager functionality
hutcheb opened a new pull request #193:
URL: https://github.com/apache/plc4x/pull/193
This allows us to pass an array of values to the hello world write example.
The format is
--field-addresses 04:BOOL[2] --field-values [true,true]
--field-addresses 44:LINT[2]
splatch opened a new pull request #195:
URL: https://github.com/apache/plc4x/pull/195
Given that I need to park this one for a moment and I managed to test and
collect extra data for TC3 as well as extra sample for TC2 further work can
continue on develop branch.
Discovery is based on
hutcheb commented on a change in pull request #192:
URL: https://github.com/apache/plc4x/pull/192#discussion_r500131203
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcValues.java
##
@@ -355,6 +356,28 @@ public static PlcValue of(Map map) {
hutcheb commented on a change in pull request #192:
URL: https://github.com/apache/plc4x/pull/192#discussion_r500139132
##
File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBYTE.java
##
@@ -169,6 +169,30 @@ public PlcBYTE(@JsonProperty("value") short value)
hutcheb commented on a change in pull request #192:
URL: https://github.com/apache/plc4x/pull/192#discussion_r500144795
##
File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBYTE.java
##
@@ -181,6 +205,90 @@ public short getShort() {
return value;
chrisdutz commented on a change in pull request #192:
URL: https://github.com/apache/plc4x/pull/192#discussion_r500057457
##
File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBYTE.java
##
@@ -169,6 +169,30 @@ public PlcBYTE(@JsonProperty("value") short
hutcheb commented on a change in pull request #192:
URL: https://github.com/apache/plc4x/pull/192#discussion_r500123620
##
File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBYTE.java
##
@@ -169,6 +169,30 @@ public PlcBYTE(@JsonProperty("value") short value)
hutcheb commented on pull request #192:
URL: https://github.com/apache/plc4x/pull/192#issuecomment-703242394
Bit of a mismatch of a bunch of issues:-
- Implemented WriteBuffer - Big Integer and floating point functions.
- Implemented staticserialzer support for PlcLists
- Moved
hutcheb commented on pull request #194:
URL: https://github.com/apache/plc4x/pull/194#issuecomment-707077234
It is definitely usable but somethings to improve on:-
- Security isn't implemented.
- Arrays should probably be a list of nodes in OPCUA instead of a single one.
-
chrisdutz merged pull request #192:
URL: https://github.com/apache/plc4x/pull/192
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hutcheb merged pull request #194:
URL: https://github.com/apache/plc4x/pull/194
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
splatch merged pull request #195:
URL: https://github.com/apache/plc4x/pull/195
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hutcheb opened a new pull request #194:
URL: https://github.com/apache/plc4x/pull/194
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chrisdutz opened a new pull request #181:
URL: https://github.com/apache/plc4x/pull/181
Working on implementing the S7 and the Modbus driver using the generated
code.
This is an automated message from the Apache Git
splatch opened a new pull request #182:
URL: https://github.com/apache/plc4x/pull/182
Padding expression must now evaluate to an integer specifying how many times
'padding' field needs to be read or written to the buffer.
S7 parser tests are fine with this change as well as my
ottobackwards merged pull request #180:
URL: https://github.com/apache/plc4x/pull/180
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ottobackwards merged pull request #179:
URL: https://github.com/apache/plc4x/pull/179
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ottobackwards commented on pull request #180:
URL: https://github.com/apache/plc4x/pull/180#issuecomment-677762209
@vemmert -
This is an automated message from the Apache Git Service.
To respond to the message, please
ottobackwards opened a new pull request #180:
URL: https://github.com/apache/plc4x/pull/180
black, mypy and pre-commit. pre-commit is added as a dev dependency in poetry
To enable these hooks ->
- pip install pre-commit
- pre-commit install
Please see
chrisdutz commented on pull request #108:
URL: https://github.com/apache/plc4x/pull/108#issuecomment-700598552
I guess Cesar is currently consumed with other work topics ... if this is a
high priority requirement for you and your company you could consider
contracting someone of the
mahendra-korat commented on pull request #108:
URL: https://github.com/apache/plc4x/pull/108#issuecomment-700594490
Any progress on this? I need to start trials with my PLCs.
This is an automated message from the Apache Git
glcj commented on pull request #108:
URL: https://github.com/apache/plc4x/pull/108#issuecomment-700748393
Hello,
The features noted are functional in version 0.6.1 (actually the "s7alarm"
branch).
The software is tested for S7-300 & S7-400.
S7-1500 and S7-1200
hutcheb opened a new pull request #192:
URL: https://github.com/apache/plc4x/pull/192
First attempt at refactoring the field handler class, currently
troubleshooting issue with new PlcValue of method.
This is an automated
hutcheb opened a new pull request #191:
URL: https://github.com/apache/plc4x/pull/191
Initial commit, hasn't been tested at all.
This is an automated message from the Apache Git Service.
To respond to the message, please log
ottlukas merged pull request #189:
URL: https://github.com/apache/plc4x/pull/189
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chrisdutz commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-695931480
Hi Ben,
will do so asap …
Chris
Von: hutcheb
Antworten an: apache/plc4x
Datum: Samstag, 19. September 2020 um 13:30
An: apache/plc4x
Cc:
anup-km commented on pull request #36:
URL: https://github.com/apache/plc4x/pull/36#issuecomment-695914069
Hi @JulianFeinauer , I got some PLC4X connection error while running .jar
file in command prompt, but when I run the same source code on the IntelliJ
environment its getting
hutcheb commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-696058599
Hi,
I was looking at starting to use the staticSerialize method for Modbus as it
would reduce the fromPLCValue method. However there are a few methods in the
WriteBuffer
anup-km commented on pull request #36:
URL: https://github.com/apache/plc4x/pull/36#issuecomment-698079911
> Hi @JulianFeinauer , I got some PLC4X connection error while running .jar
file in command prompt, but when I run the same source code on the IntelliJ
environment its getting
hutcheb commented on a change in pull request #191:
URL: https://github.com/apache/plc4x/pull/191#discussion_r494920825
##
File path:
plc4j/drivers/knxnetip/src/main/java/org/apache/plc4x/java/knxnetip/utils/KnxHelper.java
##
@@ -46,9 +46,16 @@ public static void
chrisdutz commented on a change in pull request #191:
URL: https://github.com/apache/plc4x/pull/191#discussion_r494808810
##
File path:
plc4j/drivers/knxnetip/src/main/java/org/apache/plc4x/java/knxnetip/utils/KnxHelper.java
##
@@ -46,9 +46,16 @@ public static void
chrisdutz commented on pull request #4:
URL: https://github.com/apache/plc4x-build-tools/pull/4#issuecomment-698776318
But I just noticed ... this is only in the build tools in the site testsuite
... this will never find it's way into the main website ...
chrisdutz commented on pull request #4:
URL: https://github.com/apache/plc4x-build-tools/pull/4#issuecomment-698775703
Thanks for this :-) Highly appreciated :-)
This is an automated message from the Apache Git Service.
To
chrisdutz merged pull request #4:
URL: https://github.com/apache/plc4x-build-tools/pull/4
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
anup-km commented on pull request #36:
URL: https://github.com/apache/plc4x/pull/36#issuecomment-698079911
> Hi @JulianFeinauer , I got some PLC4X connection error while running .jar
file in command prompt, but when I run the same source code on the IntelliJ
environment its getting
hutcheb commented on a change in pull request #191:
URL: https://github.com/apache/plc4x/pull/191#discussion_r494920825
##
File path:
plc4j/drivers/knxnetip/src/main/java/org/apache/plc4x/java/knxnetip/utils/KnxHelper.java
##
@@ -46,9 +46,16 @@ public static void
chrisdutz merged pull request #4:
URL: https://github.com/apache/plc4x-build-tools/pull/4
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chrisdutz commented on pull request #4:
URL: https://github.com/apache/plc4x-build-tools/pull/4#issuecomment-698775703
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chrisdutz commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-698989556
The PR #190 now contains all changes of this PR.
This is an automated message from the Apache Git Service.
To
chrisdutz closed pull request #186:
URL: https://github.com/apache/plc4x/pull/186
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
asfgit merged pull request #190:
URL: https://github.com/apache/plc4x/pull/190
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chrisdutz merged pull request #188:
URL: https://github.com/apache/plc4x/pull/188
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hutcheb opened a new pull request #190:
URL: https://github.com/apache/plc4x/pull/190
Add support for writing extended registers.
This is an automated message from the Apache Git Service.
To respond to the message, please
chrisdutz commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-696964288
Hi Ben ... sorry for the late response ... I'm currently drowning in getting
some stuff finished as well as preparing for ApacheCon next week ... I'll try
to squeeze it in, but
hutcheb commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-696981490
Hi Chris, not a problem take your time. :)
This is an automated message from the Apache Git Service.
To respond
chrisdutz commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-696964288
Hi Ben ... sorry for the late response ... I'm currently drowning in getting
some stuff finished as well as preparing for ApacheCon next week ... I'll try
to squeeze it in, but
hutcheb commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-696981490
Hi Chris, not a problem take your time. :)
This is an automated message from the Apache Git Service.
To respond
hutcheb opened a new pull request #188:
URL: https://github.com/apache/plc4x/pull/188
Documentation for the Modbus Data type PR
This is an automated message from the Apache Git Service.
To respond to the message, please log
chrisdutz commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-694150435
Do you need any help from my side in order to continue? If yes, just reach
out to me.
This is an automated
chrisdutz merged pull request #184:
URL: https://github.com/apache/plc4x/pull/184
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hutcheb commented on pull request #191:
URL: https://github.com/apache/plc4x/pull/191#issuecomment-699621155
Little Endian BigInteger functions havn't been tested.
This is an automated message from the Apache Git Service.
To
hutcheb commented on pull request #192:
URL: https://github.com/apache/plc4x/pull/192#issuecomment-703093701
StaticSerialzer when writing booleans needs some work.
This is an automated message from the Apache Git
hutcheb closed pull request #193:
URL: https://github.com/apache/plc4x/pull/193
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hutcheb closed pull request #191:
URL: https://github.com/apache/plc4x/pull/191
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chrisdutz commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-634811316
So how about if the next letter is uppercase too, treat the current as the
same block.
This is an automated
chrisdutz commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-634810800
Yeah that would indeed shorten some names by 50%
This is an automated message from the Apache Git Service.
To
chrisdutz opened a new pull request #161:
URL: https://github.com/apache/plc4x/pull/161
…) so we can do code reviews on it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nalim2 merged pull request #158:
URL: https://github.com/apache/plc4x/pull/158
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ottobackwards commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-634876265
Yes something like that
This is an automated message from the Apache Git Service.
To respond to the message,
JulianFeinauer commented on pull request #162:
URL: https://github.com/apache/plc4x/pull/162#issuecomment-635229505
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
JulianFeinauer merged pull request #162:
URL: https://github.com/apache/plc4x/pull/162
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chrisdutz opened a new pull request #162:
URL: https://github.com/apache/plc4x/pull/162
Hi folks,
I would like the community to approve this change ...
Chris
This is an automated message from the Apache Git
nalim2 edited a comment on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633525795
Yeah i think to include there a Sample Server should be a good idea. I would
first just integrate a Milo example server and would transfere the ManualTest
class to an
patrickse opened a new pull request #158:
URL: https://github.com/apache/plc4x/pull/158
Eclipse Milo 0.3.7 supports relaxed nonce validation when not using
protected credentials. It's needed to talk to development PLC from Schneider
Electric.
JulianFeinauer commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633479750
Good question, indeed.
This is an automated message from the Apache Git Service.
To respond to the message,
JulianFeinauer edited a comment on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633479750
Good question, indeed. But good to know that it works for you. @nalim2 we
should definetly have a look there. Probably we could start an OPC Server and
start a Client
patrickse commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633479410
I am not aware of any integration test. We've changed the dependency and
deployd it to our platform. It looks ok for now. How could I implement an
integration test?
nalim2 commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633525795
Yeah i think to include there a Sample Server should be a good idea. I would
first just integrate a Milo example server and would transfere the ManualTest
class to an integration
JulianFeinauer commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633477367
Thanks @patrickse ! Do we have integration tests for milo or did you test
the code already?
This is an
nalim2 commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633527174
But just the updated versions lgtm
This is an automated message from the Apache Git Service.
To respond to the
ottobackwards commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-635369565
That looks great!
This is an automated message from the Apache Git Service.
To respond to the message, please
ottobackwards merged pull request #160:
URL: https://github.com/apache/plc4x/pull/160
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chrisdutz merged pull request #159:
URL: https://github.com/apache/plc4x/pull/159
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ottobackwards opened a new pull request #160:
URL: https://github.com/apache/plc4x/pull/160
… fu between all supported versions
This is an automated message from the Apache Git Service.
To respond to the message, please log
chrisdutz merged pull request #161:
URL: https://github.com/apache/plc4x/pull/161
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chrisdutz commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-637527414
;-) ... I am currently replicating what we have in Java and here the
endianess is handled internally. It's handled in the constructor of the buffer.
301 - 400 of 2116 matches
Mail list logo
