ottobackwards commented on PR #755:
URL: https://github.com/apache/plc4x/pull/755#issuecomment-1398554496
Thanks for the contribution!
The issues with expression language for addresses and having multiple
addresses in that property were at the time:
- Putting something complicated
SteinOv closed pull request #715: fix(integrations/camel): Connection now
established in doStart() of Producer/Consumer instead of constructors (#713)
URL: https://github.com/apache/plc4x/pull/715
--
This is an automated message from the Apache Git Service.
To respond to the message, please
SteinOv commented on PR #715:
URL: https://github.com/apache/plc4x/pull/715#issuecomment-1398553471
Yes, agreed. I'll close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sruehl closed pull request #704: build(deps): bump plexus-compiler-eclipse from
2.12.1 to 2.13.0
URL: https://github.com/apache/plc4x/pull/704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sruehl commented on PR #749:
URL: https://github.com/apache/plc4x/pull/749#issuecomment-1398551097
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sruehl commented on PR #715:
URL: https://github.com/apache/plc4x/pull/715#issuecomment-1398542560
@SteinOv & @chrisdutz guess we can close this then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sruehl merged PR #750:
URL: https://github.com/apache/plc4x/pull/750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
sruehl merged PR #753:
URL: https://github.com/apache/plc4x/pull/753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
sruehl merged PR #754:
URL: https://github.com/apache/plc4x/pull/754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
sruehl merged PR #756:
URL: https://github.com/apache/plc4x/pull/756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
ottobackwards merged PR #752:
URL: https://github.com/apache/plc4x/pull/752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] opened a new pull request, #756:
URL: https://github.com/apache/plc4x/pull/756
Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.14.0
to 1.15.0.
Release notes
Sourced from https://github.com/spf13/viper/releases;>github.com/spf13/viper's
QuanticPony opened a new pull request, #755:
URL: https://github.com/apache/plc4x/pull/755
Proposal to add a property in NiFi-integration processors to allow users to
choose address definition strategy and add support for Expression Language in
addresses definition.
## Issues
dependabot[bot] opened a new pull request, #754:
URL: https://github.com/apache/plc4x/pull/754
Bumps [woodstox-core](https://github.com/FasterXML/woodstox) from 6.4.0 to
6.5.0.
Commits
dependabot[bot] opened a new pull request, #753:
URL: https://github.com/apache/plc4x/pull/753
Bumps `javafx.version` from 19 to 19.0.2.
Updates `javafx-base` from 19 to 19.0.2
Updates `javafx-graphics` from 19 to 19.0.2
Updates `javafx-controls` from 19 to 19.0.2
QuanticPony commented on code in PR #752:
URL: https://github.com/apache/plc4x/pull/752#discussion_r1073618937
##
plc4j/integrations/apache-nifi/README.md:
##
@@ -85,29 +85,25 @@ Also, it is important to keep in mind the Processor
Scheduling Configuration. Us
Table of data
ottobackwards commented on code in PR #752:
URL: https://github.com/apache/plc4x/pull/752#discussion_r1073603312
##
plc4j/integrations/apache-nifi/README.md:
##
@@ -85,29 +85,25 @@ Also, it is important to keep in mind the Processor
Scheduling Configuration. Us
Table of
dependabot[bot] commented on PR #748:
URL: https://github.com/apache/plc4x/pull/748#issuecomment-1387146276
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency by
sruehl closed pull request #748: build(deps): bump kotlin.version from 1.7.22
to 1.8.0
URL: https://github.com/apache/plc4x/pull/748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sruehl merged PR #751:
URL: https://github.com/apache/plc4x/pull/751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
QuanticPony opened a new pull request, #752:
URL: https://github.com/apache/plc4x/pull/752
Improvements in type mapping from Plc4x to Avro. Added unit test for record
source processor.
Changes in mapping:
* PlcBYTE: string -> bytes
* PlcLINT:string -> long
* PlcREAL:
dependabot[bot] opened a new pull request, #751:
URL: https://github.com/apache/plc4x/pull/751
Bumps assertj-core from 3.24.1 to 3.24.2.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #750:
URL: https://github.com/apache/plc4x/pull/750
Bumps Saxon-HE from 11.4 to 12.0.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #749:
URL: https://github.com/apache/plc4x/pull/749
Bumps
[maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin)
from 3.1.2 to 3.5.0.
Commits
dependabot[bot] opened a new pull request, #748:
URL: https://github.com/apache/plc4x/pull/748
Bumps `kotlin.version` from 1.7.22 to 1.8.0.
Updates `kotlin-stdlib` from 1.7.22 to 1.8.0
Release notes
Sourced from https://github.com/JetBrains/kotlin/releases;>kotlin-stdlib's
chrisdutz commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072191526
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriverManager.java:
##
@@ -16,17 +16,25 @@
* specific language governing permissions and limitations
* under
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072185474
##
plc4j/examples/hello-ads-telemetry/src/main/resources/logback.xml:
##
@@ -27,7 +27,7 @@
-
+
Review Comment:
Couple of months back I turned them all
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072183895
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriverManager.java:
##
@@ -16,17 +16,25 @@
* specific language governing permissions and limitations
* under the
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072181255
##
plc4j/examples/hello-ads-telemetry/pom.xml:
##
@@ -40,13 +43,31 @@
- org.apache.commons
- commons-pool2
+ org.slf4j
+ slf4j-api
chrisdutz commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072148900
##
plc4j/examples/hello-ads-telemetry/src/main/resources/logback.xml:
##
@@ -27,7 +27,7 @@
-
+
Review Comment:
I'm using the logging to output
chrisdutz commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072146589
##
plc4j/examples/hello-ads-telemetry/pom.xml:
##
@@ -40,13 +43,31 @@
- org.apache.commons
- commons-pool2
+ org.slf4j
+ slf4j-api
chrisdutz commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072144969
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriverManager.java:
##
@@ -16,17 +16,25 @@
* specific language governing permissions and limitations
* under
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072123552
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcConnectionManager.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072121894
##
plc4j/tools/scraper-ng/pom.xml:
##
@@ -0,0 +1,110 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072121595
##
plc4j/tools/scraper/pom.xml:
##
@@ -100,12 +96,6 @@
0.11.0-SNAPSHOT
test
-
- org.apache.plc4x
- plc4j-connection-cache
-
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072121286
##
plc4j/tools/scraper-ng/pom.xml:
##
@@ -0,0 +1,110 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
chrisdutz commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072120717
##
plc4j/drivers/ads/src/main/java/org/apache/plc4x/java/ads/protocol/AdsProtocolLogic.java:
##
@@ -136,11 +136,11 @@ public void onConnect(ConversationContext
context)
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072120527
##
plc4j/tools/connection-cache/src/test/resources/logback-test.xml:
##
@@ -27,7 +27,9 @@
-
+
+
+
Review Comment:
```suggestion
```
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072120180
##
plc4j/tools/connection-cache/src/test/java/org/apache/plc4x/java/utils/cache/CachedPlcConnectionManagerTest.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072118836
##
plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/CachedPlcConnectionManager.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072117311
##
plc4j/examples/hello-ads-telemetry/src/main/resources/logback.xml:
##
@@ -27,7 +27,7 @@
-
+
Review Comment:
```suggestion
```
--
This is
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072116783
##
plc4j/examples/hello-ads-telemetry/pom.xml:
##
@@ -40,13 +43,31 @@
- org.apache.commons
- commons-pool2
+ org.slf4j
+ slf4j-api
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072116126
##
plc4j/drivers/ads/src/main/java/org/apache/plc4x/java/ads/protocol/AdsProtocolLogic.java:
##
@@ -136,11 +136,11 @@ public void onConnect(ConversationContext
context) {
chrisdutz commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072116724
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcConnectionManager.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
chrisdutz commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072116329
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcConnectionManager.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072115260
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriverManager.java:
##
@@ -16,17 +16,25 @@
* specific language governing permissions and limitations
* under the
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072113699
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcConnectionManager.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072112458
##
plc4j/api/src/main/java/org/apache/plc4x/java/DefaultPlcDriverManager.java:
##
@@ -32,19 +34,19 @@
import java.util.ServiceLoader;
import java.util.Set;
-public
sruehl merged PR #745:
URL: https://github.com/apache/plc4x/pull/745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
sruehl merged PR #744:
URL: https://github.com/apache/plc4x/pull/744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
sruehl commented on PR #745:
URL: https://github.com/apache/plc4x/pull/745#issuecomment-1385187601
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sruehl merged PR #746:
URL: https://github.com/apache/plc4x/pull/746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
dependabot[bot] opened a new pull request, #53:
URL: https://github.com/apache/plc4x-build-tools/pull/53
Bumps
[maven-plugin-annotations](https://github.com/apache/maven-plugin-tools) from
3.7.0 to 3.7.1.
Release notes
Sourced from
dependabot[bot] opened a new pull request, #52:
URL: https://github.com/apache/plc4x-build-tools/pull/52
Bumps [maven-plugin-plugin](https://github.com/apache/maven-plugin-tools)
from 3.7.0 to 3.7.1.
Release notes
Sourced from
dependabot[bot] opened a new pull request, #746:
URL: https://github.com/apache/plc4x/pull/746
Bumps `mockito.version` from 4.11.0 to 5.0.0.
Updates `mockito-core` from 4.11.0 to 5.0.0
Release notes
Sourced from https://github.com/mockito/mockito/releases;>mockito-core's
dependabot[bot] opened a new pull request, #745:
URL: https://github.com/apache/plc4x/pull/745
Bumps [netty-bom](https://github.com/netty/netty) from 4.1.86.Final to
4.1.87.Final.
Commits
https://github.com/netty/netty/commit/53fa91f6f644f24bcd085fbeb64bfec01e8fb61e;>53fa91f
dependabot[bot] opened a new pull request, #744:
URL: https://github.com/apache/plc4x/pull/744
Bumps freemarker from 2.3.31 to 2.3.32.
[![Dependabot compatibility
sruehl merged PR #740:
URL: https://github.com/apache/plc4x/pull/740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
sruehl merged PR #741:
URL: https://github.com/apache/plc4x/pull/741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
sruehl merged PR #742:
URL: https://github.com/apache/plc4x/pull/742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
dependabot[bot] opened a new pull request, #741:
URL: https://github.com/apache/plc4x/pull/741
Bumps [byte-buddy](https://github.com/raphw/byte-buddy) from 1.12.21 to
1.12.22.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases;>byte-buddy's
releases.
dependabot[bot] opened a new pull request, #742:
URL: https://github.com/apache/plc4x/pull/742
Bumps
[maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin)
from 3.1.2 to 3.5.0.
Commits
dependabot[bot] opened a new pull request, #740:
URL: https://github.com/apache/plc4x/pull/740
Bumps `xmlunit.version` from 2.9.0 to 2.9.1.
Updates `xmlunit-core` from 2.9.0 to 2.9.1
Release notes
Sourced from https://github.com/xmlunit/xmlunit/releases;>xmlunit-core's
sruehl merged PR #737:
URL: https://github.com/apache/plc4x/pull/737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
sruehl merged PR #739:
URL: https://github.com/apache/plc4x/pull/739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
sruehl merged PR #738:
URL: https://github.com/apache/plc4x/pull/738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
dependabot[bot] opened a new pull request, #739:
URL: https://github.com/apache/plc4x/pull/739
Bumps [maven-surefire-plugin](https://github.com/apache/maven-surefire) from
3.0.0-M7 to 3.0.0-M8.
Commits
dependabot[bot] opened a new pull request, #738:
URL: https://github.com/apache/plc4x/pull/738
Bumps [jakarta.activation-api](https://github.com/jakartaee/jaf-api) from
2.1.0 to 2.1.1.
Commits
dependabot[bot] opened a new pull request, #737:
URL: https://github.com/apache/plc4x/pull/737
Bumps karaf-maven-plugin from 4.4.2 to 4.4.3.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #51:
URL: https://github.com/apache/plc4x-build-tools/pull/51
Bumps
[maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin)
from 3.4.1 to 3.4.2.
Commits
dependabot[bot] opened a new pull request, #50:
URL: https://github.com/apache/plc4x-build-tools/pull/50
Bumps
[maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin)
from 3.4.0 to 3.5.0.
Commits
splatch merged PR #691:
URL: https://github.com/apache/plc4x/pull/691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
sruehl merged PR #729:
URL: https://github.com/apache/plc4x/pull/729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
sruehl merged PR #736:
URL: https://github.com/apache/plc4x/pull/736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
sruehl commented on PR #729:
URL: https://github.com/apache/plc4x/pull/729#issuecomment-1378579443
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sruehl merged PR #735:
URL: https://github.com/apache/plc4x/pull/735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
dependabot[bot] opened a new pull request, #736:
URL: https://github.com/apache/plc4x/pull/736
Bumps [error_prone_annotations](https://github.com/google/error-prone) from
2.17.0 to 2.18.0.
Release notes
Sourced from
dependabot[bot] opened a new pull request, #735:
URL: https://github.com/apache/plc4x/pull/735
Bumps `junit.jupiter.version` from 5.9.1 to 5.9.2.
Updates `junit-jupiter` from 5.9.1 to 5.9.2
Release notes
Sourced from https://github.com/junit-team/junit5/releases;>junit-jupiter's
sruehl merged PR #734:
URL: https://github.com/apache/plc4x/pull/734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
sruehl merged PR #733:
URL: https://github.com/apache/plc4x/pull/733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
chrisdutz commented on PR #545:
URL: https://github.com/apache/plc4x/pull/545#issuecomment-1375345033
Always happy to help educate :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] opened a new pull request, #734:
URL: https://github.com/apache/plc4x/pull/734
Bumps [gson](https://github.com/google/gson) from 2.10 to 2.10.1.
Release notes
Sourced from https://github.com/google/gson/releases;>gson's
releases.
Gson 2.10.1
This is
dependabot[bot] opened a new pull request, #733:
URL: https://github.com/apache/plc4x/pull/733
Bumps assertj-core from 3.24.0 to 3.24.1.
[)
about it, please review it
sruehl merged PR #730:
URL: https://github.com/apache/plc4x/pull/730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
dependabot[bot] opened a new pull request, #730:
URL: https://github.com/apache/plc4x/pull/730
Bumps assertj-core from 3.23.1 to 3.24.0.
[