Re: S7 code

2020-03-02 Thread Julian Feinauer
Thanks! Holen Sie sich Outlook für Android<https://aka.ms/ghei36> From: Strljic, Matthias Milan Sent: Monday, March 2, 2020 3:16:10 PM To: dev@plc4x.apache.org Subject: AW: S7 code Hi Julian, i fixed the issue in the rel/0.6 branch and added the fix

AW: S7 code

2020-03-02 Thread Strljic, Matthias Milan
Stuttgart GERMANY Tel: +49 711 685-84530 Fax: +49 711 685-74530 E-Mail: matthias.strl...@isw.uni-stuttgart.de Web: http://www.isw.uni-stuttgart.de -Ursprüngliche Nachricht- Von: Julian Feinauer Gesendet: Sunday, March 1, 2020 2:59 PM An: dev@plc4x.apache.org Betreff: Re: S7 code Hey

Re: S7 code

2020-03-02 Thread Cesar Garcia
___ > Von: Julian Feinauer > Gesendet: Freitag, 28. Februar 2020 15:43:38 > An: dev@plc4x.apache.org > Betreff: Re: S7 code > > Hi, > > I suggest to go through with RC3 and do the release but if there is a > PR with significant improvements the

Re: S7 code

2020-03-01 Thread Julian Feinauer
Greetings Matthias Von: Julian Feinauer Gesendet: Freitag, 28. Februar 2020 15:43:38 An: dev@plc4x.apache.org Betreff: Re: S7 code Hi, I suggest to go through with RC3 and do the release but if there is a PR with significant improvements then we can just start the

AW: S7 code

2020-02-29 Thread Strljic, Matthias Milan
I would agree on that and also already added a PR for a bug i found during the manual test of this version with OPC UA :) Greetings Matthias Von: Julian Feinauer Gesendet: Freitag, 28. Februar 2020 15:43:38 An: dev@plc4x.apache.org Betreff: Re: S7 code Hi, I

Re: S7 code

2020-02-28 Thread Julian Feinauer
Hi, I suggest to go through with RC3 and do the release but if there is a PR with significant improvements then we can just start the release train again and do a 0.6.1 release short after, why not. We are also still working on improvements so there will be many more 0.6.x releases to come in t

Re: S7 code

2020-02-28 Thread Cesar Garcia
Thanks for the support, I inform you for the incorporation of the code. Weekend for tests, :-) Best regards, El vie., 28 feb. 2020 a las 4:07, Christofer Dutz (< christofer.d...@c-ware.de>) escribió: > H Cesar, > > I have absolutely no objections to applying your PR to the rel/0.6 branch. > I

Re: S7 code

2020-02-28 Thread Christofer Dutz
H Cesar, I have absolutely no objections to applying your PR to the rel/0.6 branch. I think that's actually a good idea. Perhaps even cancelling the RP, rebasing your branch to rel/0.6 and then creating a new PR for that would be the way to go. Really looking forward to helping you port things t

S7 code

2020-02-27 Thread Cesar Garcia
Hi All, At this moment the voting is being carried out for the release of version 0.6.0, which I understand is the latest version that will include the handwritten drivers which will become LTS. The modifications I am making to the S7 driver (LTS), may be included in an upcoming revision, for ex