[Bug 58787] [In progress] Border Drawing utility that does not create unnecessary styles

2016-01-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58787 --- Comment #9 from Mark Murphy --- Perhaps it should be called CellStyleTemplate instead of CellBorder. Then we could have methods that add fills and other CellStyle properties, and then apply them all at once. -- You

[Bug 58787] [In progress] Border Drawing utility that does not create unnecessary styles

2016-01-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58787 --- Comment #8 from Javen O'Neal --- In general, I prefer creating inheritable classes rather than util functions because * behavior can be overridden in an object-oriented way * features are more discoverable through

Re: Format of submitted patches

2016-01-17 Thread David North
On 16/01/16 07:52, Javen O'Neal wrote: > From http://poi.apache.org/guidelines.html#SubmittingPatches > """ > You may create your patch file using either of the following > approaches (the committers recommend the first): > Approach 1 - use Ant > Approach 2 - the manual way > Approach 3 - the git

Re: Format of submitted patches

2016-01-17 Thread David North
On 16/01/16 07:52, Javen O'Neal wrote: > From http://poi.apache.org/guidelines.html#SubmittingPatches > """ > You may create your patch file using either of the following > approaches (the committers recommend the first): > Approach 1 - use Ant > Approach 2 - the manual way > Approach 3 - the git

Re: Format of submitted patches

2016-01-17 Thread Nick Burch
On Sat, 16 Jan 2016, Andreas Beeker wrote: What is the current preference among the POI committers and community? Receiving a patch: I haven't checked how to receive the git pull requests as I'm not having a local POI git repository - so this is currently my least preferred format. In the

[Bug 58877] Cannot get a numeric value from a error formula cell

2016-01-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58877 Nick Burch changed: What|Removed |Added Resolution|--- |INVALID

[Bug 58787] [In progress] Border Drawing utility that does not create unnecessary styles

2016-01-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58787 --- Comment #7 from Mark Murphy --- I created a new object for this named CellBorder because I am working on cell borders. However, I can see this being useful for defining and applying a bunch of fills to a region as