Re: baffling save behavior

2018-02-23 Thread Greg Woolsey
Yes, I thought of a possible approach to a test case tonight while doing the kids' activities transportation. If I have time this weekend I'll give it a stab. On Fri, Feb 23, 2018, 21:48 Dominik Stadler wrote: > Hi, > > Your analysis sounds sensible and changing

Re: baffling save behavior

2018-02-23 Thread Dominik Stadler
Hi, Your analysis sounds sensible and changing onDocumentWrite() looks ok to me as well from a quick look at the code, we would only add an allocation of the array, which is quit performance-wise compared to all the stuff that happens while saving the document. A reproducing test-case would be

[Bug 62129] New: java.lang.ArrayIndexOutOfBoundsException when HWPFDocument read word

2018-02-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62129 Bug ID: 62129 Summary: java.lang.ArrayIndexOutOfBoundsException when HWPFDocument read word Product: POI Version: 3.17-FINAL Hardware: PC Status: NEW

Re: baffling save behavior

2018-02-23 Thread Greg Woolsey
I'm finally able to work around the problem by changing XSSFRow.onDocumentWrite() to always copy the current state of the _cells collection to the _row CArray, instead of only when things don't look like they are ordered. There are several cases I've uncovered where the two groups can be the same

Re: baffling save behavior

2018-02-23 Thread Greg Woolsey
For what it's worth, I'm using a build from last August. The code changes I'm seeing since then are almost entirely about API changes to use Enums and ints and remove deprecated methods. I'm suspicious there are not a lot of use cases where a document is opened, edited, saved, edited again

Re: baffling save behavior

2018-02-23 Thread Alain FAGOT BÉAREZ
Hi, It might have been the same symptoms which have led Sandeep Tiwari to make a code change that I was reluctant to accept in the branch about charts in XWPF. His explanations were in the line of yours. But I couldn't not accept the idea that such a fundamental feature had been broken. I

[Bug 62121] Calculating the power of a negative number with a fraction fails (for example -2^(1/3))

2018-02-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62121 --- Comment #7 from mewa...@gmail.com --- These changes all make sense to me (though I didn't check the math code). My 2 cents: it's worth mimicking-- Excel is the gold standard for spreadsheets and if someone has an Excel model that works and

[Bug 62121] Calculating the power of a negative number with a fraction fails (for example -2^(1/3))

2018-02-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62121 --- Comment #6 from Axel Howind --- (In reply to mewalig from comment #5) I don't know if this should really be mimicked. But if so, the code should be corrected in some places (still untested and should be checked if we really