asfgit closed pull request #395: Bump commons-compress from 1.21 to 1.22
URL: https://github.com/apache/poi/pull/395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] opened a new pull request, #395:
URL: https://github.com/apache/poi/pull/395
Bumps commons-compress from 1.21 to 1.22.
[![Dependabot compatibility
asfgit closed pull request #394: Bump org.sonarqube from 3.4.0.2513 to
3.5.0.2730
URL: https://github.com/apache/poi/pull/394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dependabot[bot] commented on PR #394:
URL: https://github.com/apache/poi/pull/394#issuecomment-1297181444
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
dependabot[bot] opened a new pull request, #394:
URL: https://github.com/apache/poi/pull/394
Bumps org.sonarqube from 3.4.0.2513 to 3.5.0.2730.
[![Dependabot compatibility
dependabot[bot] commented on PR #391:
URL: https://github.com/apache/poi/pull/391#issuecomment-1290713478
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
dependabot[bot] commented on PR #392:
URL: https://github.com/apache/poi/pull/392#issuecomment-1290713397
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency by
asfgit closed pull request #391: Bump mockito-core from 4.8.0 to 4.8.1
URL: https://github.com/apache/poi/pull/391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] commented on PR #393:
URL: https://github.com/apache/poi/pull/393#issuecomment-1290713423
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
asfgit closed pull request #393: Bump woodstox-core from 6.3.1 to 6.4.0
URL: https://github.com/apache/poi/pull/393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #392: Bump batikVersion from 1.15 to 1.16
URL: https://github.com/apache/poi/pull/392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] opened a new pull request, #393:
URL: https://github.com/apache/poi/pull/393
Bumps [woodstox-core](https://github.com/FasterXML/woodstox) from 6.3.1 to
6.4.0.
Commits
https://github.com/FasterXML/woodstox/commit/e8f00401bebd103f62d51383ef53da2cd58bd89e;>e8f0040
dependabot[bot] opened a new pull request, #392:
URL: https://github.com/apache/poi/pull/392
Bumps `batikVersion` from 1.15 to 1.16.
Updates `batik-svggen` from 1.15 to 1.16
Updates `batik-svgrasterizer` from 1.15 to 1.16
Updates `batik-codec` from 1.15 to 1.16
dependabot[bot] opened a new pull request, #391:
URL: https://github.com/apache/poi/pull/391
Bumps [mockito-core](https://github.com/mockito/mockito) from 4.8.0 to 4.8.1.
Release notes
Sourced from https://github.com/mockito/mockito/releases;>mockito-core's
releases.
v4.8.1
dependabot[bot] commented on PR #390:
URL: https://github.com/apache/poi/pull/390#issuecomment-1284161142
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
asfgit closed pull request #390: Bump com.github.spotbugs from 5.0.12 to 5.0.13
URL: https://github.com/apache/poi/pull/390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] opened a new pull request, #390:
URL: https://github.com/apache/poi/pull/390
Bumps com.github.spotbugs from 5.0.12 to 5.0.13.
[![Dependabot compatibility
pjfanning commented on PR #389:
URL: https://github.com/apache/poi/pull/389#issuecomment-1282261994
Thanks - merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #389: Insert paragraphs and tables into
`XWPFDocuments` recursively
URL: https://github.com/apache/poi/pull/389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AntonOellerer opened a new pull request, #389:
URL: https://github.com/apache/poi/pull/389
Up until now, the `XWPFDocument#insertNew[Paragraph|Table](XmlCursor)`
methods were only able to insert the elements if they were present in the
`XWPFDocument`-internal lists representing the
dependabot[bot] commented on PR #388:
URL: https://github.com/apache/poi/pull/388#issuecomment-1271714590
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
asfgit closed pull request #388: Bump org.cyclonedx.bom from 1.7.1 to 1.7.2
URL: https://github.com/apache/poi/pull/388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] opened a new pull request, #388:
URL: https://github.com/apache/poi/pull/388
Bumps org.cyclonedx.bom from 1.7.1 to 1.7.2.
[![Dependabot compatibility
pjfanning commented on PR #368:
URL: https://github.com/apache/poi/pull/368#issuecomment-1270607416
@arturobernalg we don't use git - we use svn. Usually, if the Github PR is
worthwhile, I'll go through the effort of creating a svn commit. In this case,
I don't think the new code is a big
dependabot[bot] commented on PR #386:
URL: https://github.com/apache/poi/pull/386#issuecomment-1261009675
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
asfgit closed pull request #386: Bump slf4j-api from 2.0.2 to 2.0.3
URL: https://github.com/apache/poi/pull/386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
asfgit closed pull request #387: Bump slf4j-simple from 2.0.2 to 2.0.3
URL: https://github.com/apache/poi/pull/387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] commented on PR #387:
URL: https://github.com/apache/poi/pull/387#issuecomment-1261009759
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
dependabot[bot] opened a new pull request, #387:
URL: https://github.com/apache/poi/pull/387
Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 2.0.2 to 2.0.3.
Commits
https://github.com/qos-ch/slf4j/commit/b2cb05f16acc21a3266a74ef5c578f2cd9efdead;>b2cb05f
prepare
dependabot[bot] opened a new pull request, #386:
URL: https://github.com/apache/poi/pull/386
Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 2.0.2 to 2.0.3.
Commits
https://github.com/qos-ch/slf4j/commit/b2cb05f16acc21a3266a74ef5c578f2cd9efdead;>b2cb05f
prepare release
asfgit closed pull request #385: Fix bug with multiple gradient stops at the
exact same location causing a rendering failure (AWT -> not enough colors in
gradient)
URL: https://github.com/apache/poi/pull/385
--
This is an automated message from the Apache Git Service.
To respond to the
gffloodg opened a new pull request, #385:
URL: https://github.com/apache/poi/pull/385
When rendering a shape with a gradient fill that contains 2 or more stops
that are at the exact same fractional position, the rendering will fail with
the following exception:
`User must specify at
dependabot[bot] commented on PR #382:
URL: https://github.com/apache/poi/pull/382#issuecomment-1253798275
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
dependabot[bot] commented on PR #383:
URL: https://github.com/apache/poi/pull/383#issuecomment-1253798218
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency by
dependabot[bot] commented on PR #384:
URL: https://github.com/apache/poi/pull/384#issuecomment-1253798259
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
asfgit closed pull request #384: Bump byte-buddy from 1.12.16 to 1.12.17
URL: https://github.com/apache/poi/pull/384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #382: Bump byte-buddy-agent from 1.12.16 to 1.12.17
URL: https://github.com/apache/poi/pull/382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #383: Bump junitVersion from 5.9.0 to 5.9.1
URL: https://github.com/apache/poi/pull/383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] commented on PR #383:
URL: https://github.com/apache/poi/pull/383#issuecomment-1253794708
Looks like this PR is already up-to-date with trunk! If you'd still like to
recreate it from scratch, overwriting any edits, you can request `@dependabot
recreate`.
--
This is an
pjfanning commented on PR #383:
URL: https://github.com/apache/poi/pull/383#issuecomment-1253794643
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] opened a new pull request, #383:
URL: https://github.com/apache/poi/pull/383
Bumps `junitVersion` from 5.9.0 to 5.9.1.
Updates `junit-jupiter-api` from 5.9.0 to 5.9.1
Release notes
Sourced from https://github.com/junit-team/junit5/releases;>junit-jupiter-api's
dependabot[bot] opened a new pull request, #382:
URL: https://github.com/apache/poi/pull/382
Bumps [byte-buddy-agent](https://github.com/raphw/byte-buddy) from 1.12.16
to 1.12.17.
Changelog
Sourced from
dependabot[bot] opened a new pull request, #384:
URL: https://github.com/apache/poi/pull/384
Bumps [byte-buddy](https://github.com/raphw/byte-buddy) from 1.12.16 to
1.12.17.
Changelog
Sourced from https://github.com/raphw/byte-buddy/blob/master/release-notes.md;>byte-buddy's
dependabot[bot] commented on PR #381:
URL: https://github.com/apache/poi/pull/381#issuecomment-1248220167
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
dependabot[bot] commented on PR #380:
URL: https://github.com/apache/poi/pull/380#issuecomment-1248220137
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
asfgit closed pull request #381: Bump slf4j-simple from 2.0.0 to 2.0.1
URL: https://github.com/apache/poi/pull/381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #380: Bump slf4j-api from 2.0.0 to 2.0.1
URL: https://github.com/apache/poi/pull/380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
dependabot[bot] opened a new pull request, #381:
URL: https://github.com/apache/poi/pull/381
Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 2.0.0 to 2.0.1.
Commits
https://github.com/qos-ch/slf4j/commit/9752442b6e6db0749915dc40e80437dc97cd772d;>9752442
prepare
dependabot[bot] opened a new pull request, #380:
URL: https://github.com/apache/poi/pull/380
Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 2.0.0 to 2.0.1.
Commits
https://github.com/qos-ch/slf4j/commit/9752442b6e6db0749915dc40e80437dc97cd772d;>9752442
prepare release
asfgit closed pull request #158: Read-only Row-like view of columns
URL: https://github.com/apache/poi/pull/158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
dependabot[bot] commented on PR #379:
URL: https://github.com/apache/poi/pull/379#issuecomment-1242181995
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
asfgit closed pull request #379: Bump byte-buddy-agent from 1.12.14 to 1.12.16
URL: https://github.com/apache/poi/pull/379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] commented on PR #378:
URL: https://github.com/apache/poi/pull/378#issuecomment-1242181982
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
asfgit closed pull request #378: Bump byte-buddy from 1.12.14 to 1.12.16
URL: https://github.com/apache/poi/pull/378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] opened a new pull request, #379:
URL: https://github.com/apache/poi/pull/379
Bumps [byte-buddy-agent](https://github.com/raphw/byte-buddy) from 1.12.14
to 1.12.16.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases;>byte-buddy-agent's
dependabot[bot] opened a new pull request, #378:
URL: https://github.com/apache/poi/pull/378
Bumps [byte-buddy](https://github.com/raphw/byte-buddy) from 1.12.14 to
1.12.16.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases;>byte-buddy's
releases.
pjfanning commented on PR #377:
URL: https://github.com/apache/poi/pull/377#issuecomment-1229418105
Thanks - merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #377: Fix issue with orphaned (in package) images
and notes post slide removal.
URL: https://github.com/apache/poi/pull/377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gffloodg opened a new pull request, #377:
URL: https://github.com/apache/poi/pull/377
When removing a slide from a loaded (XMLSlideShow) presentation, it is
observed that the resulting output, whilst removing the actual slides leaves
dangling (orphaned) artefacts in the written package.
dependabot[bot] commented on PR #373:
URL: https://github.com/apache/poi/pull/373#issuecomment-1222489867
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
dependabot[bot] commented on PR #372:
URL: https://github.com/apache/poi/pull/372#issuecomment-1222489899
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
dependabot[bot] commented on PR #375:
URL: https://github.com/apache/poi/pull/375#issuecomment-1222489888
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
dependabot[bot] commented on PR #376:
URL: https://github.com/apache/poi/pull/376#issuecomment-1222489853
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
dependabot[bot] commented on PR #374:
URL: https://github.com/apache/poi/pull/374#issuecomment-1222489834
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
asfgit closed pull request #372: Bump slf4j-simple from 1.7.36 to 2.0.0
URL: https://github.com/apache/poi/pull/372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #375: Bump slf4j-api from 1.7.36 to 2.0.0
URL: https://github.com/apache/poi/pull/375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #373: Bump byte-buddy-agent from 1.12.13 to 1.12.14
URL: https://github.com/apache/poi/pull/373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #376: Bump byte-buddy from 1.12.13 to 1.12.14
URL: https://github.com/apache/poi/pull/376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #374: Bump com.github.spotbugs from 5.0.9 to 5.0.10
URL: https://github.com/apache/poi/pull/374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] opened a new pull request, #376:
URL: https://github.com/apache/poi/pull/376
Bumps [byte-buddy](https://github.com/raphw/byte-buddy) from 1.12.13 to
1.12.14.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases;>byte-buddy's
releases.
dependabot[bot] opened a new pull request, #375:
URL: https://github.com/apache/poi/pull/375
Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.36 to 2.0.0.
Commits
https://github.com/qos-ch/slf4j/commit/0614d467d7bca81724f45e228f4f871161222b51;>0614d46
prepare
dependabot[bot] opened a new pull request, #374:
URL: https://github.com/apache/poi/pull/374
Bumps com.github.spotbugs from 5.0.9 to 5.0.10.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #372:
URL: https://github.com/apache/poi/pull/372
Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 1.7.36 to 2.0.0.
Commits
https://github.com/qos-ch/slf4j/commit/0614d467d7bca81724f45e228f4f871161222b51;>0614d46
prepare
dependabot[bot] opened a new pull request, #373:
URL: https://github.com/apache/poi/pull/373
Bumps [byte-buddy-agent](https://github.com/raphw/byte-buddy) from 1.12.13
to 1.12.14.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases;>byte-buddy-agent's
asfgit closed pull request #371: fix: when copy slide,new slide use old textrun
object reference
URL: https://github.com/apache/poi/pull/371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pjfanning commented on PR #371:
URL: https://github.com/apache/poi/pull/371#issuecomment-1220409161
merged - thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
FlyingPigQAQ commented on PR #371:
URL: https://github.com/apache/poi/pull/371#issuecomment-1220181755
Unit tests were added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
FlyingPigQAQ commented on PR #371:
URL: https://github.com/apache/poi/pull/371#issuecomment-1220122256
> It is also better to raise a bug first before providing PRs. See
https://bz.apache.org/bugzilla
Hello, I read the buglist and found an issue with the same problem but not
fixed.
pjfanning commented on PR #371:
URL: https://github.com/apache/poi/pull/371#issuecomment-1220107861
It is also better to raise a bug first before providing PRs. See
https://bz.apache.org/bugzilla
--
This is an automated message from the Apache Git Service.
To respond to the message,
pjfanning commented on PR #371:
URL: https://github.com/apache/poi/pull/371#issuecomment-1220107451
Please provide some description - and ideally a test case to go with this.
It is not enough to modify code without describing why.
--
This is an automated message from the Apache Git
arturobernalg commented on code in PR #368:
URL: https://github.com/apache/poi/pull/368#discussion_r941734438
##
poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/PackagePartName.java:
##
@@ -326,7 +326,7 @@ private static void checkPCharCompliance(String segment)
pjfanning commented on PR #367:
URL: https://github.com/apache/poi/pull/367#issuecomment-1207365257
thanks - merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #367: Avoid long literals ending with lowercase 'l'.
These literals may be …
URL: https://github.com/apache/poi/pull/367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pjfanning commented on PR #365:
URL: https://github.com/apache/poi/pull/365#issuecomment-1207283602
merged - thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #365: Use java 8 style. Replace anonymous with
lambdas.
URL: https://github.com/apache/poi/pull/365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pjfanning commented on PR #366:
URL: https://github.com/apache/poi/pull/366#issuecomment-1207282899
thanks - merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #366: Remove unnecessary local variables. Inline
instead.
URL: https://github.com/apache/poi/pull/366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
asfgit closed pull request #364: Use java Math.min and Math max and avoid
manual calculations.
URL: https://github.com/apache/poi/pull/364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pjfanning commented on PR #364:
URL: https://github.com/apache/poi/pull/364#issuecomment-1207281118
Thanks - merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
pjfanning commented on code in PR #368:
URL: https://github.com/apache/poi/pull/368#discussion_r939570084
##
poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/PackagePartName.java:
##
@@ -326,7 +326,7 @@ private static void checkPCharCompliance(String segment)
pjfanning commented on code in PR #368:
URL: https://github.com/apache/poi/pull/368#discussion_r939569973
##
poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/PackagePartName.java:
##
@@ -326,7 +326,7 @@ private static void checkPCharCompliance(String segment)
arturobernalg opened a new pull request, #367:
URL: https://github.com/apache/poi/pull/367
Avoid long literals ending with lowercase 'l'. These literals may be
confusing, as lowercase 'l' looks very similar to '1'. Use 'L' instead
--
This is an automated message from the Apache Git
pjfanning closed pull request #363: use async task to avoid calculating
dowstream result in same thread
URL: https://github.com/apache/poi/pull/363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pjfanning commented on PR #363:
URL: https://github.com/apache/poi/pull/363#issuecomment-1198554174
I'm closing this. The issue generally is not a high priority. I may try
another approach later on.
--
This is an automated message from the Apache Git Service.
To respond to the message,
pjfanning commented on PR #363:
URL: https://github.com/apache/poi/pull/363#issuecomment-1192367747
Yes, it would be possible to rewrite the code to do a solution that doesn't
need async tasks. It would probably be a much bigger change though.
The new algorithm would probably involve
centic9 commented on PR #363:
URL: https://github.com/apache/poi/pull/363#issuecomment-1192277279
So this is mostly a workaround to avoid Stackoverflow due to recursion?
The usual solution for this is to replace recursion with a stack+loop, is
this possible here?
--
This is an
pjfanning commented on PR #363:
URL: https://github.com/apache/poi/pull/363#issuecomment-1192056377
I've done some more testing and this change does not work reliably. The
EvaluationTracker class keeps has _evaluationFrames list and this assumes all
cells are evaluated in order - which
pjfanning commented on PR #363:
URL: https://github.com/apache/poi/pull/363#issuecomment-1191850830
The use of the fork join pool (when enabled) is not to parallelise the job.
The task is run on the executor and we then block waiting for the task. For a
FormulaEvaluator, you will only ever
pjfanning commented on PR #363:
URL: https://github.com/apache/poi/pull/363#issuecomment-1191683715
> Could this potentially just run out of threads and deadlock instead of
stack overflow?
Fork Join Pools use a very limited number of threads.
Still, the plan is to make this
centic9 commented on PR #363:
URL: https://github.com/apache/poi/pull/363#issuecomment-1191676941
I would opt for configuration, potentially even default off for backwards
compatibility.
Many users (including some of my own use-cases) may not want to have
uncontrolled threads being
101 - 200 of 1010 matches
Mail list logo