[Bug 59252] Close workbook does not save file

2021-09-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59252 lawern changed: What|Removed |Added CC||lars.wer...@agentes.de -- You are receiving

[Bug 59252] Close workbook does not save file

2021-09-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59252 lawern changed: What|Removed |Added Version|3.14-FINAL |5.0.x-dev -- You are receiving this mail

[Bug 59252] Close workbook does not save file

2021-04-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59252 Sz.Noemi changed: What|Removed |Added CC||noemi.szemen...@foconis.de -- You are

[Bug 59252] Close workbook does not save file

2021-03-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59252 --- Comment #7 from Francisco Castaneda --- I had the same problem, unless you call write on an outputstream, changes won't be saved. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 59252] Close workbook does not save file

2021-02-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59252 --- Comment #6 from Marcel M. --- I just hit this bug in 5.0.0. A (wasteful) workaround is to write to a NullOutputStream to trigger the in place update of the File: try (Workbook wb = WorkbookFactory.create(new File("foo"));

[Bug 59252] Close workbook does not save file

2016-06-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59252 Javen O'Neal changed: What|Removed |Added Depends on||57919 -- You are

[Bug 59252] Close workbook does not save file

2016-04-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59252 Dominik Stadler changed: What|Removed |Added Depends on||59287 --

[Bug 59252] Close workbook does not save file

2016-03-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59252 --- Comment #5 from Javen O'Neal --- Testing the change to POIXMLDocument.close from comment 4, I got an error on TestXSSFBugs.bug45431 (which relates to a macro-enabled workbook): "Rule M2.4 exception : this error should

Re: [Bug 59252] Close workbook does not save file

2016-03-30 Thread Andreas Beeker
I never understood why the default is to write changes to disc. I'd prefer the default to leave the document unchanged and only write the changes when commit() is called. close() should be callable in any case, possibly throwing away any temporary objects - and it should be ok, to call it again.

Re: [Bug 59252] Close workbook does not save file

2016-03-30 Thread Javen O'Neal
This is a candidate for GSOC or Help Wanted. Need WorkbookFactory.create and XSSFWorkbook constructor to open read only Should not write to file on close if a workbook is merely opened and not modified. Sounds like changing close's behavior is contentious, so we'd need to decide what direction

[Bug 59252] Close workbook does not save file

2016-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59252 --- Comment #3 from Alex --- Ok,I think I understand your point, close() shouldn't save to file (and I actually agree with that) but what I'm saing its that it actually doesn't save on close() with 3.14 release unless you

[Bug 59252] Close workbook does not save file

2016-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59252 --- Comment #2 from Nick Burch --- OPCPackage has always supported in-place write for Files. OPOIFS never did, while NPOIFS now does. Because OPOIFS never did, and that's all we had for agest, the usermodel APIs never did

[Bug 59252] Close workbook does not save file

2016-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59252 Javen O'Neal changed: What|Removed |Added OS||All --- Comment #1