[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2019-03-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 --- Comment #13 from Dominik Stadler --- Thanks for the note, but commenting on a resolved issue has a high chance of being lost, better report a new issue with a mention of the previous issue and the information about how to rerproduce your

[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2019-03-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 Travis Burtrum changed: What|Removed |Added CC||admin.apache@moparisthebest

[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2019-03-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 --- Comment #11 from Travis Burtrum --- Hello all, We are upgrading from poi 3.17 to 4.0.1 and formula evaluation was broken, I used git bisect on poi and tracked it down to this line specifically:

[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2017-12-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 --- Comment #10 from Javen O'Neal --- Throw in some @Override's for good measure -- You are receiving this mail because: You are the assignee for the bug.

[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2017-12-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 Greg Woolsey changed: What|Removed |Added Status|NEEDINFO|RESOLVED

[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2017-12-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 --- Comment #9 from Greg Woolsey --- (In reply to PJ Fanning from comment #7) > Can we call the new method getLastRowNum instead of getlastRowNum? > Also, a lot of public methods have had their signatures changed. Do we

[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2017-12-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 --- Comment #8 from Luca Martini --- (In reply to Greg Woolsey from comment #5) > Changes in r1817252 > Thank you very much Greg. > Of this remaining time, about 2/3 is taken up in the formula evaluation > caching

[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2017-12-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 --- Comment #7 from PJ Fanning --- Can we call the new method getLastRowNum instead of getlastRowNum? Also, a lot of public methods have had their signatures changed. Do we need to keep the existing signatures too and

[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2017-12-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 --- Comment #6 from Javen O'Neal --- (In reply to Greg Woolsey from comment #5) > 14.4s > when XSSFEvaluationSheet caches the value of getLastRowNum(), since it comes > from a TreeMap.lastKey() which has to navigate the tree

[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2017-12-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 --- Comment #5 from Greg Woolsey --- Changes in r1817252 Interesting. In a local test with the attached sample file, I found these results: 45s (second run) with current codebase issuing FormulaEvaluator.evaluateAll()

[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2017-12-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 --- Comment #4 from Greg Woolsey --- It looks to me like the sheet is available: Vlookup.evalutate() receives a ValueEval that is converted to a TwoDEval via LookupUtils.resolveTableArrayArg(). TwoDEval interface has

[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2017-12-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 --- Comment #3 from Javen O'Neal --- Looking at the POI implementation of Vlookup.java, the class currently doesn't have a reference to the sheet that contains the lookup table. This will make a fix non-trivial. The

[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2017-12-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 --- Comment #2 from Luca Martini --- Nick, I have already contributed some patches in the past. However I am not sure to have the time to work to this fix at the moment. I opened the bug for future reference and to

[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2017-12-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 Nick Burch changed: What|Removed |Added Status|NEW |NEEDINFO ---

[Bug 61841] Unnecessary long computation when evaluating VLOOKUP on all column reference

2017-12-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61841 Luca Martini changed: What|Removed |Added CC|