[GitHub] [poi] centic9 commented on a change in pull request #224: Use Log4j 2 for logging

2021-02-12 Thread GitBox
centic9 commented on a change in pull request #224: URL: https://github.com/apache/poi/pull/224#discussion_r575051285 ## File path: log4j2-console.xml ## @@ -0,0 +1,42 @@ + Review comment: Thanks for the effort, to me it looks clearer this way as it makes it easy to

[GitHub] [poi] centic9 commented on a change in pull request #224: Use Log4j 2 for logging

2021-02-02 Thread GitBox
centic9 commented on a change in pull request #224: URL: https://github.com/apache/poi/pull/224#discussion_r568637101 ## File path: log4j2-console.xml ## @@ -0,0 +1,42 @@ + Review comment: Is there a way to move the two xml-configuration files away from the

[GitHub] [poi] centic9 commented on a change in pull request #224: Use Log4j 2 for logging

2021-02-02 Thread GitBox
centic9 commented on a change in pull request #224: URL: https://github.com/apache/poi/pull/224#discussion_r568637101 ## File path: log4j2-console.xml ## @@ -0,0 +1,42 @@ + Review comment: Is there a way to move the two xml-configuration files away from the