RE: svn commit: r1709427 - /poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/CombinedIterable.java

2015-10-19 Thread Uwe Schindler
Just unrelated to the original fix: According to checks, the EmptyIterator should throw NoSuchElementException. But I would remove the impl completely! It is much simpler to just return Collections.emptySet().iterator() when empty iterators are required; this is also just returning a static

Re: svn commit: r1709427 - /poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/CombinedIterable.java

2015-10-19 Thread Dustin Spicuzza
Thanks, I was originally using Collections.emptyIterator(), but that's only available in Java 7+. I'll do it your way, that sounds easier anyways. :) Dustin On 10/19/2015 1:30 PM, Uwe Schindler wrote: > Just unrelated to the original fix: > > According to checks, the EmptyIterator should