[GitHub] [poi] rzymek edited a comment on pull request #154: [bug-57342] Excel compatible Zip64 implementation
rzymek edited a comment on pull request #154: URL: https://github.com/apache/poi/pull/154#issuecomment-636462830 Are you getting "corrupted file" error from Excel or OpenOffice or something else? OpenOffice Calc has a [limit of 1024 columns](https://simple.wikipedia.org/wiki/OpenOffice_Calc#Specifications) (Excel's limit is 16k columns). Other than that, the code looks ok. Zip64Mode needs to be Always in this case to enable ZIP64 handling compatible with Excel. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] rzymek commented on pull request #154: [bug-57342] Excel compatible Zip64 implementation
rzymek commented on pull request #154: URL: https://github.com/apache/poi/pull/154#issuecomment-636462830 Are you getting "corrupted file" error from Excel or OpenOffice or something else? OpenOffice Calc has a limit of 1024 columns (Excel's limit is 16k columns). Other than that, the code looks ok. Zip64Mode needs to be Always in this case to enable ZIP64 handling compatible with Excel. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #154: [bug-57342] Excel compatible Zip64 implementation
pjfanning commented on pull request #154: URL: https://github.com/apache/poi/pull/154#issuecomment-636493479 Thanks @rzymek - we might want to make Zip64Mode.Always the default - needs some experimentation before we'd make that change though This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] rzymek commented on pull request #154: [bug-57342] Excel compatible Zip64 implementation
rzymek commented on pull request #154: URL: https://github.com/apache/poi/pull/154#issuecomment-636494966 Exactly. I think that custom zip64 implementation should sit as an option for a few versions (it's only enabled when Zip64Mode.Always). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #154: [bug-57342] Excel compatible Zip64 implementation
pjfanning commented on pull request #154: URL: https://github.com/apache/poi/pull/154#issuecomment-636483470 @rzymek thanks for clarifying - do you know what effect setting Zip64Mode.Always has if you create a small spreadsheet - will this file cause problems for Excel? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] rzymek commented on pull request #154: [bug-57342] Excel compatible Zip64 implementation
rzymek commented on pull request #154: URL: https://github.com/apache/poi/pull/154#issuecomment-636492054 As far as I checked, Zip64Mode.Always does not cause problem with Excel even in small files. When it comes to Excel and big files (XML over 4Gb), then ZIP64 must be declared in the zip entry header before the actual zip entry contents. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
