Re: 3.15 beta 2 soon?

[Javen O'Neal]

I can't find the flash drive I put my private key on. Someone else will
need to be release manager for 3.15 beta 2 unless a miracle happens.
On Jun 20, 2016 04:01, "Dominik Stadler"  wrote:

> Ok,
>
> No problem, the regression testing is running fairly stable now and most of
> the steps are automated already, so I mostly just need to push the button
> and wait one or two days... :)
>
> Javen, I will change the exception that you introduced on the
> version-switch in FileInformationBlock to a POILogger-output as it seems
> that there are quite a number of documents out there which use unknown
> version-ids but work fine nevertheless.
>
> Dominik.
>
> On Mon, Jun 20, 2016 at 1:00 AM, Andreas Beeker 
> wrote:
>
> > On 19.06.2016 10:35, Dominik Stadler wrote:
> > > here my results from the regression-tests for 3.15-beta2, I see two
> newly
> > > introduced issues that we should take a look at.
> >
> > I've fixed the mentioned PPT issue already via #59702, but that commit
> was
> > after you've started
> > the integration test. As this change affects quite a few methods, please
> > run another test
> > for me ... maybe limit it to the PPT/X files.
> >
> > Apart of that I've fixed another two issues just by now via r1749224.
> >
> > Andi
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
> >
>

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

--- Comment #7 from Nick Burch  ---
Those look like clusters around the valid values (plus an outlier at 113)

I'd be tempted to say we accept any value +- 4 without much/any logging (and +-
113). Could someone check, for a few triggering files, how their cbRgFcLcb
values match with what the spec says to expect for the nearest-valid nFib
values?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59738] Excel Files generated using XSSFWorkbook can't be opened using Ms-Excel or OpenOffice

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59738

--- Comment #4 from Adrodoc55  ---
(In reply to Javen O'Neal from comment #3)
> Are you using the same version of poi, poi-ooxml, and poi-ooxml-schemas?
> 
> Does wb.write throw an exception?

I am using v3.14 of poi-ooxml and v1.3 of ooxml-shemas. I use Gradle to resolve
transitive dependencies. I also tried all major versions between 3.9 and 3.14,
but only 3.9 and 3.10.1 are working.
I don't get any Exceptions in Java, only Ms-Excel and OpenOffice are telling me
that the generated xlsx files are corrupted. I don't think it is an issue with
Ms-Excel or OpenOffice, because they can open other xlsx files.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

--- Comment #6 from Dominik Stadler  ---
In my regression-run, the following invalid versions are found:

EXCEPTIONTEXT315BETA2
java.lang.IllegalStateException: Invalid file format version number: 113
java.lang.IllegalStateException: Invalid file format version number: 191
java.lang.IllegalStateException: Invalid file format version number: 192
java.lang.IllegalStateException: Invalid file format version number: 194
java.lang.IllegalStateException: Invalid file format version number: 195
java.lang.IllegalStateException: Invalid file format version number: 216
java.lang.IllegalStateException: Invalid file format version number: 265
java.lang.IllegalStateException: Invalid file format version number: 267


We can add those as "undocumented", but I'd probably go with a
POILogger.warning() instead of the throw to not fail on other version-numbers
that are not included in our test-files.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

--- Comment #5 from Javen O'Neal  ---
Reverting any deprecated code deletion I did as part of bug 59170 is also an
acceptable fix here. I was pretty heavy handed with HWPF.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59738] Excel Files generated using XSSFWorkbook can't be opened using Ms-Excel or OpenOffice

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59738

--- Comment #3 from Javen O'Neal  ---
Are you using the same version of poi, poi-ooxml, and poi-ooxml-schemas?

Does wb.write throw an exception?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

--- Comment #4 from Nick Burch  ---
I guess we need to work out what format type these are (maybe by seeing what
they contain, or what Word treats them as?), then add a few more "unofficial"
entries to the check list

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

--- Comment #3 from Tim Allison  ---
Y, the problem goes away if I save as.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

Nick Burch  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #2 from Nick Burch  ---
Based on the file format specs -
https://msdn.microsoft.com/en-us/library/dd949344(v=office.12).aspx and
https://msdn.microsoft.com/en-us/library/dd950103(v=office.12).aspx - it looks
like we have all the "official" cases covered

Do these files start passing again if you do a save-as from word?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59738] Excel Files generated using XSSFWorkbook can't be opened using Ms-Excel or OpenOffice

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59738

--- Comment #2 from Adrodoc55  ---
(In reply to Dominik Stadler from comment #1)
> Does it work if you specify a sheet-name in the call to createSheet()?

No it does not.
I have tried many different variants, and multiple of the official examples and
both Ms-Excel and OpenOffice can't open any xlsx files that were created by a
poi version 3.11 or above.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

--- Comment #1 from Tim Allison  ---
I'll run the full corpus regression tests shortly to see if there are other
values we need to add.  Or, should we undo this check?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] New: Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

Bug ID: 59739
   Summary: Need to expand options in
FileInformationBlock.assertCbRgFcLcb
   Product: POI
   Version: unspecified
  Hardware: PC
OS: Windows NT
Status: NEW
  Severity: major
  Priority: P2
 Component: HWPF
  Assignee: dev@poi.apache.org
  Reporter: talli...@mitre.org

Created attachment 33970
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33970=edit
triggering file

In tightening up the codebase based on FindBugs results[0], we're now throwing
an IllegalStateException if the FileInformationBlock doesn't match one of 5
patterns.

A test file in Tika's test suite is now getting:

Caused by: java.lang.IllegalStateException: Invalid file format version number:
195
at
org.apache.poi.hwpf.model.FileInformationBlock.assertCbRgFcLcb(FileInformationBlock.java:164)
at
org.apache.poi.hwpf.model.FileInformationBlock.(FileInformationBlock.java:140)
at org.apache.poi.hwpf.HWPFDocumentCore.(HWPFDocumentCore.java:163)
at org.apache.poi.hwpf.HWPFDocument.(HWPFDocument.java:197)
at
org.apache.tika.parser.microsoft.WordExtractor.parse(WordExtractor.java:144)
at
org.apache.tika.parser.microsoft.OfficeParser.parse(OfficeParser.java:146)
at
org.apache.tika.parser.microsoft.OfficeParser.parse(OfficeParser.java:117)
at org.apache.tika.parser.CompositeParser.parse(CompositeParser.java:280)
... 34 more

[0]http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/FileInformationBlock.java?r1=1557290=1738782

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59717] Provide getThumbnail method on POIXMLDocument or POIXMLProperties, to get the Thumbnail (where exists) for OOXML documents

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59717

Nick Burch  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Nick Burch  ---
Support added in r1749528, also including set support too

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: [Bug 58499] - ZipSecureFile throws zip bomb detected

[Dominik Stadler]

I'm fine with using ZipFile directly internally in SWSSFWorkbook. A quick
look did not reveal any glaring security problem with doing this. We mostly
prevent denial-of-service types of attacks here so if a malicious user can
overwrite the temporary file he can do lots of other bad things anyway...

Dominik.

On Tue, Jun 21, 2016 at 12:18 AM, Javen O'Neal  wrote:

> On Jun 20, 2016 2:41 PM, "Axel Howind"  wrote:
> > How should I submit a patch?
>
> Once there is consensus on how POI should handle this, open a new bug that
> "depends on" bug 58499.
>

[Bug 59738] Excel Files generated using XSSFWorkbook can't be opened using Ms-Excel or OpenOffice

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59738

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 OS||All

--- Comment #1 from Dominik Stadler  ---
Does it work if you specify a sheet-name in the call to createSheet()?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59738] New: Excel Files generated using XSSFWorkbook can't be opened using Ms-Excel or OpenOffice

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59738

Bug ID: 59738
   Summary: Excel Files generated using XSSFWorkbook can't be
opened using Ms-Excel or OpenOffice
   Product: POI
   Version: 3.14-FINAL
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: XSSF
  Assignee: dev@poi.apache.org
  Reporter: adrodo...@googlemail.com

Created attachment 33969
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33969=edit
Error in Excel

Excel Files generated using XSSFWorkbook can't be opened using Ms-Excel or
OpenOffice. POI can read those files.

I used the official BusinessPlan example from the POI website:
https://poi.apache.org/spreadsheet/examples.html#business-plan

The xls file generated by this example works fine in all versions, but the xlsx
file can't be opened when using POI 3.11 or higher (including 3.14). POI 3.10.1
works fine.

Even an empty worbook (with just one sheet) cannot be opened when using xssf,
but works fine in hssf:

String format = "xlsx";
File outputFile = new File("C:/temp/output." + format);
Workbook wb = new XSSFWorkbook();
wb.createSheet();
try (FileOutputStream fileOutputStream = new FileOutputStream(outputFile);) {
  wb.write(fileOutputStream);
}

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59734] Named range creation & lookup are linear in the number of ranges

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

--- Comment #2 from David North  ---
The rather old patch I'm working from hides that logic in the key, so I'll
probably go with that approach.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org