Re: [VOTE] Apache POI 4.1.2 release (RC1)

2020-01-31 Thread Alain FAGOT BÉAREZ

+1

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[VOTE] Apache POI 4.1.2 release (RC1)

2020-01-31 Thread Andreas Beeker
Hi *,

I've prepared artifacts for the release of Apache POI 4.1.2 (RC1).

The most notable changes in this release are:

- XDDF - some work on better chart support
- Common SL / EMF - ongoing rendering fixes - see #60656
- XSLF - OOM fixes when parsing arbitrary shape ids + a new dependency to 
SparseBitSet 1.2 - see #64015

https://dist.apache.org/repos/dist/dev/poi/4.1.2-RC1/

Are you missing any other notable changes?

I've realized that not all tickets are in the change log.
I'll add them now, but those aren't in the to-be released change log.

For getting the XSLF rendering/integration tests through I needed to increase 
the heap to 2gb.
I think we can minimize the memory usage, but for getting the release through,
I've decided to simply increase the heap for now.

Please vote to release the artifacts.
The vote keeps open for 72hrs after the regression results are available.
Planned release announcement date is Friday, 2020-02-07.

Andi




signature.asc
Description: OpenPGP digital signature


Re: next release?

2020-01-31 Thread Andreas Beeker
I'm running into 4x OOMs when running the integration tests in Open or Oracle 
Jdk 8, even when raising the heap from 1512 to 2048 mb.
This didn't happen with OpenJDK 12 - which was my default setting before :|

It looks like there's a problem with XSLF (see below, although this is probably 
not the location where the memory leak is happening)

Andi


Testcase: testAllFiles[845: slideshow/Divino_Revelado.pptx using 
org.apache.poi.stress.XSLFFileHandler@396a51ab] took 2.339 sec
    Caused an ERROR
Java heap space
java.lang.OutOfMemoryError: Java heap space
    at java.util.Arrays.copyOf(Arrays.java:3332)
    at 
java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:124)
    at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:649)
    at java.lang.StringBuilder.append(StringBuilder.java:202)
    at 
org.apache.poi.sl.draw.DrawTextParagraph.tab2space(DrawTextParagraph.java:427)
    at 
org.apache.poi.sl.draw.DrawTextParagraph.getRenderableText(DrawTextParagraph.java:386)
    at 
org.apache.poi.sl.draw.DrawTextParagraph.getRenderableText(DrawTextParagraph.java:381)
    at 
org.apache.poi.sl.draw.DrawTextParagraph.getAttributedString(DrawTextParagraph.java:564)
    at 
org.apache.poi.sl.draw.DrawTextParagraph.breakText(DrawTextParagraph.java:258)
    at 
org.apache.poi.sl.draw.DrawTextShape.drawParagraphs(DrawTextShape.java:158)
    at 
org.apache.poi.sl.draw.DrawTextShape.getTextHeight(DrawTextShape.java:220)
    at org.apache.poi.sl.draw.DrawTextShape.drawContent(DrawTextShape.java:104)
    at org.apache.poi.sl.draw.DrawSimpleShape.draw(DrawSimpleShape.java:107)
    at org.apache.poi.sl.draw.DrawSheet.draw(DrawSheet.java:71)
    at org.apache.poi.sl.draw.DrawSlide.draw(DrawSlide.java:41)
    at org.apache.poi.xslf.usermodel.XSLFSlide.draw(XSLFSlide.java:373)
    at 
org.apache.poi.stress.SlideShowHandler.renderSlides(SlideShowHandler.java:152)
    at 
org.apache.poi.stress.SlideShowHandler.handleSlideShow(SlideShowHandler.java:46)
    at org.apache.poi.stress.XSLFFileHandler.handleFile(XSLFFileHandler.java:43)
    at org.apache.poi.TestAllFiles.testAllFiles(TestAllFiles.java:433)




signature.asc
Description: OpenPGP digital signature


Re: next release?

2020-01-31 Thread Andreas Beeker
Hi,

although I've fixed two issues *) locally, I'll postpone those commits after 
the release.

So I would roll the release now.

If there are any late-commits ... not a problem, but please inform us before 
Dominik and Tim run the integration tests again - not sure if this still makes 
sense, as there were only marginal changes.

Andi

*) a missing move-to exception from the mass tests and using a indexed palette 
for duotone bitmaps




signature.asc
Description: OpenPGP digital signature


[Bug 64108] unsafe pipe character ("|") in Relationship target attribute is not being encoded into a '%7C'

2020-01-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64108

--- Comment #5 from Richard Costine  ---
I think that the original patch I provided should be the correct behavior,
since the RFC indicates that the pipe character is not considered "valid" in a
url, and would normally be encoded with a "%7C".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 64108] unsafe pipe character ("|") in Relationship target attribute is not being encoded into a '%7C'

2020-01-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64108

--- Comment #4 from PJ Fanning  ---
We don't typically support system properties.

You've caught us in the middle of a release. If your patch is not the best
behaviour for this code and only suits your use case, then we need to remove
it. The RFC seems to suggest that we should the existing code had a bug but if
this not the case, then I will revert the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org