Build failed in Jenkins: POI » POI-DSL-Windows-1.21 #108

2024-02-26 Thread Apache Jenkins Server 
See 


Changes:

[PJ Fanning] rework tests

[PJ Fanning] woodstox 6.6.1

[PJ Fanning] update changes


--
[...truncated 4.19 MB...]
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
testSetActiveCell() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
sheetIterator_forEach() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
getSetActiveSheet() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
createSheetWithLongNames() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
setRepeatingRowsAndColumns() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
defaultValues() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
changeSheetNameWithSharedFormulas() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
sheetIterator_sheetsReordered() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook unicodeInAll() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
windowOneDefaults() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook cloneSheet() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook existing() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
testWorkbookForceFormulaRecalculation() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook bug47668() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook bug47737() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook bug47813() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook bug48495() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook bug49702() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook bug51158() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook bug60509() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook bug66365() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
test501RC1Failure() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
testNewWorkbookWithTempFilePackageParts() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
testAddPivotCache() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
testRightToLeft() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
testRemoveSheet() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
columnWidthPOI52233() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
testWorkbookCloseCanBeStoppedFromClosingInputStream() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
testCacheExternalWorkbook() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook styles() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
testLinkExternalWorkbook() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
checkNewFileForR1C1Refs() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook testBug54399() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook recalcId() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
existingWithZipEntryTempFiles() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
readFromZipStream() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
existingWithZipEntryEncryptedTempFiles() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook bug47090a() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook bug47090b() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook bug47090c() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook bug47090d() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook bug51158a() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
testNewWorkbookWithEncryptedTempFilePackageParts() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
testBug56957CloseWorkbook() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
workbookProperties() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
testSetVBAProject() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook 
testIgnoreTrashParts() PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook getFontAt() 
PASSED
org.apache.poi.xssf.usermodel.TestXSSFWorkbook

Build failed in Jenkins: POI » POI-DSL-1.22 #30

2024-02-26 Thread Apache Jenkins Server 
See 


Changes:

[PJ Fanning] rework tests

[PJ Fanning] woodstox 6.6.1

[PJ Fanning] update changes


--
[...truncated 602.64 KB...]
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestArrayPtg
[junitlauncher] Tests run: 5, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.002000 sec
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestAttrPtg
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestAttrPtg
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.00 sec
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestErrPtg
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestErrPtg
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.001000 sec
[junitlauncher] Running 
org.apache.poi.ss.formula.ptg.TestExternalFunctionFormulas
[junitlauncher] 
[junitlauncher] Running 
org.apache.poi.ss.formula.ptg.TestExternalFunctionFormulas
[junitlauncher] Tests run: 3, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.004000 sec
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestExternalNameReference
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestExternalNameReference
[junitlauncher] Tests run: 3, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.006000 sec
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestFuncPtg
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestFuncPtg
[junitlauncher] Tests run: 2, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.00 sec
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestFuncVarPtg
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestFuncVarPtg
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.00 sec
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestIntersectionPtg
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestIntersectionPtg
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.001000 sec
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestPercentPtg
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestPercentPtg
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.001000 sec
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestRangePtg
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestRangePtg
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.001000 sec
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestRef3DPtg
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestRef3DPtg
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.00 sec
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestReferencePtg
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestReferencePtg
[junitlauncher] Tests run: 4, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.013000 sec
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestUnionPtg
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.formula.ptg.TestUnionPtg
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.001000 sec
[junitlauncher] Running org.apache.poi.ss.formula.udf.TestUDFFinder
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.formula.udf.TestUDFFinder
[junitlauncher] Tests run: 4, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.002000 sec
[junitlauncher] Running org.apache.poi.ss.usermodel.TestDataFormatter
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.usermodel.TestDataFormatter
[junitlauncher] Tests run: 45, Failures: 0, Aborted: 0, Skipped: 1, Time 
elapsed: 0.634000 sec
[junitlauncher] Running org.apache.poi.ss.usermodel.TestDateUtil
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.usermodel.TestDateUtil
[junitlauncher] Tests run: 26, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.022000 sec
[junitlauncher] Running org.apache.poi.ss.usermodel.TestExcelStyleDateFormatter
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.usermodel.TestExcelStyleDateFormatter
[junitlauncher] Tests run: 124, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.079000 sec
[junitlauncher] Running org.apache.poi.ss.usermodel.TestFractionFormat
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.usermodel.TestFractionFormat
[junitlauncher] Tests run: 5, Failures: 0, Aborted: 0, Skipped: 1, Time 
elapsed: 0.339000 sec
[junitlauncher] Running org.apache.poi.ss.usermodel.TestHSSFBorderStyle
[junitlauncher] 
[junitlauncher] Running org.apache.poi.ss.usermodel.TestHSSFBorderStyle
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time 
elapsed: 0.001000 sec

Re: [PR] BugZilla 67646 - allow append rows to streaming workbooks [poi]

2024-02-26 Thread via GitHub 


pjfanning commented on PR #600:
URL: https://github.com/apache/poi/pull/600#issuecomment-1964646892

   > Changing the return type of getRow() could break user code as it is a 
public method in a public class, so I think this can not be approved as it is 
now.
   > 
   > IMHO, we also need a junit test for this that tests the new functionality.
   > 
   > There are also a couple of other things to clean up, like spelling errors 
introduced by the PR and directly throwing RuntimeException. I think we should 
not throw RuntimeException in any of these cases. I don't know if the other 
committers agree with the exception changes that I have proposed instead.
   
   if there is no test - then we shouldn't merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: [PR] BugZilla 67646 - allow append rows to streaming workbooks [poi]

2024-02-26 Thread via GitHub 


pjfanning commented on PR #600:
URL: https://github.com/apache/poi/pull/600#issuecomment-1964644955

   this has a similar set of changes to https://github.com/apache/poi/pull/528
   
   we can't accept PRs that arbitrarily change unrelated code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: [PR] BugZilla 67646 - allow append rows to streaming workbooks [poi]

2024-02-26 Thread via GitHub 


pjfanning commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1502986484


##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -215,8 +220,13 @@ public void removeRow(Row row) {
  * @return Row representing the rownumber or null if its not defined on 
the sheet
  */
 @Override
-public SXSSFRow getRow(int rownum) {

Review Comment:
   -1 this cannot be changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: [PR] BugZilla 67646 - allow append rows to streaming workbooks [poi]

2024-02-26 Thread via GitHub 


xzel23 commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1502753906


##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -166,11 +167,11 @@ public SXSSFRow createRow(int rownum) {
 "in the range [0," + _writer.getLastFlushedRow() + 
"] that is already written to disk.");
 }
 
-// attempt to overwrite an existing row in the input template
+// attempt to overwrite a existing row in the input template

Review Comment:
   Why was the comment changed? "An existing" is correct.



##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -1798,7 +1814,7 @@ public CellRange removeArrayFormula(Cell 
cell) {
 // corrupted .xlsx files as rows appear multiple times in the 
resulting sheetX.xml files
 // return _sh.removeArrayFormula(cell);
 
-throw new IllegalStateException("Not Implemented");
+throw new RuntimeException("Not Implemented");

Review Comment:
   same as above



##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -1169,7 +1180,7 @@ public boolean isDisplayRowColHeadings() {
  * Breaks occur above the specified row and left of the specified column 
inclusive.
  *
  * For example, {@code sheet.setColumnBreak(2);} breaks the sheet into two 
parts
- * with columns A,B,C in the first and D,E,... in the second. Similar, 
{@code sheet.setRowBreak(2);}
+ * with columns A,B,C in the first and D,E,... in the second. Simuilar, 
{@code sheet.setRowBreak(2);}

Review Comment:
   please revert the typo



##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -1344,21 +1357,24 @@ public void groupRow(int fromRow, int toRow) {
 public void setRowOutlineLevel(int rownum, int level) {
 SXSSFRow row = _rows.get(rownum);
 row.setOutlineLevel(level);
-setWorksheetOutlineLevelRowIfNecessary((short) 
Math.min(Short.MAX_VALUE, level));
+if(level > 0 && level > outlineLevelRow) {
+outlineLevelRow = level;
+setWorksheetOutlineLevelRow();
+}
 }
 
-private void setWorksheetOutlineLevelRowIfNecessary(final short levelRow) {
+private void setWorksheetOutlineLevelRow() {
 CTWorksheet ct = _sh.getCTWorksheet();
 CTSheetFormatPr pr = ct.isSetSheetFormatPr() ?
 ct.getSheetFormatPr() :
 ct.addNewSheetFormatPr();
-if(levelRow > _sh.getSheetFormatPrOutlineLevelRow()) {
-pr.setOutlineLevelRow(levelRow);
+if(outlineLevelRow > 0) {
+pr.setOutlineLevelRow((short)outlineLevelRow);
 }
 }
 
 /**
- * Ungroup a range of rows that were previously grouped
+ * Ungroup a range of rows that were previously groupped

Review Comment:
   please revert this line



##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -215,8 +220,13 @@ public void removeRow(Row row) {
  * @return Row representing the rownumber or null if its not defined on 
the sheet
  */
 @Override
-public SXSSFRow getRow(int rownum) {

Review Comment:
   This might break user code.



##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -1032,7 +1043,7 @@ public void shiftRows(int startRow, int endRow, int n) {
 @NotImplemented
 @Override
 public void shiftRows(int startRow, int endRow, int n, boolean 
copyRowHeight, boolean resetOriginalRowHeight) {
-throw new IllegalStateException("Not Implemented");
+throw new RuntimeException("Not Implemented");

Review Comment:
   UnsupportedOperationException



##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -205,6 +206,10 @@ public void removeRow(Row row) {
 return;
 }
 }
+   // BugZilla 67646: allow reading all the content
+if (row.getSheet() == _sh) {
+   _sh.removeRow(row);
+}

Review Comment:
   I don't understand the intent here. row.getSheet() is checked right at the 
start of the method. And the row is removed in the loop. AFAIK the row is not 
updated when that happens, so row.getSheet() will still return `this`. So what 
should happen here?



##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -1783,7 +1799,7 @@ public CellRange setArrayFormula(String 
formula, CellRangeAddres
 // corrupted .xlsx files as rows appear multiple times in the 
resulting sheetX.xml files
 // return _sh.setArrayFormula(formula, range);
 
-throw new IllegalStateException("Not Implemented");
+throw new RuntimeException("Not Implemented");

Review Comment:
   This should rather be UnsopportedOperationException. IllegalStateException 
is not optimal, but

[Bug 67646] Append rows in SXSSF workbook does not work

2024-02-26 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=67646

--- Comment #2 from Jan Lolling  ---
I have created a pull request: https://github.com/apache/poi/pull/600

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[PR] BugZilla 67646 - allow append rows to streaming workbooks [poi]

2024-02-26 Thread via GitHub 


jlolling opened a new pull request, #600:
URL: https://github.com/apache/poi/pull/600

   This patch works already in productive software.
   It allows to read a workbook using streaming workbook and append rows to it.
   The problem was the pointer to the last row was not set correctly in the 
SXSSFSheet.
   It is fixed now and the code changes are marked with the Bugzilla ticket id.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 55324] formula returning #VALUE

2024-02-26 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=55324

Matafagafo  changed:

   What|Removed |Added

 CC||matafag...@yahoo.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 55747] nested function in IF's in formulas produce #VALUE! error in excel

2024-02-26 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=55747

Matafagafo  changed:

   What|Removed |Added

 CC||matafag...@yahoo.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 66679] Cells without explicit style use column style as default

2024-02-26 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=66679

Matafagafo  changed:

   What|Removed |Added

 CC||matafag...@yahoo.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 57390] Match function with array argument in formula results in "File error: data may have been lost"

2024-02-26 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=57390

Matafagafo  changed:

   What|Removed |Added

 CC||matafag...@yahoo.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 67774] Support empty string ContentType in OPC package

2024-02-26 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=67774

Matafagafo  changed:

   What|Removed |Added

 CC||matafag...@yahoo.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org