[GitHub] [poi] dependabot[bot] commented on pull request #420: Bump mockito-core from 4.11.0 to 5.0.0
dependabot[bot] commented on PR #420: URL: https://github.com/apache/poi/pull/420#issuecomment-1384477304 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #422: Bump Saxon-HE from 11.4 to 12.0
dependabot[bot] commented on PR #422: URL: https://github.com/apache/poi/pull/422#issuecomment-1384477283 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #420: Bump mockito-core from 4.11.0 to 5.0.0
asfgit closed pull request #420: Bump mockito-core from 4.11.0 to 5.0.0 URL: https://github.com/apache/poi/pull/420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #421: Bump woodstox-core from 6.4.0 to 6.5.0
dependabot[bot] commented on PR #421: URL: https://github.com/apache/poi/pull/421#issuecomment-1384477261 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #422: Bump Saxon-HE from 11.4 to 12.0
asfgit closed pull request #422: Bump Saxon-HE from 11.4 to 12.0 URL: https://github.com/apache/poi/pull/422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #421: Bump woodstox-core from 6.4.0 to 6.5.0
asfgit closed pull request #421: Bump woodstox-core from 6.4.0 to 6.5.0 URL: https://github.com/apache/poi/pull/421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #421: Bump woodstox-core from 6.4.0 to 6.5.0
dependabot[bot] opened a new pull request, #421: URL: https://github.com/apache/poi/pull/421 Bumps [woodstox-core](https://github.com/FasterXML/woodstox) from 6.4.0 to 6.5.0. Commits https://github.com/FasterXML/woodstox/commit/830654b03458d7bbb3d83fc72d2ef44021db32b5;>830654b [maven-release-plugin] prepare release woodstox-core-6.5.0 https://github.com/FasterXML/woodstox/commit/168eb4b47996eed6e1bcc2ad57f995b40ad04c87;>168eb4b Prepare for Woodstox 6.5.0 release https://github.com/FasterXML/woodstox/commit/c8e64cb146b3902aec0a88c9fd2b387c18bf8f58;>c8e64cb Revert Declare osgi.serviceloader.registrar requirement as optional. (https://github-redirect.dependabot.com/FasterXML/woodstox/issues/155;>#155)... https://github.com/FasterXML/woodstox/commit/2ebb4a5387d206f21fe0dec7987b55c4899887d1;>2ebb4a5 Update master to 6.5.0-SNAPSHOT https://github.com/FasterXML/woodstox/commit/fd835de89d25b55a9396a07df51608a62ae02788;>fd835de fuzzing: add CIFuzz (https://github-redirect.dependabot.com/FasterXML/woodstox/issues/161;>#161) https://github.com/FasterXML/woodstox/commit/44a66e99fc18bdc56dbd48ba3f94f1b569f28710;>44a66e9 Release note update (actually https://github-redirect.dependabot.com/FasterXML/woodstox/issues/160;>#160 and not 162) https://github.com/FasterXML/woodstox/commit/9438a39be28011f4f792b9ec91ff8fdb1602fed3;>9438a39 Merge branch '5.3' https://github.com/FasterXML/woodstox/commit/415d2aa64c907453e2df43b726f13b6c4fe73535;>415d2aa Update release notes wrt https://github-redirect.dependabot.com/FasterXML/woodstox/issues/162;>#162 https://github.com/FasterXML/woodstox/commit/1717fd5c1fb1f84d2131e534831651caf5568b2a;>1717fd5 update release notes https://github.com/FasterXML/woodstox/commit/76435d4f995721c8cbb2c28f2ed01a33e332c15a;>76435d4 Merge branch '5.3' Additional commits viewable in https://github.com/FasterXML/woodstox/compare/woodstox-core-6.4.0...woodstox-core-6.5.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #420: Bump mockito-core from 4.11.0 to 5.0.0
dependabot[bot] opened a new pull request, #420: URL: https://github.com/apache/poi/pull/420 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.11.0 to 5.0.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's releases. v5.0.0 Mockito 5: prepare for future JDK versions For a while now, we have seen an increase in problems/incompatibilities with recent versions of the JDK due to our usage of JVM-internal API. Most notably, JDK 17 made some changes which are incompatible with the current subclass mockmaker. Therefore, to prepare for the future of JDK, we are making some core changes to ensure Mockito keeps on working. Switch the default mockmaker to mockito-inline Back in Mockito 2.7.6, we published a new mockmaker based on the inline bytecode principle. This mockmaker creates mocks manipulating bytecode equivalent within the original class such that its method implementations hook into the normal Mockito machinery. As a comparison, the subclass mockmaker generates real subclasses for mocks, to mimic the same behavior. While the approaches are similar, the inline mockmaker avoids certain restrictions that the JDK imposes. For example, it does not violate module boundaries (introduced in JDK 9, but more heavily used in JDK 17) and avoids the leaking of the creation of the subclass. Massive thanks to community member https://github.com/reta;>@reta who implemented this change. When should I still be using the subclass mockmaker? There are legitimate remaining use cases for the subclass mockmaker. For example, on the Graal VM's native image, the inline mockmaker will not work and the subclass mockmaker is the appropriate choice. Additionally, if you would like to avoid mocking final classes, using the subclass mockmaker is a possibibility. Note however that if you solely want to use the subclass mockmaker to avoid mocking final, you will run into the above mentioned issues on JDK 17+. We want to leave this choice up to our users, which is why we will keep on supporting the subclass mockmaker. If you want to use the subclass mockmaker instead, you can use the new mockito-subclass artifact (published https://search.maven.org/artifact/org.mockito/mockito-subclass;>on Maven Central along with all our other artifacts). Update the minimum supported Java version to 11 Mockito 4 supports Java 8 and above. Similar to other open source projects, we are moving away from JDK 8 and to newer versions. The primary reason for moving away from JDK 8 is the increasing maintenance costs with keeping our own infrastructure working. Lately we have been running into more and more JDK 8 breakages. Additionally, while we want to support the newest JDK API's, our current solution to support both JDK 8 and newer versions causes https://github-redirect.dependabot.com/mockito/mockito/issues/2798;>issues with the SecurityManager. Since we want Mockito to work on the newest version and more and more businesses adopting JDK 11, we have decided to make the switch as well. Massive thanks to community member https://github.com/reta;>@reta who implemented this change. What should I do if I still run JDK 8? For JDK 8 and below, you can keep on using Mockito 4. This is similar to if you are using JDK 6, for which you can keep on using Mockito 2. The changes in Mockito 5 (for now) are primarily focused on the latest JDK versions, which means the API differences between Mockito 4 and 5 are minimal. However, over time this will most likely widen, so we do recommend adopting JDK 11 in the future. New type() method on ArgumentMatcher One of our most used public API's for customizing Mockito is the https://javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/ArgumentMatcher.html;>ArgumentMatcher interface. The interface allows you to define a custom matcher, which you can pass into method arguments to provide more targeted matches. One major shortcoming of the ArgumentMatcher was the lack of varargs support. ... (truncated) Commits https://github.com/mockito/mockito/commit/adf528d173f8b763fcd4fedab245ed485b465211;>adf528d Bump versions.bytebuddy from 1.12.21 to 1.12.22 (https://github-redirect.dependabot.com/mockito/mockito/issues/2864;>#2864) https://github.com/mockito/mockito/commit/2418419a1915bd234332eac2b4d5de85622d4699;>2418419 Bump versions.junitJupiter from 5.9.1 to 5.9.2 (https://github-redirect.dependabot.com/mockito/mockito/issues/2858;>#2858) https://github.com/mockito/mockito/commit/3d40cd51d3982e33f7c2a2670c65d28233ceb66e;>3d40cd5 Bump junit-platform-launcher from 1.9.1 to 1.9.2 (https://github-redirect.dependabot.com/mockito/mockito/issues/2859;>#2859) https://github.com/mockito/mockito/commit/9bec8e3a1a0f57e4baa9b64825d67641e9eb2d5e;>9bec8e3 Bump versions.errorprone from 2.17.0 to
[GitHub] [poi] dependabot[bot] opened a new pull request, #422: Bump Saxon-HE from 11.4 to 12.0
dependabot[bot] opened a new pull request, #422: URL: https://github.com/apache/poi/pull/422 Bumps Saxon-HE from 11.4 to 12.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #419: Bump xmlunit-core from 2.9.0 to 2.9.1
dependabot[bot] commented on PR #419: URL: https://github.com/apache/poi/pull/419#issuecomment-1378811551 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #418: Bump ant-junitlauncher from 1.10.12 to 1.10.13
dependabot[bot] commented on PR #418: URL: https://github.com/apache/poi/pull/418#issuecomment-1378811495 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #416: Bump junitVersion from 5.9.1 to 5.9.2
dependabot[bot] commented on PR #416: URL: https://github.com/apache/poi/pull/416#issuecomment-1378811398 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #419: Bump xmlunit-core from 2.9.0 to 2.9.1
asfgit closed pull request #419: Bump xmlunit-core from 2.9.0 to 2.9.1 URL: https://github.com/apache/poi/pull/419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #417: Bump ant from 1.10.12 to 1.10.13
dependabot[bot] commented on PR #417: URL: https://github.com/apache/poi/pull/417#issuecomment-1378811451 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #418: Bump ant-junitlauncher from 1.10.12 to 1.10.13
asfgit closed pull request #418: Bump ant-junitlauncher from 1.10.12 to 1.10.13 URL: https://github.com/apache/poi/pull/418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #417: Bump ant from 1.10.12 to 1.10.13
asfgit closed pull request #417: Bump ant from 1.10.12 to 1.10.13 URL: https://github.com/apache/poi/pull/417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #416: Bump junitVersion from 5.9.1 to 5.9.2
asfgit closed pull request #416: Bump junitVersion from 5.9.1 to 5.9.2 URL: https://github.com/apache/poi/pull/416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #419: Bump xmlunit-core from 2.9.0 to 2.9.1
dependabot[bot] opened a new pull request, #419: URL: https://github.com/apache/poi/pull/419 Bumps [xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.9.0 to 2.9.1. Release notes Sourced from https://github.com/xmlunit/xmlunit/releases;>xmlunit-core's releases. XMLUnit for Java 2.9.1 fixed some AssertJ tests that didn't work on Windows. Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/252;>#252 and PR https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/253;>#253 by https://github.com/Boiarshinov;>@Boiarshinov added overloads to ElementSelectors.byXPath that accept a XPathEngine argument. Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/255;>#255 added Cyclone DX SBOMs to release artifacts Changelog Sourced from https://github.com/xmlunit/xmlunit/blob/main/RELEASE_NOTES.md;>xmlunit-core's changelog. XMLUnit for Java 2.9.1 - /Released 2023-01-10/ fixed some AssertJ tests that didn't work on Windows. Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/252;>#252 and PR https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/253;>#253 by https://github.com/Boiarshinov;>@Boiarshinov added overloads to ElementSelectors.byXPath that accept a XPathEngine argument. Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/255;>#255 added Cyclone DX SBOMs to release artifacts Commits https://github.com/xmlunit/xmlunit/commit/9118af20aeaa6b8665be9c13fc84c1fd25b51acd;>9118af2 prepare XMLUnit 2.9.1 https://github.com/xmlunit/xmlunit/commit/c8fcf0a5575af8d434f43a2c051a9814b51df5e3;>c8fcf0a fix remaining javadoc warnings raised by Java 17 https://github.com/xmlunit/xmlunit/commit/f4aa630bb5238dfc8fd963f86eddb8fde459ee72;>f4aa630 next batch of fixed javadoc warnings, just a few hundred left https://github.com/xmlunit/xmlunit/commit/5e53d0fb2c8958cc416bc72cda68fba5be58d714;>5e53d0f chip away on javadoc warnings found by Java 17 https://github.com/xmlunit/xmlunit/commit/78f66d2d7a2490f3b459a586afb132c55c90d3ed;>78f66d2 allow javadocs to be built using Java 17 https://github.com/xmlunit/xmlunit/commit/737789db2aa06029c4ec93d7e293545d0fa2f851;>737789d reference to a third jar is misleading https://github.com/xmlunit/xmlunit/commit/1cced6e34cd225ed2f4dff672bff59a468e70382;>1cced6e provide descriptions for all modules https://github.com/xmlunit/xmlunit/commit/0baf9e9078bdf1f34f92b36b6118b6f5c1bccf02;>0baf9e9 update javadoc plugin, fix new javadoc warnings https://github.com/xmlunit/xmlunit/commit/505f014b13e60ae215473a37f7b0d9587308da8a;>505f014 javadoc warning https://github.com/xmlunit/xmlunit/commit/98dc0be49204fe14823fc7c278e62b211629edaf;>98dc0be really hide cyclonedx plugin when building on Java 7 Additional commits viewable in https://github.com/xmlunit/xmlunit/compare/v2.9.0...v2.9.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on
[GitHub] [poi] dependabot[bot] opened a new pull request, #418: Bump ant-junitlauncher from 1.10.12 to 1.10.13
dependabot[bot] opened a new pull request, #418: URL: https://github.com/apache/poi/pull/418 Bumps ant-junitlauncher from 1.10.12 to 1.10.13. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #417: Bump ant from 1.10.12 to 1.10.13
dependabot[bot] opened a new pull request, #417: URL: https://github.com/apache/poi/pull/417 Bumps ant from 1.10.12 to 1.10.13. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #416: Bump junitVersion from 5.9.1 to 5.9.2
dependabot[bot] opened a new pull request, #416: URL: https://github.com/apache/poi/pull/416 Bumps `junitVersion` from 5.9.1 to 5.9.2. Updates `junit-jupiter` from 5.9.1 to 5.9.2 Release notes Sourced from https://github.com/junit-team/junit5/releases;>junit-jupiter's releases. JUnit 5.9.2 = Platform 1.9.2 + Jupiter 5.9.2 + Vintage 5.9.2 See http://junit.org/junit5/docs/5.9.2/release-notes/;>Release Notes. Commits https://github.com/junit-team/junit5/commit/8ed3c66c7eb20b835cf92f50a7bf8830838c462e;>8ed3c66 Release 5.9.2 https://github.com/junit-team/junit5/commit/742f99fcce6d8b8fbd38c7f541c55bdda771e220;>742f99f Prepare 5.9.2 release notes https://github.com/junit-team/junit5/commit/a9a3cf5fb75ad9adf8c197224981226db8f41181;>a9a3cf5 Fix bug and polish contribution https://github.com/junit-team/junit5/commit/825ea38857bff2dcbc200c6ceb7972dbc89482b0;>825ea38 Introduce new @MethodSource syntax to differentiate overloaded local factor... https://github.com/junit-team/junit5/commit/0c40f5ef057c90a8d4b2249dd9a0b6e289426424;>0c40f5e Polish Javadoc https://github.com/junit-team/junit5/commit/7d54016421d611a13db8196ea9625dfe1d9036c8;>7d54016 Update codecov-action https://github.com/junit-team/junit5/commit/bfeeac4d4142a3680737626a0ccdb9a708cabb2a;>bfeeac4 Remove duplicate copyright comment https://github.com/junit-team/junit5/commit/b0d9083315426b69d2bf38153987cdeb83460257;>b0d9083 Format integration test projects with Spotless as well https://github.com/junit-team/junit5/commit/c4ed325cb2ff825ecd0bda3870cf8444bdf646f0;>c4ed325 Update copyright https://github.com/junit-team/junit5/commit/0e3a1d32e504c63a09dbafc8c1926b66df417774;>0e3a1d3 Update upload-artifact action Additional commits viewable in https://github.com/junit-team/junit5/compare/r5.9.1...r5.9.2;>compare view Updates `junit-jupiter-api` from 5.9.0 to 5.9.2 Release notes Sourced from https://github.com/junit-team/junit5/releases;>junit-jupiter-api's releases. JUnit 5.9.2 = Platform 1.9.2 + Jupiter 5.9.2 + Vintage 5.9.2 See http://junit.org/junit5/docs/5.9.2/release-notes/;>Release Notes. JUnit 5.9.1 = Platform 1.9.1 + Jupiter 5.9.1 + Vintage 5.9.1 See http://junit.org/junit5/docs/5.9.1/release-notes/;>Release Notes. Commits https://github.com/junit-team/junit5/commit/8ed3c66c7eb20b835cf92f50a7bf8830838c462e;>8ed3c66 Release 5.9.2 https://github.com/junit-team/junit5/commit/742f99fcce6d8b8fbd38c7f541c55bdda771e220;>742f99f Prepare 5.9.2 release notes https://github.com/junit-team/junit5/commit/a9a3cf5fb75ad9adf8c197224981226db8f41181;>a9a3cf5 Fix bug and polish contribution https://github.com/junit-team/junit5/commit/825ea38857bff2dcbc200c6ceb7972dbc89482b0;>825ea38 Introduce new @MethodSource syntax to differentiate overloaded local factor... https://github.com/junit-team/junit5/commit/0c40f5ef057c90a8d4b2249dd9a0b6e289426424;>0c40f5e Polish Javadoc https://github.com/junit-team/junit5/commit/7d54016421d611a13db8196ea9625dfe1d9036c8;>7d54016 Update codecov-action https://github.com/junit-team/junit5/commit/bfeeac4d4142a3680737626a0ccdb9a708cabb2a;>bfeeac4 Remove duplicate copyright comment https://github.com/junit-team/junit5/commit/b0d9083315426b69d2bf38153987cdeb83460257;>b0d9083 Format integration test projects with Spotless as well https://github.com/junit-team/junit5/commit/c4ed325cb2ff825ecd0bda3870cf8444bdf646f0;>c4ed325 Update copyright https://github.com/junit-team/junit5/commit/0e3a1d32e504c63a09dbafc8c1926b66df417774;>0e3a1d3 Update upload-artifact action Additional commits viewable in https://github.com/junit-team/junit5/compare/r5.9.0...r5.9.2;>compare view Updates `junit-jupiter-engine` from 5.9.0 to 5.9.2 Release notes Sourced from https://github.com/junit-team/junit5/releases;>junit-jupiter-engine's releases. JUnit 5.9.2 = Platform 1.9.2 + Jupiter 5.9.2 + Vintage 5.9.2 See http://junit.org/junit5/docs/5.9.2/release-notes/;>Release Notes. JUnit 5.9.1 = Platform 1.9.1 + Jupiter 5.9.1 + Vintage 5.9.1 See http://junit.org/junit5/docs/5.9.1/release-notes/;>Release Notes. Commits https://github.com/junit-team/junit5/commit/8ed3c66c7eb20b835cf92f50a7bf8830838c462e;>8ed3c66 Release 5.9.2 https://github.com/junit-team/junit5/commit/742f99fcce6d8b8fbd38c7f541c55bdda771e220;>742f99f Prepare 5.9.2 release notes https://github.com/junit-team/junit5/commit/a9a3cf5fb75ad9adf8c197224981226db8f41181;>a9a3cf5 Fix bug and polish contribution https://github.com/junit-team/junit5/commit/825ea38857bff2dcbc200c6ceb7972dbc89482b0;>825ea38 Introduce new @MethodSource syntax to differentiate overloaded local factor... https://github.com/junit-team/junit5/commit/0c40f5ef057c90a8d4b2249dd9a0b6e289426424;>0c40f5e Polish Javadoc
[GitHub] [poi] dependabot[bot] commented on pull request #415: Bump byte-buddy-agent from 1.12.20 to 1.12.21
dependabot[bot] commented on PR #415: URL: https://github.com/apache/poi/pull/415#issuecomment-1373888406 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #414: Bump byte-buddy from 1.12.20 to 1.12.21
dependabot[bot] commented on PR #414: URL: https://github.com/apache/poi/pull/414#issuecomment-1373888374 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #415: Bump byte-buddy-agent from 1.12.20 to 1.12.21
asfgit closed pull request #415: Bump byte-buddy-agent from 1.12.20 to 1.12.21 URL: https://github.com/apache/poi/pull/415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #414: Bump byte-buddy from 1.12.20 to 1.12.21
asfgit closed pull request #414: Bump byte-buddy from 1.12.20 to 1.12.21 URL: https://github.com/apache/poi/pull/414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #415: Bump byte-buddy-agent from 1.12.20 to 1.12.21
dependabot[bot] opened a new pull request, #415: URL: https://github.com/apache/poi/pull/415 Bumps [byte-buddy-agent](https://github.com/raphw/byte-buddy) from 1.12.20 to 1.12.21. Release notes Sourced from https://github.com/raphw/byte-buddy/releases;>byte-buddy-agent's releases. Byte Buddy 1.12.21 Create a Gradle source set for each JVM build automatically to reduce boilerplate. Fix Gradle plugin class loading to use correct class loader. Use updated release plugin to avoid outdated timestamp in jar. Changelog Sourced from https://github.com/raphw/byte-buddy/blob/master/release-notes.md;>byte-buddy-agent's changelog. Byte Buddy release notes Commits https://github.com/raphw/byte-buddy/commit/adb0638f70f074115579ce514c714697d6c6922c;>adb0638 [maven-release-plugin] prepare release byte-buddy-1.12.21 https://github.com/raphw/byte-buddy/commit/f326a3e909f838579a13d6a81f781f47a9babb6e;>f326a3e [release] Release new version https://github.com/raphw/byte-buddy/commit/5ffe97cd98d4dd2349946184c26cefbaca767db0;>5ffe97c Correct class loading and use maybe create for configuration. https://github.com/raphw/byte-buddy/commit/a070a5d19ffe1d20944214d3219f0c3c8ec2c8c0;>a070a5d Avoid class loader creation if not needed. https://github.com/raphw/byte-buddy/commit/cf84b72bd606f1f2051f895947e540f24fa03953;>cf84b72 Adjust plugin to configure implicit source set. https://github.com/raphw/byte-buddy/commit/deae82359148c16cd503b4e19a7eb310db5e0dfd;>deae823 Minor refactoring. https://github.com/raphw/byte-buddy/commit/283c195c26ce886f559cc6afde4cc2042a947cbc;>283c195 Avoid skipping Gradle plugin if no transformations are explicitly configured. https://github.com/raphw/byte-buddy/commit/a305b20987abc2f8755707398021c2ad2c08a4da;>a305b20 Add missing checksums. https://github.com/raphw/byte-buddy/commit/db03b3b7f5abfb7299b6162af5b34eb63d72032c;>db03b3b Merge pull request https://github-redirect.dependabot.com/raphw/byte-buddy/issues/1381;>#1381 from 0dinD/fix-gitignore-build-dir https://github.com/raphw/byte-buddy/commit/4a7fbb1ef8683afc5def4f564e0a8010f0bcb6aa;>4a7fbb1 Fix .gitignore rule for Gradle build directory Additional commits viewable in https://github.com/raphw/byte-buddy/compare/byte-buddy-1.12.20...byte-buddy-1.12.21;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #414: Bump byte-buddy from 1.12.20 to 1.12.21
dependabot[bot] opened a new pull request, #414: URL: https://github.com/apache/poi/pull/414 Bumps [byte-buddy](https://github.com/raphw/byte-buddy) from 1.12.20 to 1.12.21. Release notes Sourced from https://github.com/raphw/byte-buddy/releases;>byte-buddy's releases. Byte Buddy 1.12.21 Create a Gradle source set for each JVM build automatically to reduce boilerplate. Fix Gradle plugin class loading to use correct class loader. Use updated release plugin to avoid outdated timestamp in jar. Changelog Sourced from https://github.com/raphw/byte-buddy/blob/master/release-notes.md;>byte-buddy's changelog. Byte Buddy release notes Commits https://github.com/raphw/byte-buddy/commit/adb0638f70f074115579ce514c714697d6c6922c;>adb0638 [maven-release-plugin] prepare release byte-buddy-1.12.21 https://github.com/raphw/byte-buddy/commit/f326a3e909f838579a13d6a81f781f47a9babb6e;>f326a3e [release] Release new version https://github.com/raphw/byte-buddy/commit/5ffe97cd98d4dd2349946184c26cefbaca767db0;>5ffe97c Correct class loading and use maybe create for configuration. https://github.com/raphw/byte-buddy/commit/a070a5d19ffe1d20944214d3219f0c3c8ec2c8c0;>a070a5d Avoid class loader creation if not needed. https://github.com/raphw/byte-buddy/commit/cf84b72bd606f1f2051f895947e540f24fa03953;>cf84b72 Adjust plugin to configure implicit source set. https://github.com/raphw/byte-buddy/commit/deae82359148c16cd503b4e19a7eb310db5e0dfd;>deae823 Minor refactoring. https://github.com/raphw/byte-buddy/commit/283c195c26ce886f559cc6afde4cc2042a947cbc;>283c195 Avoid skipping Gradle plugin if no transformations are explicitly configured. https://github.com/raphw/byte-buddy/commit/a305b20987abc2f8755707398021c2ad2c08a4da;>a305b20 Add missing checksums. https://github.com/raphw/byte-buddy/commit/db03b3b7f5abfb7299b6162af5b34eb63d72032c;>db03b3b Merge pull request https://github-redirect.dependabot.com/raphw/byte-buddy/issues/1381;>#1381 from 0dinD/fix-gitignore-build-dir https://github.com/raphw/byte-buddy/commit/4a7fbb1ef8683afc5def4f564e0a8010f0bcb6aa;>4a7fbb1 Fix .gitignore rule for Gradle build directory Additional commits viewable in https://github.com/raphw/byte-buddy/compare/byte-buddy-1.12.20...byte-buddy-1.12.21;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #413: Bump com.dorongold.task-tree from 2.1.0 to 2.1.1
dependabot[bot] commented on PR #413: URL: https://github.com/apache/poi/pull/413#issuecomment-1370165229 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #413: Bump com.dorongold.task-tree from 2.1.0 to 2.1.1
asfgit closed pull request #413: Bump com.dorongold.task-tree from 2.1.0 to 2.1.1 URL: https://github.com/apache/poi/pull/413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #413: Bump com.dorongold.task-tree from 2.1.0 to 2.1.1
dependabot[bot] opened a new pull request, #413: URL: https://github.com/apache/poi/pull/413 Bumps com.dorongold.task-tree from 2.1.0 to 2.1.1. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #412: Bump graphics2d from 0.41 to 0.42
dependabot[bot] commented on PR #412: URL: https://github.com/apache/poi/pull/412#issuecomment-1367616626 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #412: Bump graphics2d from 0.41 to 0.42
asfgit closed pull request #412: Bump graphics2d from 0.41 to 0.42 URL: https://github.com/apache/poi/pull/412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #412: Bump graphics2d from 0.41 to 0.42
dependabot[bot] opened a new pull request, #412: URL: https://github.com/apache/poi/pull/412 Bumps [graphics2d](https://github.com/rototor/pdfbox-graphics2d) from 0.41 to 0.42. Commits https://github.com/rototor/pdfbox-graphics2d/commit/dcd44e3a643cd2e2198777b7e360ef9c8798de6f;>dcd44e3 [maven-release-plugin] prepare release pdfboxgraphics2d-parent-0.42 https://github.com/rototor/pdfbox-graphics2d/commit/f4914ebc03e620e812552ffcaec6b71d6bf740b4;>f4914eb Prepare README for release https://github.com/rototor/pdfbox-graphics2d/commit/6ce5ef88d539541760ce2275fcd1e31506c14c5f;>6ce5ef8 https://github-redirect.dependabot.com/rototor/pdfbox-graphics2d/issues/40;>#40: Correctly handle image interpolation and also respect this in the image ... https://github.com/rototor/pdfbox-graphics2d/commit/e5ab57d6a4ad4c60b5c36d43eecd2f216d96090b;>e5ab57d Upgrade to current batik version. https://github.com/rototor/pdfbox-graphics2d/commit/2a9cb49733f76784155c7b0c9b3ebc58c9cceec3;>2a9cb49 Upgrade PDFBox to current version. https://github.com/rototor/pdfbox-graphics2d/commit/7cd93c7ed58ed49a84f91093adeab8d79179abc9;>7cd93c7 https://github-redirect.dependabot.com/rototor/pdfbox-graphics2d/issues/46;>#46: Also override drawRect() and https://github.com/rototor/pdfbox-graphics2d/commit/1f801d8b8e9c925509afe29ffab94188374258e1;>1f801d8 https://github-redirect.dependabot.com/rototor/pdfbox-graphics2d/issues/44;>#44: Fix the focial point for the https://github.com/rototor/pdfbox-graphics2d/commit/f3869e131c014ab9740ae8e625ae25600b62ad44;>f3869e1 https://github-redirect.dependabot.com/rototor/pdfbox-graphics2d/issues/44;>#44: Testcases for the wrong focial point. https://github.com/rototor/pdfbox-graphics2d/commit/3846f162f1d46e02f1cffdc5775e625fd1398694;>3846f16 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/rototor/pdfbox-graphics2d/compare/pdfboxgraphics2d-parent-0.41...pdfboxgraphics2d-parent-0.42;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #409: Textruns not honouring highlight
pjfanning commented on PR #409: URL: https://github.com/apache/poi/pull/409#issuecomment-1366819338 Thanks - merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #411: Bump mockito-core from 4.10.0 to 4.11.0
dependabot[bot] commented on PR #411: URL: https://github.com/apache/poi/pull/411#issuecomment-1366819187 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #411: Bump mockito-core from 4.10.0 to 4.11.0
asfgit closed pull request #411: Bump mockito-core from 4.10.0 to 4.11.0 URL: https://github.com/apache/poi/pull/411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #409: Textruns not honouring highlight
asfgit closed pull request #409: Textruns not honouring highlight URL: https://github.com/apache/poi/pull/409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] yuval-perelman commented on pull request #403: ignoring errors on ReadOnlySharedStringsTable count parsing, nobody i…
yuval-perelman commented on PR #403: URL: https://github.com/apache/poi/pull/403#issuecomment-1366782908 @pjfanning looks like its common enough for me not to be the only one who ran into this issue in a relatively short period of time in a pretty small forum, I have no way of knowing how common it actually is. I suspect that a common system that generates XLSX generates malformed SST files, but so far I got no answer from the client who sent this file as to how that file was created. Thanks a lot for the fix, highly appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] yuval-perelman closed pull request #403: ignoring errors on ReadOnlySharedStringsTable count parsing, nobody i…
yuval-perelman closed pull request #403: ignoring errors on ReadOnlySharedStringsTable count parsing, nobody i… URL: https://github.com/apache/poi/pull/403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #411: Bump mockito-core from 4.10.0 to 4.11.0
dependabot[bot] opened a new pull request, #411: URL: https://github.com/apache/poi/pull/411 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.10.0 to 4.11.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's releases. v4.11.0 Changelog generated by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog Gradle Plugin 4.11.0 2022-12-28 - https://github.com/mockito/mockito/compare/v4.10.0...v4.11.0;>1 commit(s) by Andy Coates Improve vararg handling: approach 2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2807;>#2807)](https://github-redirect.dependabot.com/mockito/mockito/pull/2807;>mockito/mockito#2807) Mocking varargs method with any(String[].class) doesn't work as expected [(https://github-redirect.dependabot.com/mockito/mockito/issues/2796;>#2796)](https://github-redirect.dependabot.com/mockito/mockito/issues/2796;>mockito/mockito#2796) (Argument)Matchers regression from 1.10.19 to 2.18.3 for varargs [(https://github-redirect.dependabot.com/mockito/mockito/issues/1498;>#1498)](https://github-redirect.dependabot.com/mockito/mockito/issues/1498;>mockito/mockito#1498) Cannot verify varargs parameter as an array [(https://github-redirect.dependabot.com/mockito/mockito/issues/1222;>#1222)](https://github-redirect.dependabot.com/mockito/mockito/issues/1222;>mockito/mockito#1222) ArgumentCaptor can't capture varargs-arrays [(https://github-redirect.dependabot.com/mockito/mockito/issues/584;>#584)](https://github-redirect.dependabot.com/mockito/mockito/issues/584;>mockito/mockito#584) Verification of an empty varargs call fails when isNotNull() is used [(https://github-redirect.dependabot.com/mockito/mockito/issues/567;>#567)](https://github-redirect.dependabot.com/mockito/mockito/issues/567;>mockito/mockito#567) Commits https://github.com/mockito/mockito/commit/483e15f9f940716a85f2d58f6c28981136790c4e;>483e15f Add type() method to ArgumentMatcher (https://github-redirect.dependabot.com/mockito/mockito/issues/2807;>#2807) See full diff in https://github.com/mockito/mockito/compare/v4.10.0...v4.11.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] gffloodg commented on a diff in pull request #409: Textruns not honouring highlight
gffloodg commented on code in PR #409:
URL: https://github.com/apache/poi/pull/409#discussion_r1058339320
##
poi-ooxml/src/main/java/org/apache/poi/xslf/usermodel/XSLFTextRun.java:
##
@@ -158,6 +162,78 @@ private static void
fetchFontColor(CTTextCharacterProperties props, Consumer
fetchHighlightColor(props, val, shape, hasPlaceholder));
+}
+
+
+private static void fetchHighlightColor(CTTextCharacterProperties props,
Consumer val, XSLFShape shape, boolean hasPlaceholder) {
+if (props == null) {
+return;
+}
+
+final CTColor col = props.getHighlight();
+if (col == null) {
+return;
+}
+
+final CTSRgbColor rgbCol = col.getSrgbClr();
+final byte[] cols = rgbCol.getVal();
+final SolidPaint paint = DrawPaint.createSolidPaint(new Color(0xFF &
cols[0], 0xFF & cols[1], 0xFF & cols[2]));
+val.accept(paint);
+}
+
+/**
+ * Sets the font highlight (background) color for this text run -
convenience function
+ *
+ * @param color The highlight (background) color to set.
+ * @since POI 5.2.4
+ */
+@Override
+public void setHighlightColor(final Color color) {
+setHighlightColor(DrawPaint.createSolidPaint(color));
+}
+
+/**
+ * Set the highlight (background) color for this text run.
+ *
+ * @param color The highlight (background) color to set.
+ *
+ * @see org.apache.poi.sl.draw.DrawPaint#createSolidPaint(Color)
+ * @since POI 5.2.4
+ */
+@Override
+public void setHighlightColor(final PaintStyle color) {
+if (!(color instanceof SolidPaint)) {
+LOG.atWarn().log("Currently only SolidPaint is supported!");
+return;
Review Comment:
Updated and added tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] gffloodg commented on a diff in pull request #409: Textruns not honouring highlight
gffloodg commented on code in PR #409: URL: https://github.com/apache/poi/pull/409#discussion_r1058339152 ## poi-ooxml/src/main/java/org/apache/poi/xslf/usermodel/XSLFTextRun.java: ## @@ -158,6 +162,78 @@ private static void fetchFontColor(CTTextCharacterProperties props, Consumer fetchHighlightColor(props, val, shape, hasPlaceholder)); Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on a diff in pull request #409: Textruns not honouring highlight
pjfanning commented on code in PR #409: URL: https://github.com/apache/poi/pull/409#discussion_r1057895793 ## poi-ooxml/src/main/java/org/apache/poi/xslf/usermodel/XSLFTextRun.java: ## @@ -158,6 +162,78 @@ private static void fetchFontColor(CTTextCharacterProperties props, Consumer fetchHighlightColor(props, val, shape, hasPlaceholder)); Review Comment: can we rename the `val` variable to something more informative? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on a diff in pull request #409: Textruns not honouring highlight
pjfanning commented on code in PR #409:
URL: https://github.com/apache/poi/pull/409#discussion_r1057895126
##
poi-ooxml/src/main/java/org/apache/poi/xslf/usermodel/XSLFTextRun.java:
##
@@ -158,6 +162,78 @@ private static void
fetchFontColor(CTTextCharacterProperties props, Consumer
fetchHighlightColor(props, val, shape, hasPlaceholder));
+}
+
+
+private static void fetchHighlightColor(CTTextCharacterProperties props,
Consumer val, XSLFShape shape, boolean hasPlaceholder) {
+if (props == null) {
+return;
+}
+
+final CTColor col = props.getHighlight();
+if (col == null) {
+return;
+}
+
+final CTSRgbColor rgbCol = col.getSrgbClr();
+final byte[] cols = rgbCol.getVal();
+final SolidPaint paint = DrawPaint.createSolidPaint(new Color(0xFF &
cols[0], 0xFF & cols[1], 0xFF & cols[2]));
+val.accept(paint);
+}
+
+/**
+ * Sets the font highlight (background) color for this text run -
convenience function
+ *
+ * @param color The highlight (background) color to set.
+ * @since POI 5.2.4
+ */
+@Override
+public void setHighlightColor(final Color color) {
+setHighlightColor(DrawPaint.createSolidPaint(color));
+}
+
+/**
+ * Set the highlight (background) color for this text run.
+ *
+ * @param color The highlight (background) color to set.
+ *
+ * @see org.apache.poi.sl.draw.DrawPaint#createSolidPaint(Color)
+ * @since POI 5.2.4
+ */
+@Override
+public void setHighlightColor(final PaintStyle color) {
+if (!(color instanceof SolidPaint)) {
+LOG.atWarn().log("Currently only SolidPaint is supported!");
+return;
Review Comment:
I'm not sure - can we make this an exception? IllegalArgumentException
maybe. Needs to be in the javadoc, one way or another.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] gffloodg commented on a diff in pull request #409: Textruns not honouring highlight
gffloodg commented on code in PR #409:
URL: https://github.com/apache/poi/pull/409#discussion_r1057764538
##
poi/src/main/java/org/apache/poi/sl/usermodel/TextRun.java:
##
@@ -79,6 +80,37 @@ enum FieldType {
void setFontColor(PaintStyle color);
+/**
+ * Returns the font highlight (background) color for this text run.
+ * This returns a {@link SolidPaint}, or null if no highlight is set.
Review Comment:
Code updated, ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning closed pull request #410: try to rebuild module-info classes even when java 8 is used
pjfanning closed pull request #410: try to rebuild module-info classes even when java 8 is used URL: https://github.com/apache/poi/pull/410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #410: try to rebuild module-info classes even when java 8 is used
pjfanning commented on PR #410: URL: https://github.com/apache/poi/pull/410#issuecomment-1364756347 merged with https://github.com/apache/poi/commit/edee60d87a0f3b6d54d056a8f63dd42a386eb593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] gffloodg commented on a diff in pull request #409: Textruns not honouring highlight
gffloodg commented on code in PR #409:
URL: https://github.com/apache/poi/pull/409#discussion_r1056812245
##
poi/src/main/java/org/apache/poi/sl/usermodel/TextRun.java:
##
@@ -79,6 +80,37 @@ enum FieldType {
void setFontColor(PaintStyle color);
+/**
+ * Returns the font highlight (background) color for this text run.
+ * This returns a {@link SolidPaint}, or null if no highlight is set.
Review Comment:
Ok sure, let me take a look and update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on a diff in pull request #409: Textruns not honouring highlight
pjfanning commented on code in PR #409:
URL: https://github.com/apache/poi/pull/409#discussion_r1056789642
##
poi/src/main/java/org/apache/poi/sl/usermodel/TextRun.java:
##
@@ -79,6 +80,37 @@ enum FieldType {
void setFontColor(PaintStyle color);
+/**
+ * Returns the font highlight (background) color for this text run.
+ * This returns a {@link SolidPaint}, or null if no highlight is set.
Review Comment:
You could create a new interface in this package called
`HightlightColorSupport` or something similar. Add these methods there instead.
HSLFTextRun will not implement HightlightColorSupport. XSLFTextRun will.
DrawTextParagraph can check if the text run is an instanceof
HightlightColorSupport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] gffloodg commented on a diff in pull request #409: Textruns not honouring highlight
gffloodg commented on code in PR #409:
URL: https://github.com/apache/poi/pull/409#discussion_r1056419343
##
poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFTextRun.java:
##
@@ -440,6 +440,23 @@ public void setFontColor(PaintStyle color) {
setFontColor(rgb);
}
+
+@Override
+public PaintStyle getHighlightColor() {
+return null;
+}
+
+@Override
+public void setHighlightColor(final Color color) {
Review Comment:
I agree, but the common rendering in DrawTextParagraph does not have access
to the XSLF* classes, so cannot be cast - I chose this as a tradeoff. If you
have a better suggestion then Im happy to adjust as needed.
##
poi-ooxml/src/main/java/org/apache/poi/xslf/usermodel/XSLFTextRun.java:
##
@@ -157,6 +160,52 @@ private static void
fetchFontColor(CTTextCharacterProperties props, Consumer
[GitHub] [poi] pjfanning commented on a diff in pull request #409: Textruns not honouring highlight
pjfanning commented on code in PR #409:
URL: https://github.com/apache/poi/pull/409#discussion_r1056202363
##
poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFTextRun.java:
##
@@ -440,6 +440,23 @@ public void setFontColor(PaintStyle color) {
setFontColor(rgb);
}
+
+@Override
+public PaintStyle getHighlightColor() {
+return null;
+}
+
+@Override
+public void setHighlightColor(final Color color) {
Review Comment:
why add these methods? - if this stuff is only supported on XSLFTextRun,
then only that class should have these methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on a diff in pull request #409: Textruns not honouring highlight
pjfanning commented on code in PR #409: URL: https://github.com/apache/poi/pull/409#discussion_r1056201051 ## poi-ooxml/src/main/java/org/apache/poi/xslf/usermodel/XSLFTextRun.java: ## @@ -157,6 +160,52 @@ private static void fetchFontColor(CTTextCharacterProperties props, Consumer
[GitHub] [poi] gffloodg opened a new pull request, #409: Textruns not honouring highlight
gffloodg opened a new pull request, #409: URL: https://github.com/apache/poi/pull/409 This PR adds support for getting/setting the highlight color in TextRuns. It also adds support for rendering of the same. As usual, appropriate tests also added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #408: Increase performance of StylesTable.putStyle by 100%
pjfanning commented on PR #408: URL: https://github.com/apache/poi/pull/408#issuecomment-1362182669 Thanks - merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #408: Increase performance of StylesTable.putStyle by 100%
asfgit closed pull request #408: Increase performance of StylesTable.putStyle by 100% URL: https://github.com/apache/poi/pull/408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] mirraj2 opened a new pull request, #408: Increase performance of StylesTable.putStyle by 100%
mirraj2 opened a new pull request, #408: URL: https://github.com/apache/poi/pull/408 When exporting a large spreadsheet, this method took 2.3 seconds of execution time. See VisualVM screenshot: https://user-images.githubusercontent.com/847857/209012831-52c35859-aa14-4ef1-91b1-ef889409af68.png;> This change would ensure that only one linear lookup is made into the xfs collection instead of the current two lookups per invocation of this method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #407: Bump org.cyclonedx.bom from 1.7.2 to 1.7.3
dependabot[bot] commented on PR #407: URL: https://github.com/apache/poi/pull/407#issuecomment-1361123924 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #407: Bump org.cyclonedx.bom from 1.7.2 to 1.7.3
asfgit closed pull request #407: Bump org.cyclonedx.bom from 1.7.2 to 1.7.3 URL: https://github.com/apache/poi/pull/407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #407: Bump org.cyclonedx.bom from 1.7.2 to 1.7.3
dependabot[bot] opened a new pull request, #407: URL: https://github.com/apache/poi/pull/407 Bumps org.cyclonedx.bom from 1.7.2 to 1.7.3. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] StanBertrand commented on pull request #406: Add the ability to avoid adding cellStyle to improve writing performance
StanBertrand commented on PR #406: URL: https://github.com/apache/poi/pull/406#issuecomment-1347211735 Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] StanBertrand closed pull request #406: Add the ability to avoid adding cellStyle to improve writing performance
StanBertrand closed pull request #406: Add the ability to avoid adding cellStyle to improve writing performance URL: https://github.com/apache/poi/pull/406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #403: ignoring errors on ReadOnlySharedStringsTable count parsing, nobody i…
pjfanning commented on PR #403: URL: https://github.com/apache/poi/pull/403#issuecomment-1347135261 Another option is to use https://github.com/pjfanning/poi-shared-strings instead - the shared strings table implementations there are tolerant of large count values. I've added a test case to that lib to validate this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #403: ignoring errors on ReadOnlySharedStringsTable count parsing, nobody i…
pjfanning commented on PR #403: URL: https://github.com/apache/poi/pull/403#issuecomment-1347007048 I added https://github.com/apache/poi/commit/fdffe5f66d1c4c09b1edf77f009c3950f60b9ed0 as a temporary solution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #406: Add the ability to avoid adding cellStyle to improve writing performance
pjfanning commented on PR #406: URL: https://github.com/apache/poi/pull/406#issuecomment-1346964962 I also added https://github.com/apache/poi/commit/7454a722f0d408afc605cb1b3cbb2daa9c5c913c - this should improve the performance of SXSSFCell getColumnIndex. getColumnIndex is one of the main reasons that the cell style code is slow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #406: Add the ability to avoid adding cellStyle to improve writing performance
pjfanning commented on PR #406: URL: https://github.com/apache/poi/pull/406#issuecomment-1346934215 Could you trying calling setCellStyle(style) on each cell? You can have just 1 style instance that you set for all cells. If you look at SXSSFCell.getCellStyle, it skips all the lookup code if you have pre-set the style. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] StanBertrand commented on pull request #406: Add the ability to avoid adding cellStyle to improve writing performance
StanBertrand commented on PR #406: URL: https://github.com/apache/poi/pull/406#issuecomment-1346781242 Sorry ! I added a comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #404: Fix issue with text runs not honouring specific styling if they are i…
pjfanning commented on PR #404: URL: https://github.com/apache/poi/pull/404#issuecomment-1346686433 Thanks - merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #404: Fix issue with text runs not honouring specific styling if they are i…
asfgit closed pull request #404: Fix issue with text runs not honouring specific styling if they are i… URL: https://github.com/apache/poi/pull/404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #406: Add the ability to avoid adding cellStyle to improve writing performance
pjfanning commented on PR #406: URL: https://github.com/apache/poi/pull/406#issuecomment-1346679086 Thanks for the PR but could I highlight that leaving PRs with no description or background is not a good idea? I would take some convincing that adding this extra complication to the SXSSF is worth it. Do you have any proof that cell styles are expensive? I'm very sceptical about this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #405: Use `Characters.toChars` instead of `StringBuilder.appendCodePoint` to improve performance
pjfanning commented on PR #405: URL: https://github.com/apache/poi/pull/405#issuecomment-1346656718 Thanks - merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #405: Use `Characters.toChars` instead of `StringBuilder.appendCodePoint` to improve performance
asfgit closed pull request #405: Use `Characters.toChars` instead of `StringBuilder.appendCodePoint` to improve performance URL: https://github.com/apache/poi/pull/405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] matafagafo commented on pull request #403: ignoring errors on ReadOnlySharedStringsTable count parsing, nobody i…
matafagafo commented on PR #403: URL: https://github.com/apache/poi/pull/403#issuecomment-1343118700 > What is the provenance of the xlsx that has a malformed SST file? I'd personally be reluctant to add this unless malformed SSTs were common. I want to put my 2 cents here. We use POI to read user uploaded files, and we already received some XLSX files with invalid counts, bellow a sample.. POI generates `NumberFormatException` parsing the file. Trace: ``` java.lang.NumberFormatException: For input string: "4294749708" at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) at java.lang.Integer.parseInt(Integer.java:583) at java.lang.Integer.parseInt(Integer.java:615) at org.apache.poi.xssf.eventusermodel.ReadOnlySharedStringsTable.startElement(ReadOnlySharedStringsTable.java:244) `` The user file SST was: `http://schemas.openxmlformats.org/spreadsheetml/2006/main; count="4294749708" uniqueCount="566">` After opening with Excel (**without** errors or warnings showed by Excel) and Saving As, the SST was corrected to: `http://schemas.openxmlformats.org/spreadsheetml/2006/main; count="2452" uniqueCount="566">` I hope this helps to answer your question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #403: ignoring errors on ReadOnlySharedStringsTable count parsing, nobody i…
pjfanning commented on PR #403: URL: https://github.com/apache/poi/pull/403#issuecomment-1343046233 What is the provenance of the xlsx that has a malformed SST file? I'd personally be reluctant to add this unless malformed SSTs were common. There is a 2nd POI class called SharedStringsTable. That needs be kept in sync functionality wise. Also, the Boolean variable, malformedCount, is badly named. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] gffloodg opened a new pull request, #404: Fix issue with text runs not honouring specific styling if they are i…
gffloodg opened a new pull request, #404: URL: https://github.com/apache/poi/pull/404 …inside a table cell. When rendering PPTX containing tables, it can be seen that text runs within cells with certain styles (b / i / color) are not correctly rendered. This is caused by a bug in the creation of table cell text runs. This PR fixes the issue and adds tests to verify the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] yuval-perelman closed pull request #402: ignoring errors on ReadOnlySharedStringsTable count parsing, nobody i…
yuval-perelman closed pull request #402: ignoring errors on ReadOnlySharedStringsTable count parsing, nobody i… URL: https://github.com/apache/poi/pull/402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] yuval-perelman opened a new pull request, #402: ignoring errors on ReadOnlySharedStringsTable count parsing, nobody i…
yuval-perelman opened a new pull request, #402: URL: https://github.com/apache/poi/pull/402 …s using it. If from some reason the value of the input is invalid, there is no reason to fail the process especially since all the spreadsheet readers (Excel, Libre, Google...), can handle it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #401: Bump slf4j-api from 2.0.4 to 2.0.5
dependabot[bot] commented on PR #401: URL: https://github.com/apache/poi/pull/401#issuecomment-1327528703 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #400: Bump slf4j-simple from 2.0.4 to 2.0.5
dependabot[bot] commented on PR #400: URL: https://github.com/apache/poi/pull/400#issuecomment-1327528722 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #400: Bump slf4j-simple from 2.0.4 to 2.0.5
asfgit closed pull request #400: Bump slf4j-simple from 2.0.4 to 2.0.5 URL: https://github.com/apache/poi/pull/400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #401: Bump slf4j-api from 2.0.4 to 2.0.5
asfgit closed pull request #401: Bump slf4j-api from 2.0.4 to 2.0.5 URL: https://github.com/apache/poi/pull/401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #401: Bump slf4j-api from 2.0.4 to 2.0.5
dependabot[bot] opened a new pull request, #401: URL: https://github.com/apache/poi/pull/401 Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 2.0.4 to 2.0.5. Commits https://github.com/qos-ch/slf4j/commit/7e62e1e6917e19e6eeb8faf97daa9e2469bc946d;>7e62e1e prepare release 2.0.5 https://github.com/qos-ch/slf4j/commit/d250ad79ebbd46f098b07c0868d1cbc8c09c8d6c;>d250ad7 in jcl-over-slf4j rename LICENSE.TXT as LICENSE, add LICENSE file to log4j-ov... https://github.com/qos-ch/slf4j/commit/3bc58f3e81cfbe5ef9011c5124c0bd13dceee3a9;>3bc58f3 add SecurityManager support https://github.com/qos-ch/slf4j/commit/207bb299c319886aededb999269c1555abb9deae;>207bb29 start work on 2.0.5-SNAPSHOT See full diff in https://github.com/qos-ch/slf4j/compare/v_2.0.4...v_2.0.5;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #400: Bump slf4j-simple from 2.0.4 to 2.0.5
dependabot[bot] opened a new pull request, #400: URL: https://github.com/apache/poi/pull/400 Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 2.0.4 to 2.0.5. Commits https://github.com/qos-ch/slf4j/commit/7e62e1e6917e19e6eeb8faf97daa9e2469bc946d;>7e62e1e prepare release 2.0.5 https://github.com/qos-ch/slf4j/commit/d250ad79ebbd46f098b07c0868d1cbc8c09c8d6c;>d250ad7 in jcl-over-slf4j rename LICENSE.TXT as LICENSE, add LICENSE file to log4j-ov... https://github.com/qos-ch/slf4j/commit/3bc58f3e81cfbe5ef9011c5124c0bd13dceee3a9;>3bc58f3 add SecurityManager support https://github.com/qos-ch/slf4j/commit/207bb299c319886aededb999269c1555abb9deae;>207bb29 start work on 2.0.5-SNAPSHOT See full diff in https://github.com/qos-ch/slf4j/compare/v_2.0.4...v_2.0.5;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] RemboL closed pull request #397: [bug-66181] fix value function referencing blank cells
RemboL closed pull request #397: [bug-66181] fix value function referencing blank cells URL: https://github.com/apache/poi/pull/397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #397: [bug-66181] fix value function referencing blank cells
pjfanning commented on PR #397: URL: https://github.com/apache/poi/pull/397#issuecomment-1314185685 @RemboL https://svn.apache.org/viewvc?view=rev=1905308 is merged - can you close this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #398: Bump jmh-generator-annprocess from 1.35 to 1.36
dependabot[bot] commented on PR #398: URL: https://github.com/apache/poi/pull/398#issuecomment-1313999714 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #399: Bump jmh-core from 1.35 to 1.36
dependabot[bot] commented on PR #399: URL: https://github.com/apache/poi/pull/399#issuecomment-1313999724 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #399: Bump jmh-core from 1.35 to 1.36
asfgit closed pull request #399: Bump jmh-core from 1.35 to 1.36 URL: https://github.com/apache/poi/pull/399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] asfgit closed pull request #398: Bump jmh-generator-annprocess from 1.35 to 1.36
asfgit closed pull request #398: Bump jmh-generator-annprocess from 1.35 to 1.36 URL: https://github.com/apache/poi/pull/398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #399: Bump jmh-core from 1.35 to 1.36
dependabot[bot] opened a new pull request, #399: URL: https://github.com/apache/poi/pull/399 Bumps [jmh-core](https://github.com/openjdk/jmh) from 1.35 to 1.36. Commits See full diff in https://github.com/openjdk/jmh/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] opened a new pull request, #398: Bump jmh-generator-annprocess from 1.35 to 1.36
dependabot[bot] opened a new pull request, #398: URL: https://github.com/apache/poi/pull/398 Bumps [jmh-generator-annprocess](https://github.com/openjdk/jmh) from 1.35 to 1.36. Commits See full diff in https://github.com/openjdk/jmh/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] swagnerfaw closed pull request #396: Add MutiValued Types and repair how CLS ID GUID Type is Handled
swagnerfaw closed pull request #396: Add MutiValued Types and repair how CLS ID GUID Type is Handled URL: https://github.com/apache/poi/pull/396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #396: Add MutiValued Types and repair how CLS ID GUID Type is Handled
pjfanning commented on PR #396: URL: https://github.com/apache/poi/pull/396#issuecomment-1303155585 I applied the fix now - https://github.com/apache/poi/commit/c838c6cd6c0b485d0bc2d806d2faf8d62cf8ac56 - can you close this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] swagnerfaw commented on pull request #396: Add MutiValued Types and repair how CLS ID GUID Type is Handled
swagnerfaw commented on PR #396: URL: https://github.com/apache/poi/pull/396#issuecomment-1303149413 I am very sorry about this. I had a typo. I fixed it. Is this ok or do you want me to open another "clean" Pull request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #396: Add MutiValued Types and repair how CLS ID GUID Type is Handled
pjfanning commented on PR #396: URL: https://github.com/apache/poi/pull/396#issuecomment-1303121496 The code is in this PR does not work. It breaks dozens of the existing tests and even stops POI from being able to read the Test1.msg file. Causes exceptions like this when reading certain .msg files: ``` org.apache.poi.util.RecordFormatException: Can't allocate an array of length < 0, but had -1 and 100 at org.apache.poi.util.IOUtils.safelyAllocateCheck(IOUtils.java:556) at org.apache.poi.util.IOUtils.safelyAllocate(IOUtils.java:547) at org.apache.poi.hsmf.datatypes.PropertiesChunk.readProperties(PropertiesChunk.java:264) at org.apache.poi.hsmf.datatypes.MessagePropertiesChunk.readProperties(MessagePropertiesChunk.java:96) at org.apache.poi.hsmf.datatypes.MessagePropertiesChunk.readValue(MessagePropertiesChunk.java:101) at org.apache.poi.hsmf.parsers.POIFSChunkParser.process(POIFSChunkParser.java:150) at org.apache.poi.hsmf.parsers.POIFSChunkParser.processChunks(POIFSChunkParser.java:121) at org.apache.poi.hsmf.parsers.POIFSChunkParser.parse(POIFSChunkParser.java:99) at org.apache.poi.hsmf.MAPIMessage.(MAPIMessage.java:172) ``` I added some of the PR code and a test case with Test1.msg but renamed the file to bug66335.msg. I omitted the changes to PropertiesChunk.java because those are the changes that break the code. https://github.com/apache/poi/commit/c4a0266cb38c7f98f3efc74be805c4028b0518e8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] swagnerfaw commented on pull request #396: Add MutiValued Types and repair how CLS ID GUID Type is Handled
swagnerfaw commented on PR #396:
URL: https://github.com/apache/poi/pull/396#issuecomment-1302681009
Yes. In the Pull request. I also added 2 lines of sample code to see the
difference.
> I included my test-message here.
[Test1.zip](https://github.com/apache/poi/files/9932914/Test1.zip)
>
> ```java
> MAPIMessage msg = new MAPIMessage("Test1.msg");
> System.out.println("#found properties: " +
msg.getMainChunks().getProperties().size());
> ```
>
> The current 5.2.3 extracts 25 properties With my patch all 151 properties
included in `__properties_version1.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #396: Add MutiValued Types and repair how CLS ID GUID Type is Handled
pjfanning commented on PR #396: URL: https://github.com/apache/poi/pull/396#issuecomment-1302679645 Where is Test1.zip? It is not part of this PR and it is not attached to https://bz.apache.org/bugzilla/show_bug.cgi?id=66335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] swagnerfaw commented on pull request #396: Add MutiValued Types and repair how CLS ID GUID Type is Handled
swagnerfaw commented on PR #396: URL: https://github.com/apache/poi/pull/396#issuecomment-1302668922 > Thanks @swagnerfaw - unfortunately, we still need regression tests in order to proceed with a commit like this. If you have an input file, we can work with you to write a unit test. I added my Test1.msg file (inside the Test1.zip) which contains 151 properties. The current build reads 25 properties, with my fix all 151 are read. I am unsure what more I can provide at this point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #396: Add MutiValued Types and repair how CLS ID GUID Type is Handled
pjfanning commented on PR #396: URL: https://github.com/apache/poi/pull/396#issuecomment-1302663572 Thanks @swagnerfaw - unfortunately, we still need regression tests in order to proceed with a commit like this. If you have an input file, we can work with you to write a unit test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] swagnerfaw opened a new pull request, #396: Add MutiValued Types and repair how CLS ID GUID Type is Handled
swagnerfaw opened a new pull request, #396:
URL: https://github.com/apache/poi/pull/396
MutiValued Property Types inside `__properties_version1.0` caused the
reading of the properties stream to stop and skip all the rest of the stream
(missing out on alot of properties in some cases).
CLS ID GUID has a fixed length, however according to
[](https://learn.microsoft.com/en-us/openspecs/exchange_server_protocols/ms-oxmsg/08185828-e9e9-4ef2-bcd2-f6e69c00891b)
it is not read in the `__properties_version1.0` stream. It is (like variable
length) properties in another file. So I added another method `isPointer` since
no property longer than 8 bytes should be included inside the
`__properties_version1.0`.
I included my test-message here.
[Test1.zip](https://github.com/apache/poi/files/9932914/Test1.zip)
```java
MAPIMessage msg = new MAPIMessage("Test1.msg");
System.out.println("#found properties: " +
msg.getMainChunks().getProperties().size());
```
The current 5.2.3 extracts 25 properties
With my patch all 151 properties included in `__properties_version1.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] dependabot[bot] commented on pull request #395: Bump commons-compress from 1.21 to 1.22
dependabot[bot] commented on PR #395: URL: https://github.com/apache/poi/pull/395#issuecomment-1299860636 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
