[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Dominik Stadler  ---
I don't think we currently plan to invest more time on this, so I am closing
this as FIXED as all the sample-documents from our commoncrawl-corpus are now
handled correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

--- Comment #9 from Nick Burch  ---
In r1750866, I've changed it so that likely "nearby" values are subject to the
same check as the "official" values, and if passed no logging occurs. Hopefully
this helps and doesn't trigger any new warnings!

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

--- Comment #8 from Dominik Stadler  ---
I have applied a quick fix in r1750864 so that such documents do not fail until
we have decided on a complete solution here. The code now logs out the unknown
version number instead of throwing an exception.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

Dominik Stadler  changed:

   What|Removed |Added

Version|unspecified |3.15-dev

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

--- Comment #7 from Nick Burch  ---
Those look like clusters around the valid values (plus an outlier at 113)

I'd be tempted to say we accept any value +- 4 without much/any logging (and +-
113). Could someone check, for a few triggering files, how their cbRgFcLcb
values match with what the spec says to expect for the nearest-valid nFib
values?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

--- Comment #6 from Dominik Stadler  ---
In my regression-run, the following invalid versions are found:

EXCEPTIONTEXT315BETA2
java.lang.IllegalStateException: Invalid file format version number: 113
java.lang.IllegalStateException: Invalid file format version number: 191
java.lang.IllegalStateException: Invalid file format version number: 192
java.lang.IllegalStateException: Invalid file format version number: 194
java.lang.IllegalStateException: Invalid file format version number: 195
java.lang.IllegalStateException: Invalid file format version number: 216
java.lang.IllegalStateException: Invalid file format version number: 265
java.lang.IllegalStateException: Invalid file format version number: 267


We can add those as "undocumented", but I'd probably go with a
POILogger.warning() instead of the throw to not fail on other version-numbers
that are not included in our test-files.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

--- Comment #5 from Javen O'Neal  ---
Reverting any deprecated code deletion I did as part of bug 59170 is also an
acceptable fix here. I was pretty heavy handed with HWPF.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

--- Comment #4 from Nick Burch  ---
I guess we need to work out what format type these are (maybe by seeing what
they contain, or what Word treats them as?), then add a few more "unofficial"
entries to the check list

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

--- Comment #3 from Tim Allison  ---
Y, the problem goes away if I save as.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

Nick Burch  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #2 from Nick Burch  ---
Based on the file format specs -
https://msdn.microsoft.com/en-us/library/dd949344(v=office.12).aspx and
https://msdn.microsoft.com/en-us/library/dd950103(v=office.12).aspx - it looks
like we have all the "official" cases covered

Do these files start passing again if you do a save-as from word?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59739] Need to expand options in FileInformationBlock.assertCbRgFcLcb

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59739

--- Comment #1 from Tim Allison  ---
I'll run the full corpus regression tests shortly to see if there are other
values we need to add.  Or, should we undo this check?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org