[Bug 62040] Quotient.evaluate function does not accept cell refences

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62040

PJ Fanning  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #9 from PJ Fanning  ---
fix applied with r1894103

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62040] Quotient.evaluate function does not accept cell refences

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62040

Ian Giguère  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #8 from Ian Giguère  ---
I did not know if the patch file was sufficient so I also added the excel and
java files I edited.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62040] Quotient.evaluate function does not accept cell refences

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62040

--- Comment #7 from Ian Giguère  ---
Created attachment 36531
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36531=edit
Modifications to Quotient.java to support cell references

Dereference Value before coercing it to double.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62040] Quotient.evaluate function does not accept cell refences

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62040

--- Comment #6 from Ian Giguère  ---
Created attachment 36530
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36530=edit
Edited Excel file: QuotientFunctionTestCaseData.xls

Add new line to 'QuotientFunctionTestCaseData.xls' to test QUOTIENT with cell
references as arguments.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62040] Quotient.evaluate function does not accept cell refences

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62040

Ian Giguère  changed:

   What|Removed |Added

 CC||i...@cybercat.ca

--- Comment #5 from Ian Giguère  ---
Created attachment 36529
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36529=edit
Modifications to Quotient.java and QuotientFunctionTestCaseData.xls

Add new line to 'QuotientFunctionTestCaseData.xls' to test QUOTIENT with cell
references as arguments.

Dereference Value before coercing it to double.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62040] Quotient.evaluate function does not accept cell refences

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62040

--- Comment #4 from Dominik Stadler  ---
Any update on the sample file and unit-test?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62040] Quotient.evaluate function does not accept cell refences

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62040

--- Comment #3 from Dominik Stadler  ---
That would be perfekt!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62040] Quotient.evaluate function does not accept cell refences

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62040

--- Comment #2 from cque...@gmail.com ---
(In reply to Dominik Stadler from comment #1)
> Do you have a code-sample that shows the problem? Ideally a self-standing
> unit-test? Would make it much easier to reproduce and ensure it stays fixed
> in the future.

I'm not at all familiar with your testing methods. What I did was load an Excel
spreadsheet evaluate it and compare the results visually and with poi. I could
write a simple Excel file and the POI unit test to show fail on the error. Is
that OK?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62040] Quotient.evaluate function does not accept cell refences

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62040

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #1 from Dominik Stadler  ---
Do you have a code-sample that shows the problem? Ideally a self-standing
unit-test? Would make it much easier to reproduce and ensure it stays fixed in
the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org