[RESULT] [VOTE] Apache POI 4.0.1 release (RC2)

2018-11-30 Thread Andreas Beeker
The vote has passed with 4x +1 from POI PMCs. I'll now release the artifacts and announce it on Monday. Andi. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org

Re: [VOTE] Apache POI 4.0.1 release (RC2)

2018-11-29 Thread Dominik Stadler
Hi, Reports from my regression tests are available, no failures compared to 4.0.0 are shown any more now that I managed to run with much more main memory. Also the number of OOMs is down to 39 overall now. See http://people.apache.org/~centic/poi_regression/reports/index400RC1to401RC2.html and

Re: [VOTE] Apache POI 4.0.1 release (RC2)

2018-11-27 Thread Tim Allison
+1 Reports are available here: http://162.242.228.174/reports/reports_poi_4_0_1-rc2.tgz Thank you, Andi! On Mon, Nov 26, 2018 at 6:01 PM Andreas Beeker wrote: > > Hi, > > I've prepared artifacts for the release of Apache POI 4.0.1 (RC2). > > The most notable changes in this release are: > > -

Re: [VOTE] Apache POI 4.0.1 release (RC2)

2018-11-27 Thread pj.fanning
+1 Thanks for all the hard work getting this over the line. -- Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail:

[VOTE] Apache POI 4.0.1 release (RC2)

2018-11-26 Thread Andreas Beeker
Hi, I've prepared artifacts for the release of Apache POI 4.0.1 (RC2). The most notable changes in this release are: - dependency updates to XMLBeans 3.0.2 / Bouncycastle 1.60 - XSSF: import chart on drawing - XDDF: Define XDDF user model for text body, its paragraphs and text runs - OPC:

Re: [VOTE][CANCEL] Apache POI 4.0.1 release (RC1)

2018-11-25 Thread Dominik Stadler
Hi, thanks for fixing FileMagic, I just noticed the same bug and planned to fix it as well. I just committed one small change so we do not include jars from the new directory ooxml-testlib in the source-distribution similar to all the other lib-directories. Dominik. On Sun, Nov 25, 2018 at

[VOTE][CANCEL] Apache POI 4.0.1 release (RC1)

2018-11-25 Thread Andreas Beeker
Not sure if this is necessary, but I formally cancel now RC1 and remove its sources ... giving way for RC2. As #60316 is fixed now - I'll check a few of the common crawl results for low hanging fruits and fix them. After that I'll roll a RC2 soon - if you have anything to put into 4.0.1

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-25 Thread Dominik Stadler
Hi, I could speed it up somewhat, results are available, all seems well on this regression front, see http://people.apache.org/~centic/poi_regression/reports/index400RC1to401RC1.html for comparison to 4.0.0 and http://people.apache.org/~centic/poi_regression/reportsAll/index400RC1to401RC1.html

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-23 Thread Dominik Stadler
Hi, somehow the run is taking a long time this time around, estimate finish is Nov. 26 in the afternoon at the moment. Until now my runs was quite limited in amount of memory I could use, but I can now run it with more memory now as I can run on newer hardware, so hopefully the number of OOMs

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-23 Thread Andreas Beeker
Maybe its obvious, but before I roll another RC I'm waiting for Dominiks common crawl results - as we have the opportunity to add another stability fix. Btw. what makes me "sad", ... is to see those OOMs. Can't we simply exclude them ... in the statistics? ;) But to be serious again - is there

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-23 Thread Yegor Kozlov
Bugs 59773,59834,62690,62692,62699,62733,62735,62740,62768,62796,62800,62805,62807 and 62811 were fixed after 4.0 release, but not reflected in the 4.0.1 change log. See https://bz.apache.org/bugzilla/buglist.cgi?bug_status=RESOLVED=resolution=2018-09-07=Now=bug_id=POI_format=advanced=FIXED With

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-23 Thread pj.fanning
The real fix is https://bz.apache.org/bugzilla/show_bug.cgi?id=62692 - XMLBeans-519 fixes a similar issue in XMLBeans (the SAXHelper code in XMLBeans is basically a copy/paste of POI equivalent). -- Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-23 Thread pj.fanning
https://bz.apache.org/bugzilla/show_bug.cgi?id=62943 fix was to bring back a try catch block around the code that had been removed in 4.0.0. The 4.0.0 issue seems to affect users that have very old parsers - typically part of Application Servers that have their own non-standard parsers. I'm happy

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-23 Thread Dominik Stadler
Hi, If possible we should also review https://bz.apache.org/bugzilla/show_bug.cgi?id=62943 and ensure 4.0.1 does it correctly as it sounds as if we may have broken compatibility with JDK 8 somehow. Dominik. On Fri, Nov 23, 2018 at 2:34 PM Tim Allison wrote: > Sorry, now that I've figured out

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-23 Thread Tim Allison
Sorry, now that I've figured out what the problem was, I'm -1. Y, let's respin. On Thu, Nov 22, 2018 at 4:34 PM Andreas Beeker wrote: > > Hi Tim, > > On 21.11.18 19:26, Tim Allison wrote: > > This looks like a regression. > > > Please make your mind up, if this is a "-1". > > Creating a new RC

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-22 Thread Andreas Beeker
Hi Tim, On 21.11.18 19:26, Tim Allison wrote: This looks like a regression. Please make your mind up, if this is a "-1". Creating a new RC is not a big deal, I only think about the hours of computing power needed to process the common crawl. Andi

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-22 Thread Dominik Stadler
Ok, thanks for the explanation, I am +1 from this point of view then. Dominik. On Wed, Nov 21, 2018, 18:00 Andreas Beeker wrote: > On 21.11.18 07:09, Dominik Stadler wrote: > > However the maven-subdir is missing the directory "ooxml-schemas" now. I > > think this should still be included,

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-22 Thread pj.fanning
Tim - would you be able to provide some sample files and we can add some regression tests? -- Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-21 Thread Tim Allison
In the debugger: XWPFHeaderFooterPolicy hfPolicy = document.getHeaderFooterPolicy(); the hfPolicy in 4.0.1 has nothing in it; whereas in 4.0.0, there's a firstPageHeader (header3.xml), an evenPageHeader (header1.xml), a defaultHeader (header2.xml) and a defaultFooter(footer1). This looks like a

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-21 Thread Tim Allison
>These were in the header...I have to step away from the keyboard for now...any ideas? I confirmed this by flipping btwn 4.0.0 and 4.0.1 in our dependencies and using our Tika's SNAPSHOT for both. This is not caused by a different version of Tika. On Wed, Nov 21, 2018 at 12:53 PM Tim Allison

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-21 Thread Tim Allison
Y, my suspicion holds up. If you look at TOP_10_UNIQUE_TOKEN_DIFFS_A in content_diffs_with_exceptions.xlsx, there aren't any unique words we were extracting with 4.0.0 that we're not extracting with 4.0.1 in the vast majority of ppt files. Note, too, that while the number of tokens differs, the

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-21 Thread Tim Allison
Reports are available here: http://162.242.228.174/reports/reports_poi_4_0_1-rc1.tgz We have a bunch less content in ppt, but I _think_ this is because at the Tika level we used to duplicate notes content, and we've fixed that bug. So, I think this is an improvement, but I need to check. On Wed,

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-21 Thread pj.fanning
I'm +1 -- the fix can wait till 4.0.2 and there is the workaround to use full schema jar. -- Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-21 Thread Andreas Beeker
On 21.11.18 10:47, pj.fanning wrote: I found a few missing classes in poi-ooxml-schemas.jar. Is this now a "-1", i.e. a must-have otherwise we get a lot of stackoverflow messages complaining about it ... or a "0-", i.e. nice-to-have, but until 4.0.2 is out, the users can use the full-schema

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-21 Thread Andreas Beeker
On 21.11.18 07:09, Dominik Stadler wrote: However the maven-subdir is missing the directory "ooxml-schemas" now. I think this should still be included, or? In 4.0.0 it contains ooxml-schemas-1.4.jar/ooxml-schemas-1.4-sources.jar and checksums. I've provided the ooxml-schemas 1.4 as part of the

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-21 Thread pj.fanning
I found a few missing classes in poi-ooxml-schemas.jar. We have some gaps in the XDDF testing and this leads to us not adding all the necessary OOXML classes for XDDF to the poi-ooxml-schemas.jar. https://github.com/apache/poi/commit/df83dab1a49900d85d9a20c0ee6d5a7a31f0eb9c -- Sent from:

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-20 Thread Dominik Stadler
Hi, I started to compare things, -bin-..zip looks good, contents of poi-ooxml-schemas looks sane. However the maven-subdir is missing the directory "ooxml-schemas" now. I think this should still be included, or? In 4.0.0 it contains ooxml-schemas-1.4.jar/ooxml-schemas-1.4-sources.jar and

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-20 Thread Tim Allison
>which extra ".jar"??? The first one, clearly. :D Thank you! On Tue, Nov 20, 2018 at 5:01 PM Andreas Beeker wrote: > > Hi Tim, > > which extra ".jar"??? :) > > ... just kidding, I've fixed it and thank you! > > I was already wondering, that the release process was too smooth. > Only my local

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-20 Thread Andreas Beeker
Hi Tim, which extra ".jar"??? :) ... just kidding, I've fixed it and thank you! I was already wondering, that the release process was too smooth. Only my local version of the commons-openpgp needed to be used. [1] Andi [1] https://issues.apache.org/jira/browse/SANDBOX-508 On 20.11.18

Re: [VOTE] Apache POI 4.0.1 release (RC1)

2018-11-20 Thread Tim Allison
Andi, Thank you! I've built this locally and integrated it into Tika, and I've kicked off the regression tests. The one small glitch I noticed so far is that poi-ooxml-schemas jar has an extra ".jar" in it: build/dist/maven/poi-ooxml-schemas/poi-ooxml-schemas-4.0.1.jar.jar I'll let you all

Re: POI 4.0.1 release

2018-11-12 Thread Andreas Beeker
HI *, I thought #62872 would be a blocker, but I guess the problem is simply the file size and it's not working with 3.17 either (for me). Therefore if nobody minds, I would prepare a release candidate next weekend. Andi. PS: I'm currently unable to fix an AffineTransformation problem with

Re: POI 4.0.1 release

2018-10-30 Thread Greg Woolsey
t; > Von: "pj.fanning" > Gesendet: Tue Oct 30 04:59:08 GMT-03:00 2018 > An: dev@poi.apache.org > Betreff: POI 4.0.1 release > > Is it time for us to look at doing a POI 4.0.1 release? > > Are there any issues we would like to see completed before we proceed?

Re: POI 4.0.1 release

2018-10-30 Thread Alain FAGOT BÉAREZ
improvement of the API for charts. ⁣Gesendet mit BlueMail ​ Von: "pj.fanning" Gesendet: Tue Oct 30 04:59:08 GMT-03:00 2018 An: dev@poi.apache.org Betreff: POI 4.0.1 release Is it time for us to look at doing a POI 4.0.1 release? Are there any issues we would like to see completed before

Re: POI 4.0.1 release

2018-10-30 Thread Tim Allison
e anyway, just waiting > to see if the contributor is planning any follow-up patches. Please give me > time till the end of this week. > > Yegor > > On Tue, Oct 30, 2018 at 10:59 AM pj.fanning wrote: > > > Is it time for us to look at doing a POI 4.0.1 release? > >

Re: POI 4.0.1 release

2018-10-30 Thread Yegor Kozlov
+1 Bug 62836 is pending. I'm going to check in the code anyway, just waiting to see if the contributor is planning any follow-up patches. Please give me time till the end of this week. Yegor On Tue, Oct 30, 2018 at 10:59 AM pj.fanning wrote: > Is it time for us to look at doing a POI 4.

Re: POI 4.0.1 release

2018-10-30 Thread kiwiwings
+1 for rolling it out soon I think the grace period is over and we can go on rolling the fixes out. Also my (H)EMF implementation is giving promising results and although EMF+ is not yet implemented, I think the slideshow users, would benefit from it ... but I don't want to spoil the bugfix

POI 4.0.1 release

2018-10-30 Thread pj.fanning
Is it time for us to look at doing a POI 4.0.1 release? Are there any issues we would like to see completed before we proceed? -- Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html - To unsubscribe, e