+1 on voting on the design doc. The PR approval process itself severs the
consensus building process as voting.
Yufei
On Fri, Mar 14, 2025 at 12:45 PM Jean-Baptiste Onofré
wrote:
> Yes, it's what I meant: better to have discussion/consensus on design
> doc or dev mailing list before PR.
>
> Ge
I agree in principle, but I do think the wording in the contribution
guidelines that JB shared is the better approach: discuss and approve on
the dev list *before* you have a PR ready for review. Otherwise if there
are major objections to the directional approach, you've spent a bunch of
time writi
Yes, it's what I meant: better to have discussion/consensus on design
doc or dev mailing list before PR.
Generally speaking, the vote should be used only to confirm on one
thing (we should not vote between A and B, but more ok with A, +1 or
-1).
So, I would propose to follow the good practices and
+1 for what Tyler said. In general, votes should be used to confirm
agreement, not to choose a direction.
On Fri, Mar 14, 2025 at 9:19 AM Tyler Akidau wrote:
> I agree in principle, but I do think the wording in the contribution
> guidelines that JB shared is the better approach: discuss and app
Sounds good, Although I'm also fine with doing votes on design docs prior
to PR's if that makes more sense. But generally having some gateway of
"these changes are going to be implemented"
On Fri, Mar 14, 2025 at 3:11 AM Robert Stupp wrote:
> +1
>
> on Dmitri's proposal
>
> On 14.03.25 07:52, Je
API changes which were not explicitly discussed are the PRs 1150 [1] and
808 [2].
PR 808 has been merged w/o addressing all concerns about the hard
dependencies of Polaris APIs on Iceberg-owned APIs have been raised
multiple times. The same concern applies to 1150. It's been raised
multiple t
+1
on Dmitri's proposal
On 14.03.25 07:52, Jean-Baptiste Onofré wrote:
Hi Dmitri
Thanks for starting this discussion.
I thought we already agreed on that. If we take a look on
https://polaris.apache.org/community/contributing-guidelines/ we can
see in the good practices section (first bullet
Hi Dmitri
Thanks for starting this discussion.
I thought we already agreed on that. If we take a look on
https://polaris.apache.org/community/contributing-guidelines/ we can
see in the good practices section (first bullet point):
"Change of public interface (or more generally speaking Polaris
ex
+1, this is a great idea.
—EM
On Thu, Mar 13, 2025 at 5:58 PM Dmitri Bourlatchkov
wrote:
> Hi All,
>
> A lot of REST API changes have been happening lately in GitHub.
>
> Client-facing APIs changes are relatively a lot more important than
> refactorings and other code fixes, but can easily be h
Hi All,
A lot of REST API changes have been happening lately in GitHub.
Client-facing APIs changes are relatively a lot more important than
refactorings and other code fixes, but can easily be hidden from view in
the multitude of GH notifications.
Therefore, I propose to run votes on the dev lis
10 matches
Mail list logo
