Re: [Discuss] Default commit message during merge/squash

2025-07-10 Thread Yufei Gu
It's a valid concern if that description doesn't match with the commit. But I'm fine with it as long as we can modify the description at the merging time. Yufei On Thu, Jul 10, 2025 at 12:07 PM Eric Maynard wrote: > If there are things missing from Renovate that mean we can't configure the > c

Re: [Discuss] Default commit message during merge/squash

2025-07-10 Thread Eric Maynard
If there are things missing from Renovate that mean we can't configure the commit messages in the way you'd like that's a shame, but I'm not totally sure that needs to be a blocker here. Does the change just need to go to a vote? --EM On Thu, Jul 10, 2025 at 3:28 AM Robert Stupp wrote: > That w

Re: [Discuss] Default commit message during merge/squash

2025-07-10 Thread Robert Stupp
That would remove the useful information like links release-notes/changelog, effective Renovate config for the PR, ability to re-create the PR, link to Renovate logs, etc On Wed, Jul 9, 2025 at 6:25 PM Eric Maynard wrote: > > Is it possible to adjust the PR description generated by renovate to be

Re: [Discuss] Default commit message during merge/squash

2025-07-09 Thread Eric Maynard
Is it possible to adjust the PR description generated by renovate to better align with what you're looking for? The docs seem to suggest that it can be done with e.g. {{{commitList}}} --EM On Wed, Jul 9, 2025 at 9:08 AM Robert Stupp

Re: [Discuss] Default commit message during merge/squash

2025-07-09 Thread Robert Stupp
My biggest concern is the Renovate PRs. The commit message of those is suitable for being merged "as is" - but the PR description is not. Given the amount of Renovate-PRs it's a lot of cognitive work to adjust those - or the commit log would look really really awful with a ton of not useful informa

Re: [Discuss] Default commit message during merge/squash

2025-07-09 Thread Eric Maynard
Hi Robert, > Having the list of commits in the merge commit message proposed by GitHub helps there. Can you elaborate on this? How exactly does it help? You can always view the commits on the original PR. Beyond that, I actually don't see these commit messages being added currently when I look a

Re: [Discuss] Default commit message during merge/squash

2025-07-09 Thread Jean-Baptiste Onofré
Hi >From technical standpoint, the commit template can be updated via asf.yaml. It’s a change we did on the parser a few months ago. Regards JB Le mer. 9 juil. 2025 à 04:30, Ajantha Bhat a écrit : > Hi all, > While adding the recommendation to working with the PR on site docs, > we have opened

Re: [Discuss] Default commit message during merge/squash

2025-07-09 Thread Robert Stupp
Hi all, >From experience in the past, the initially created PR summary and description do not fully match the eventually merged change. This is why I mentioned "... contributors should review the PR summary and description before opening a PR and committers should really review both the summary an

[Discuss] Default commit message during merge/squash

2025-07-09 Thread Ajantha Bhat
Hi all, While adding the recommendation to working with the PR on site docs, we have opened an issue https://github.com/apache/polaris/issues/1656 to update the settings. I have discussed with ASF Infra and they mentioned, we can update by ourselves. Hence, I opened a PR for the same: https://gith