sebbASF opened a new issue #1:
URL: https://github.com/apache/incubator-ponymail-unit-tests/issues/1
The current test harness only tests the shared part of the archiver which
parses emails.
There need to be some tests for the functioning of the archiver when
processing input message
Humbedooh commented on issue #1:
URL:
https://github.com/apache/incubator-ponymail-unit-tests/issues/1#issuecomment-680144542
We could extend upon this, and have the following steps run:
- spin up ES
- set up foal via non-interactive config
- import from an mbox corpus we know
sebbASF commented on issue #1:
URL:
https://github.com/apache/incubator-ponymail-unit-tests/issues/1#issuecomment-680181502
I think we also need to test against earlier versions to ensure compatibility
This is an automated m
Humbedooh commented on issue #1:
URL:
https://github.com/apache/incubator-ponymail-unit-tests/issues/1#issuecomment-680184583
With regards to which elements in particular?
The old backend and UI will obviously not be compatible with the new DB and
structure.
We might however be able
sebbASF commented on issue #1:
URL:
https://github.com/apache/incubator-ponymail-unit-tests/issues/1#issuecomment-680195331
The archiver in particular needs to generate the same output for the same
input and settings.
For example, the current tests don't exercise the part of the archive
sebbASF opened a new issue #1:
URL: https://github.com/apache/incubator-ponymail-foal/issues/1
The full generator as used in the original Ponymail uses msg.as_bytes() as
the source for the hash.
This will be different from the raw input message used by the updated
version in Foal.
sebbASF commented on issue #1:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/1#issuecomment-680945368
Sorry, must have been looking at an outdated version of the source, I see it
has been fixed
This is an au
sebbASF closed issue #1:
URL: https://github.com/apache/incubator-ponymail-foal/issues/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
sebbASF opened a new issue #2:
URL: https://github.com/apache/incubator-ponymail-unit-tests/issues/2
mbox files may contain >From lines in the body
These are converted by import-mbox.py before calling compute_updates,
however this is not currently done by the test scripts
-
sebbASF commented on issue #2:
URL:
https://github.com/apache/incubator-ponymail-unit-tests/issues/2#issuecomment-681176779
Should be fixed now
This is an automated message from the Apache Git Service.
To respond to the mess
sebbASF closed issue #2:
URL: https://github.com/apache/incubator-ponymail-unit-tests/issues/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
sebbASF opened a new issue #3:
URL: https://github.com/apache/incubator-ponymail-unit-tests/issues/3
There are a couple of test files which contain >From body lines, however at
present the only tests are for the dkim generator
Need parsing tests for these as well as more generators
sebbASF opened a new issue #4:
URL: https://github.com/apache/incubator-ponymail-unit-tests/issues/4
The get_bytes() method can change the EOLs in a message.
It's safer to use get_file() and read the message, as that will preserve
whatever EOL was used.
Also the original From line
sebbASF commented on issue #4:
URL:
https://github.com/apache/incubator-ponymail-unit-tests/issues/4#issuecomment-683406053
Most of original issue has been fixed. Dropped mails will now be handled in
a separate issue
This i
sebbASF closed issue #4:
URL: https://github.com/apache/incubator-ponymail-unit-tests/issues/4
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
sebbASF opened a new issue #5:
URL: https://github.com/apache/incubator-ponymail-unit-tests/issues/5
tools/collate-output.py currently drops emails without Message-Ids.
Such emails are important to testing and should not be dropped.
Since it uses a hash for collecting the Message-I
sebbASF commented on issue #5:
URL:
https://github.com/apache/incubator-ponymail-unit-tests/issues/5#issuecomment-683422830
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log
sebbASF closed issue #5:
URL: https://github.com/apache/incubator-ponymail-unit-tests/issues/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
sebbASF opened a new issue #2:
URL: https://github.com/apache/incubator-ponymail-foal/issues/2
import-mbox uses two different methods to get the raw message:
get_bytes [1] for passing to compute_updates
get_file [2] for storage in the database
The former method does not take
sebbASF closed issue #2:
URL: https://github.com/apache/incubator-ponymail-foal/issues/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
sebbASF opened a new issue #6:
URL: https://github.com/apache/incubator-ponymail-unit-tests/issues/6
There are no tests to show that data read from files is correctly handled.
For example, the bug
https://github.com/apache/incubator-ponymail-foal/issues/2 was found by
accident rathe
sebbASF opened a new issue #3:
URL: https://github.com/apache/incubator-ponymail-foal/issues/3
The dkim generator code does not agree with that in
https://github.com/apache/incubator-ponymail/pull/517
In particular, the PR uses byte variables for rfc4871_subset and
rfc4871_and_rfc86
sebbASF closed issue #3:
URL: https://github.com/apache/incubator-ponymail-foal/issues/3
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
sebbASF opened a new issue #4:
URL: https://github.com/apache/incubator-ponymail-foal/issues/4
The generator code has various changes compared with the source in the main
ponymail repo.
Either the generators should be dropped, or they should agree with the
existing code.
-
sebbASF opened a new issue #5:
URL: https://github.com/apache/incubator-ponymail-foal/issues/5
The code should be able to parse and store all emails even if they are
HTML-only and html2text is not available.
Also the generated permalink should not depend on whether the --html option
sebbASF opened a new issue #6:
URL: https://github.com/apache/incubator-ponymail-foal/issues/6
The --defaults option is supposed to be used for automated setup, however
the code currently prompts for input.
This is an automa
Humbedooh closed issue #6:
URL: https://github.com/apache/incubator-ponymail-foal/issues/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sebbASF opened a new issue #7:
URL: https://github.com/apache/incubator-ponymail-foal/issues/7
This is because 0 is Falsy in Python.
There are probably other incorrect usages of the 'if number:' condition in
the code.
sebbASF commented on issue #7:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/7#issuecomment-687074339
Fixed the specific issue with c7bd066 but there are no doubt other instances
of the incorrect check
This
sebbASF opened a new issue #8:
URL: https://github.com/apache/incubator-ponymail-foal/issues/8
I am running Python 3.7.8 yet setup.py does not warn that 3.8 is needed for
backend operations.
This is an automated message from
Humbedooh commented on issue #4:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/4#issuecomment-687295575
I don't see any unit tests failing for neither foal nor current pony mail -
are we missing something here?
-
Humbedooh commented on issue #4:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/4#issuecomment-687296319
I'll note that while the generators have changed slightly, it was done to
accommodate the changes in archiver.py's handling of message bodies, and from
what I can tell,
sebbASF commented on issue #4:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/4#issuecomment-687311192
Some of the tests under yaml/set01 only work with Pony, and some under
yaml/set02 only work with Foal.
I think this is due to differences in how non-ASCII characters
Humbedooh commented on issue #4:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/4#issuecomment-687353559
Ah, I see where this breaks. The old archiver returns both bytes and
strings, whereas the new one will always return a string for the body. This can
be worked around, bu
sebbASF commented on issue #4:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/4#issuecomment-687360850
The non-deterministic behaviour was fixed here:
https://github.com/apache/incubator-ponymail/commit/3c5bfbd3af1300f0a792dc95e3ba585d4957
AFAICT the input
Humbedooh commented on issue #4:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/4#issuecomment-687568785
I believe it should all be addressed now and simplified. set01 passes with
foal as expected, and set02 fails in a few places (all emails with undeclared
utf-8 encoding),
Humbedooh closed issue #8:
URL: https://github.com/apache/incubator-ponymail-foal/issues/8
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Humbedooh commented on issue #8:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/8#issuecomment-687594431
This should be fixed now.
This is an automated message from the Apache Git Service.
To respond to the me
Humbedooh commented on issue #5:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/5#issuecomment-687595402
First bit we can easily do. It will break three unit tests, but we can fix
that:
~~~diff
@@ -312,8 +312,7 @@ class Archiver(object): # N.B. Also used by
import-mb
Humbedooh commented on issue #5:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/5#issuecomment-687595589
Whether the permalink ID depends on it or not will depend on the generator.
For modern ones (full, dkim) it won't matter as they use full bytes. For
older ones, we mig
Humbedooh commented on issue #5:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/5#issuecomment-687599931
To make the unit tests align with old pony, we'll need to both detect this
"html source only" status, and inject it into the resulting json:
~~~diff
@@ -415,13
Humbedooh closed issue #5:
URL: https://github.com/apache/incubator-ponymail-foal/issues/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Humbedooh commented on issue #5:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/5#issuecomment-687749034
I have implemented the above in the code, and it works as expected.
Foal now stores the html source as-is when there is no html-to-text
generator specified. It adds a
sebbASF commented on issue #4:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/4#issuecomment-689184124
The tests have started failing again.
There are some new format=flowed tests which cause the code to fail.
-
sebbASF opened a new issue #9:
URL: https://github.com/apache/incubator-ponymail-foal/issues/9
Just tried running setup.py against ES 6.8.12:
Index creation failed: RequestError(400, 'mapper_parsing_exception', 'Root
mapping definition has unsupported parameters: [internal :
{prope
Humbedooh commented on issue #9:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/9#issuecomment-689512838
I am strongly wondering if we should just support 7.x and 8.x, since 6.x was
a weird "in between" they made *while* they were changing the overall design.
sebbASF commented on issue #9:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/9#issuecomment-689514736
In which case the docs need to be updated.
Note that the docs should distinguish between the ES Python API code and the
backend ES database.
--
lewismc opened a new pull request #5:
URL: https://github.com/apache/incubator-ponymail-site/pull/5
This should prevent anyone else from going to the wrong source repository
@Humbedooh
This is an automated message from the
lewismc commented on issue #9:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/9#issuecomment-780832879
The docs are up-to-date. They clearly state ES 7.X. This ticket can be
closed off.
This is an automated
lewismc commented on issue #7:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/7#issuecomment-780833095
Close issue?
This is an automated message from the Apache Git Service.
To respond to the message, please l
lewismc opened a new issue #10:
URL: https://github.com/apache/incubator-ponymail-foal/issues/10
When one executes the set up i.e. `python3 tools/setup.py` and selects the
default value [*] for the following prompt
```
Which domains would you accept mail to from web-replies? [*]: *
lewismc opened a new issue #11:
URL: https://github.com/apache/incubator-ponymail-foal/issues/11
I have Elasticsearch running and accessible on localhost:9200
I performed ponymail setup without any issues.
I successfully imported pipermail data (thank you @Humbedooh)
I ran ponymail
Humbedooh commented on issue #10:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/10#issuecomment-781200221
A suitable default would be the domain for which you are serving up mailing
list archives. As that hasn't been determined at this point, * is used to allow
anything. I
Humbedooh commented on issue #11:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/11#issuecomment-781202693
It is highly recommended that you run the API and UI on the same port, or
you will run into CORS issues like this, especially for localhost. Somethine
like `ProxyPass
Humbedooh commented on issue #9:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/9#issuecomment-808956962
I believe the docs are up to date as well, closing this as resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Humbedooh closed issue #9:
URL: https://github.com/apache/incubator-ponymail-foal/issues/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
madrob opened a new issue #12:
URL: https://github.com/apache/incubator-ponymail-foal/issues/12
It would be useful to be able to set the reply-to header to users@project
when sending things like release announcements or CVE announcement to
announce@a.o
--
This is an automated message fr
sbp opened a new pull request #13:
URL: https://github.com/apache/incubator-ponymail-foal/pull/13
This PR fixes a small bug in one of the installation commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
sbp opened a new pull request #14:
URL: https://github.com/apache/incubator-ponymail-foal/pull/14
This PR fixes a bug where `migrate.py` would not migrate all documents. The
problem is that in the loop iterating over all documents in the source
database, documents are appended gradually in
sbp opened a new pull request #15:
URL: https://github.com/apache/incubator-ponymail-foal/pull/15
The "Static HTML lists" link is broken due to `xlist` not being defined.
Most likely it should be `current_list + '@' + current_domain`. In any case,
the link is broken even with this fix beca
sbp opened a new pull request #16:
URL: https://github.com/apache/incubator-ponymail-foal/pull/16
Foal does not correctly discover all lists available to it from its
Elasticsearch database because the underlying aggregation query does not
specify a size, and so the default of ten is used.
sbp opened a new issue #17:
URL: https://github.com/apache/incubator-ponymail-foal/issues/17
In addition to the issue with list discovery identified in PR #16, there is
an additional issue that the use of `size=0` later on in the query code to
avoid `sum_other_doc_count` being greater than
Humbedooh commented on issue #17:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/17#issuecomment-832697449
I do like the idea of keeping a "set" of found lists. This would also need
to store whether private messages are present on said list.
Having said that, I don't beli
Humbedooh merged pull request #13:
URL: https://github.com/apache/incubator-ponymail-foal/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
Humbedooh merged pull request #14:
URL: https://github.com/apache/incubator-ponymail-foal/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
Humbedooh commented on pull request #16:
URL:
https://github.com/apache/incubator-ponymail-foal/pull/16#issuecomment-832699893
I think 8192 is a good (if rather high) number :)
I can't think of a place that would want more lists than that in any case...
--
This is an automated message
Humbedooh merged pull request #16:
URL: https://github.com/apache/incubator-ponymail-foal/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
sbp opened a new pull request #18:
URL: https://github.com/apache/incubator-ponymail-foal/pull/18
When `setup.py` was switched to `dburl` some old references to `hostname`
and `port` were not updated, causing the script to fail when run. This PR fixes
that.
--
This is an automated messa
Humbedooh merged pull request #18:
URL: https://github.com/apache/incubator-ponymail-foal/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
sbp opened a new pull request #19:
URL: https://github.com/apache/incubator-ponymail-foal/pull/19
When hosting Foal across multiple domains or subdomains it may be desirable
to show only the mailing lists for the current domain or subdomain in the user
interface. This PR adds a boolean con
Humbedooh commented on pull request #19:
URL:
https://github.com/apache/incubator-ponymail-foal/pull/19#issuecomment-833485086
I like this idea.
Could it be extended so that focus_domain could be either a boolean (use
host: attribute) OR a string, in which case it would match lists agai
sbp commented on pull request #19:
URL:
https://github.com/apache/incubator-ponymail-foal/pull/19#issuecomment-833544205
This is now implemented in e724d9b, with the slight difference that instead
of `Union[bool, str]` it uses just `str` and the empty string `""` is the old
`True` and an
Humbedooh commented on pull request #19:
URL:
https://github.com/apache/incubator-ponymail-foal/pull/19#issuecomment-833586798
I think this is a good improvement, and I'll merge unless I hear otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the messag
sbp opened a new pull request #20:
URL: https://github.com/apache/incubator-ponymail-foal/pull/20
The signature of `Archiver.archive_message` is incompatible with Mailman3.
This PR fixes that.
Mailman3 archives messages by sending two arguments, `(mlist, msg)`, to the
archiver. But
sbp opened a new pull request #21:
URL: https://github.com/apache/incubator-ponymail-foal/pull/21
This PR fixes a small bug in the source endpoint. The `mid` field was being
used to retrieve a source document, which was correct for Ponymail but in Foal
the `dbid` field is used instead.
-
Humbedooh merged pull request #21:
URL: https://github.com/apache/incubator-ponymail-foal/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
Humbedooh commented on pull request #21:
URL:
https://github.com/apache/incubator-ponymail-foal/pull/21#issuecomment-834633325
i stumbled across this as well - good find
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
Humbedooh merged pull request #19:
URL: https://github.com/apache/incubator-ponymail-foal/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
Humbedooh merged pull request #15:
URL: https://github.com/apache/incubator-ponymail-foal/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
sbp commented on pull request #20:
URL:
https://github.com/apache/incubator-ponymail-foal/pull/20#issuecomment-835372590
The `original_content` attribute preserves the message delivered from the
MTA to Mailman3, before Mailman3 potentially modifies the message. This is
necessary because t
sbp closed pull request #20:
URL: https://github.com/apache/incubator-ponymail-foal/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
sbp opened a new pull request #22:
URL: https://github.com/apache/incubator-ponymail-foal/pull/22
This PR adds a new generator called **blakey**, based on
[BLAKE3](https://github.com/BLAKE3-team/BLAKE3). It deprecates the old **dkim**
generator.
The new generator is fast and produce
sbp commented on pull request #22:
URL:
https://github.com/apache/incubator-ponymail-foal/pull/22#issuecomment-835508387
The build is failing because the PyPI `blake3` module requires Rust and
Cargo. This PR requires either the `blake3` module to be installed, or Python
3.10. Unfortunatel
sbp opened a new pull request #23:
URL: https://github.com/apache/incubator-ponymail-foal/pull/23
The Python files in the `tools` directory are written to be run as scripts
from that directory. This means that the `archiver.py` file doesn't work when
installed as a package, which its own d
sbp opened a new pull request #24:
URL: https://github.com/apache/incubator-ponymail-foal/pull/24
This PR makes `archiver.py` more defensive when checking whether it can
write to the audit log, and fixes a small issue in `generators_old.py` when a
date is not available from the input messa
sebbASF commented on pull request #22:
URL:
https://github.com/apache/incubator-ponymail-foal/pull/22#issuecomment-835780765
What is the advantage of this generator?
AFAICT, it makes preservation of Permalinks much harder.
Unless one has the exact original input, it's not possible to
sebbASF opened a new issue #25:
URL: https://github.com/apache/incubator-ponymail-foal/issues/25
As the subject says: although the 'requests' package advertises itself as
AL2.0, it depends on chardet, which is LGPL.
PonyMail cannot therefore depend on requests if it is to retain its
sebbASF commented on issue #25:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/25#issuecomment-835813742
It looks like google.auth.transport.requests in turn depends on requests
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Humbedooh commented on issue #25:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/25#issuecomment-835828159
I was recently made aware of this potentiality, but I think this is both
allowed and not actually an issue any longer, as per
https://github.com/psf/requests/issues/33
Humbedooh commented on issue #25:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/25#issuecomment-835829550
google.auth is furthermore a very much optional component of foal, so I
don't think we need to discuss that one.
--
This is an automated message from the Apache Git
Humbedooh merged pull request #23:
URL: https://github.com/apache/incubator-ponymail-foal/pull/23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
Humbedooh merged pull request #24:
URL: https://github.com/apache/incubator-ponymail-foal/pull/24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
Humbedooh commented on pull request #22:
URL:
https://github.com/apache/incubator-ponymail-foal/pull/22#issuecomment-835832742
I am not in favor of this PR as it stands.
I don't think it should touch the DKIM generator, I am quite fond of that
one and would prefer it stay as is.
DKIM
sebbASF commented on issue #25:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/25#issuecomment-835833945
requests may no longer bundle chardet, however AFAICT it does not work
without it.
According to https://www.apache.org/legal/resolved.html#optional we can only
de
Humbedooh commented on issue #25:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/25#issuecomment-835834930
The LGPL license states:
> A program that contains no derivative of any portion of the Library, but
is designed to work with the Library by being compiled or linked
sebbASF commented on issue #25:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/25#issuecomment-835835720
Whether "this should be allowed" is up to Legal.
I contend that it is not currently permitted according to the page.
The fact that there are 50 projects that dep
Humbedooh commented on issue #25:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/25#issuecomment-835837915
Our legal page states:
> As with the previous question on platforms, you can rely on the component
if its license terms do not affect the Apache product's licensing.
Humbedooh commented on issue #25:
URL:
https://github.com/apache/incubator-ponymail-foal/issues/25#issuecomment-835855903
I decided to rewrite the OAuth plugins to not make use of any questionable
external dependencies. I think this addresses the issue fully.
--
This is an automated mes
sebbASF opened a new issue #26:
URL: https://github.com/apache/incubator-ponymail-foal/issues/26
AFAICT, Google Auth is supposed to be optional.
However it is listed in requirements.txt and AFAICT is unconditionally
imported by a plugin that is unconditionally imported.
--
This is
sebbASF closed issue #25:
URL: https://github.com/apache/incubator-ponymail-foal/issues/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
1 - 100 of 572 matches
Mail list logo
