Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/477
LGTM. Merging. Thanks @saurabh3091 !
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/450
LGTM. Thank you!
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/473
Thanks! Merging.
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/472
LGTM. Merging. Thanks!
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/470
+1 from me
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/466
@EmergentOrder is this ready to merge? I was waiting for build to pass but
it looks like a transient error to me. Do you mind resolving the conflicts? It
should trigger a new build.
---
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/predictionio/pull/471#discussion_r219938608
--- Diff: docs/manual/source/install/index.html.md.erb ---
@@ -24,8 +24,8 @@ limitations under the License.
It is **very important** to meet the
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/466
I think we should provide a migration tool if possible. I will file another
ticket for that.
---
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/predictionio/pull/471#discussion_r219937276
--- Diff: build.sbt ---
@@ -17,24 +17,7 @@
import PIOBuild._
lazy val scalaSparkDepsVersion = Map(
--- End diff --
Maybe we
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/471
Merging. Thank you!
---
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/predictionio/pull/471#discussion_r220067887
--- Diff: docs/manual/source/install/index.html.md.erb ---
@@ -24,8 +24,8 @@ limitations under the License.
It is **very important** to meet the
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/471
We should also update `bin/pio-class` to require Spark 2.0.0+. It is
currently set to 1.6.3.
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/471
@takezoe Looks great. I have no further comments. Thank you!
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/467
LGTM. Merging. Thank you!
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/462
@marevol Is there further updates to this PR? Is this ready for merging?
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/471
Just stumbled upon
https://github.com/apache/predictionio/blob/develop/data/src/main/spark-1/org/apache/predictionio/data/SparkVersionDependent.scala.
We probably should clean this up as well.
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/469
Thanks @shimamoto !
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/467
LGTM. Regarding automation, I think we can create scripts for some steps
inside the doc.
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/467
@shimamoto If you don't mind, please add the missing step that makes a
release on JIRA
(https://issues.apache.org/jira/projects/PIO?selectedItem=com.atlassian.jira.jira-projects-p
GitHub user dszeto opened a pull request:
https://github.com/apache/predictionio/pull/469
[PIO-153] Allow use of GNU tar on non-GNU systems
@chanlee514 please review.
@shimamoto you may want to include this in your PMC doc update.
You can merge this pull request into a Git
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/466
Please tag this PR with
[PIO-168](https://issues.apache.org/jira/browse/PIO-168).
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/466
Thanks @EmergentOrder ! Do you also have a migration tool for this change?
It would be nice if existing users have a way to upgrade.
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/467
That would be great too. What I meant was we need to mark the version as
released on JIRA. If you donât see the option in JIRA please let me know.
---
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/predictionio/pull/462#discussion_r218631217
--- Diff: docker/pio/Dockerfile ---
@@ -0,0 +1,71 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor
Github user dszeto commented on the issue:
https://github.com/apache/predictionio-sdk-php/pull/26
Your change was included in 0.9.1 that was released yesterday.
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio-sdk-php/pull/26
LGTM. THanks @sgrodzicki !
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio-sdk-php/pull/24
Sorry for the delay. This looks good to me now. Thanks @cafferata !
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/454
LGTM. Thanks @ramands !
---
Github user dszeto commented on the pull request:
https://github.com/apache/predictionio/commit/e734ff89db03d5a2acc409dc7e4ccb0cc37a1065#commitcomment-27940360
In docs/manual/source/install/install-sourcecode.html.md.erb:
In docs/manual/source/install/install
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/450
@voran Thank you for your contribution! Would you please fix the license
check test, file a ticket under Apache JIRA
(https://issues.apache.org/jira/projects/PIO/issues) and change the subject
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/441
@takezoe Unfortunately we can only close PRs with a commit message at this
point. Gitbox may help but it has not been working for me.
---
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/451
LGTM. Thanks!
---
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio-sdk-php/pull/24#discussion_r147047179
--- Diff: README.md ---
@@ -42,23 +42,11 @@ By Composer
The easiest way to install PredictionIO PHP client is to use
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio-sdk-ruby/pull/22
I am going to merge this and make a new release. Thanks @anothermh !
---
34 matches
Mail list logo
