[GitHub] incubator-predictionio-sdk-ruby issue #22: Add support for Ruby 2.4
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-sdk-ruby/pull/22 I am going to merge this and make a new release. Thanks @anothermh ! ---
[GitHub] incubator-predictionio-sdk-php pull request #24: Updated README.md
Github user dszeto commented on a diff in the pull request: https://github.com/apache/incubator-predictionio-sdk-php/pull/24#discussion_r147047179 --- Diff: README.md --- @@ -42,23 +42,11 @@ By Composer The easiest way to install PredictionIO PHP client is to use [Composer](http://getcomposer.org/). -1. Add `predictionio/predictionio` as a dependency in your project's ``composer.json`` file: +1. `Predictionio` is available on [Packagist](https://packagist.org/packages/league/csv) and can be installed using [Composer](https://getcomposer.org/): --- End diff -- Do you mean https://packagist.org/ instead for Packagist's link? The correct letter case for the module name should be `predictionio`. If indicating the project name, please use Apache PredictionIO. ---
[GitHub] predictionio-sdk-php issue #26: Use content encoding
Github user dszeto commented on the issue: https://github.com/apache/predictionio-sdk-php/pull/26 Your change was included in 0.9.1 that was released yesterday. ---
[GitHub] predictionio-sdk-php issue #24: Updated README.md
Github user dszeto commented on the issue: https://github.com/apache/predictionio-sdk-php/pull/24 Sorry for the delay. This looks good to me now. Thanks @cafferata ! ---
[GitHub] predictionio-sdk-php issue #26: Use content encoding
Github user dszeto commented on the issue: https://github.com/apache/predictionio-sdk-php/pull/26 LGTM. THanks @sgrodzicki ! ---
[GitHub] predictionio issue #450: bump up hbase client version and make it configurab...
Github user dszeto commented on the issue: https://github.com/apache/predictionio/pull/450 @voran Thank you for your contribution! Would you please fix the license check test, file a ticket under Apache JIRA (https://issues.apache.org/jira/projects/PIO/issues) and change the subject of this PR to have the ticket number please? ---
[GitHub] predictionio pull request #:
Github user dszeto commented on the pull request: https://github.com/apache/predictionio/commit/e734ff89db03d5a2acc409dc7e4ccb0cc37a1065#commitcomment-27940360 In docs/manual/source/install/install-sourcecode.html.md.erb: In docs/manual/source/install/install-sourcecode.html.md.erb on line 27: Do you mean "You can **download** a binary distribution..."? ---
[GitHub] predictionio pull request #471: [PIO-171] Drop Scala 2.10 and Spark 1.6 supp...
Github user dszeto commented on a diff in the pull request: https://github.com/apache/predictionio/pull/471#discussion_r219937276 --- Diff: build.sbt --- @@ -17,24 +17,7 @@ import PIOBuild._ lazy val scalaSparkDepsVersion = Map( --- End diff -- Maybe we can get rid of this `Map` as well? ---
[GitHub] predictionio issue #471: [PIO-171] Drop Scala 2.10 and Spark 1.6 support
Github user dszeto commented on the issue: https://github.com/apache/predictionio/pull/471 Merging. Thank you! ---
[GitHub] predictionio pull request #471: [PIO-171] Drop Scala 2.10 and Spark 1.6 supp...
Github user dszeto commented on a diff in the pull request: https://github.com/apache/predictionio/pull/471#discussion_r219938608 --- Diff: docs/manual/source/install/index.html.md.erb --- @@ -24,8 +24,8 @@ limitations under the License. It is **very important** to meet the minimum version of the following technologies that power Apache PredictionIO®. -* Apache Hadoop 2.6.5 (optional, required only if YARN and HDFS are needed) -* Apache Spark 1.6.3 for Hadoop 2.6 +* Apache Hadoop 2.7.3 (optional, required only if YARN and HDFS are needed) +* Apache Spark 2.1.1 for Hadoop 2.7 --- End diff -- I wonder if we should put Hadoop 2.6.x/2.7.x, and Spark 2.0+ here. We still run CI on Spark 2.0, and the Hadoop requirement comes mostly from Spark. ---
[GitHub] predictionio issue #470: [PIO-170] Upgrade sbt to 1.2.3
Github user dszeto commented on the issue: https://github.com/apache/predictionio/pull/470 +1 from me ---
[GitHub] predictionio issue #473: [PIO-167] Remove temporal maintenance tool from com...
Github user dszeto commented on the issue: https://github.com/apache/predictionio/pull/473 Thanks! Merging. ---
[GitHub] predictionio issue #450: [PIO-179] bump up hbase client version and make it ...
Github user dszeto commented on the issue: https://github.com/apache/predictionio/pull/450 LGTM. Thank you! ---
[GitHub] predictionio issue #477: [PIO-176] Clean up unmanaged sources in the data mo...
Github user dszeto commented on the issue: https://github.com/apache/predictionio/pull/477 LGTM. Merging. Thanks @saurabh3091 ! ---
[GitHub] predictionio issue #467: Update release instructions for PMC
Github user dszeto commented on the issue: https://github.com/apache/predictionio/pull/467 LGTM. Regarding automation, I think we can create scripts for some steps inside the doc. ---
[GitHub] predictionio issue #467: Update release instructions for PMC
Github user dszeto commented on the issue: https://github.com/apache/predictionio/pull/467 @shimamoto If you don't mind, please add the missing step that makes a release on JIRA (https://issues.apache.org/jira/projects/PIO?selectedItem=com.atlassian.jira.jira-projects-plugin%3Arelease-page=no-filter). ---
[GitHub] predictionio pull request #462: [PIO-86] Docker support
Github user dszeto commented on a diff in the pull request: https://github.com/apache/predictionio/pull/462#discussion_r218631217 --- Diff: docker/pio/Dockerfile --- @@ -0,0 +1,71 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +FROM openjdk:8 + +ENV PIO_TAG=v0.12.1 +ENV SCALA_VERSION=2.11.12 +ENV SPARK_VERSION=2.2.2 +ENV HADOOP_VERSION=2.7.7 +ENV ELASTICSEARCH_VERSION=5.5.3 +ENV PGSQL_VERSION=42.2.4 +ENV MYSQL_VERSION=8.0.12 +ENV PIO_HOME=/usr/share/predictionio + +RUN apt-get update && \ +apt-get install -y dpkg-dev fakeroot && \ +apt-get clean && \ +rm -rf /var/lib/apt/lists/* + +WORKDIR /opt/src +RUN git clone https://github.com/apache/predictionio.git --- End diff -- Agree. I intend to use this as the base for CI, replacing the current test image. ---
